Fix #4096 - RT error for ZoneControlThermostat

[jmarrec]

Pull request overview

• Fixes Round trip forward and reverse translation issue. #4096
• Fixes 3.1.0 upgrade issues openstudio-common-measures-gem#35 (comment)

ZoneControl:Thermostat,
  Thermal Zone 1 Thermostat,              !- Name
  Thermal Zone 1,                         !- Zone or ZoneList Name
  Thermal Zone 1 Thermostat Schedule,     !- Control Type Schedule Name
  ThermostatSetpoint:DualSetpoint,        !- Control 1 Object Type
  Thermostat Setpoint Dual Setpoint 1,    !- Control 1 Name
+  ,                                       !- Control 2 Object Type  <=== Need to properly handle a blank field here
  ,                                       !- Control 2 Name
  ,                                       !- Control 3 Object Type
  ,                                       !- Control 3 Name
  ,                                       !- Control 4 Object Type
  ,                                       !- Control 4 Name
+  0;                                      !- Temperature Difference Between Cutout And Setpoint {deltaC}     <=== because of this numeric field

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Checked behavior in OpenStudioApplication, adjusted policies as needed (src/openstudio_lib/library/OpenStudioPolicy.xml)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

520f146 has just the unit test, whcih throws:

Stacktrace
Running main() from gmock_main.cc
Note: Google Test filter = EnergyPlusFixture.ReverseTranslator_ZoneControlThermostat
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EnergyPlusFixture
[ RUN      ] EnergyPlusFixture.ReverseTranslator_ZoneControlThermostat
/Users/jenkins/git/OpenStudioIncremental/develop/src/energyplus/Test/ThermalZone_GTest.cpp:862: Failure
Expected: rt.translateWorkspace(w) doesn't throw an exception.
  Actual: it throws.
[  FAILED  ] EnergyPlusFixture.ReverseTranslator_ZoneControlThermostat (10 ms)
[----------] 1 test from EnergyPlusFixture (10 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (11 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] EnergyPlusFixture.ReverseTranslator_ZoneControlThermostat

The 3f49e17 fixes it:

[ci-commercialbuildings]

CI Results for 6337978:

• Linux:

  • OpenStudio-3.1.0-alpha+6337978038-Linux.deb
  • OpenStudio-3.1.0-alpha+6337978038-Linux.tar.gz

• Darwin:

  • OpenStudio-3.1.0-alpha+6337978038-Darwin.dmg
  • OpenStudio-3.1.0-alpha+6337978038-Darwin.tar.gz

• Windows:

  • OpenStudio-3.1.0-alpha+6337978038-Windows.exe
  • OpenStudio-3.1.0-alpha+6337978038-Windows.tar.gz

[jmarrec]

Removed "Pull Request - Ready for CI" label since it'll be built in #4100