Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4079 - Install E+ pythonwrapper lib #4080

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Sep 16, 2020

Pull request overview

Fix #4079 - Install E+ pythonwrapper lib

cf lib names in https://github.com/NREL/EnergyPlus/blob/826411f0640559211bf3c965867fb095f737310e/src/EnergyPlus/PluginManager.cc#L144-L150

Please read OpenStudio Pull Requests to better understand the OpenStudio Pull Request protocol.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Checked behavior in OpenStudioApplication, adjusted policies as needed (src/openstudio_lib/library/OpenStudioPolicy.xml)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added severity - Blocker component - Installer/Platform Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Sep 16, 2020
@jmarrec jmarrec added this to the OpenStudio SDK 3.1.0 milestone Sep 16, 2020
@jmarrec jmarrec requested a review from tijcolem September 16, 2020 10:10
@jmarrec jmarrec self-assigned this Sep 16, 2020
Copy link
Collaborator

@tijcolem tijcolem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and good catch adding in the E+ python wrapper!

@tijcolem tijcolem merged commit aa61fc9 into develop Sep 16, 2020
@tijcolem tijcolem deleted the 4079_eplus_pythonwrapper branch September 16, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - Installer/Platform Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to install (lib)pythonwrapper library from EnergyPlus v9.4 or unable to run any simulations
3 participants