Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4025 space clone #4073

Merged
merged 62 commits into from
Sep 18, 2020
Merged

4025 space clone #4073

merged 62 commits into from
Sep 18, 2020

Conversation

kbenne
Copy link
Contributor

@kbenne kbenne commented Sep 11, 2020

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)
  • DESCRIBE PURPOSE OF THIS PULL REQUEST

Please read OpenStudio Pull Requests to better understand the OpenStudio Pull Request protocol.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Checked behavior in OpenStudioApplication, adjusted policies as needed (src/openstudio_lib/library/OpenStudioPolicy.xml)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

joseph-robertson and others added 30 commits September 4, 2020 11:42
@joseph-robertson
Store subsurface on shading control instead of shading control on sub…
691f6a7 
…surface.
@joseph-robertson
Stub new methods for subsurface and shading control.
71318ce
@kbenne
Improve clone for objects using SurfacePropertyConvectionCoefficients
8f1e1f2 
ref #4025
@joseph-robertson
Start filling out methods for shading control.
f9df752
@joseph-robertson
Start filling out methods for sub surface.
4c453f5
@joseph-robertson
Continue to fill out sub surface methods.
92fdd7b
@joseph-robertson
Add new model test for sub surface.
f84e710
@joseph-robertson
Add new model test for shading control.
b282d03
@kbenne
Include related ShadingControl in SubSurface::clone
d3d23ed 
ref #4025
@joseph-robertson
Clean up some model and test files.
b14c8f7
@joseph-robertson
Start a vt for sub surface and shading control.
afda1a1
@kbenne
Fix Surface::clone for attached SurfacePropertyExposedFoundationPerim…
0f5364e 
…eter

ref #4025
@joseph-robertson
Updates to source files after review.
4ab9318
@jmarrec
Make some changes to ShadingControl.
8b1664b
@jmarrec
Remove the deprecated functions from the Impl API to fix compiler error
3e236f1
@jmarrec
const-correctness; ,no ABI break: cannot pass cosnt ShadingCOntrol& w…
2f008b3 
…hen we are mutating it.

m
@jmarrec
ABI break of now-deprecated function
ff629b3
@jmarrec
Update description
373d248
@jmarrec
Update FT to avoid error using deprecated. is this still needed? @jos…
87820ee 
…eph-robertson
@jmarrec
Implement new MultipleSurfaceControlType field in Shading Control
5dd85a1
@jmarrec
The Radiance Forward Translator also needs to be update. I'm just mak…
6619cbf 
…ing a crude change for build to keep going

@joseph-robertson
@jmarrec
VT & FT for MultipleSurfaceControlType
3c610c1
@jmarrec
There's a problem with the extensibles
b682148 
[18] 3_1_0(main)> sc.addSubSurface(s)
NameError: undefined local variable or method `s' for main:Object
from (pry):16:in `__pry__'
[19] 3_1_0(main)> sc.addSubSurface(ss)
[openstudio.IdfExtensibleGroup] <2> This extensible group is invalid, and so does not have an index.
RuntimeError: /home/julien/Software/Others/OpenStudio/src/utilities/idf/IdfExtensibleGroup.cpp@199 : This extensible group is invalid, and so does not have an index.
from (pry):17:in `addSubSurface'
@jmarrec
Write a VT test and adjust VT: Always deal with OS:SubSurface, and pr…
85fdf12 
…escan for speed.
@jmarrec
typo in VT test
cfdf3ee
@kbenne
Clone KivaFoundation as part of Surface
b76a96c 
ref #4025
@joseph-robertson
Fix, updates to idd.
257fb6a
@joseph-robertson
Skip adding a subsurface that already exists.
64d54a7
@joseph-robertson
Update and improve tests.
bb37994
@jmarrec
Model test for ShadingControl 'Multiple Surface Control Type' field (…
bd53023 
…new)
@kbenne
Copy link
Contributor Author

kbenne commented Sep 14, 2020

@jmarrec and @joseph-robertson #4066 is included in this PR. Awaiting final draft of #4066 to merge this.

joseph-robertson and others added 21 commits September 14, 2020 15:40
@joseph-robertson
Fix rt and update rt tests.
8ea432e
@joseph-robertson
Improve shading control rt and tests.
fbfd1db
@joseph-robertson
Merge branch 'develop' into multiple-shading-controls
005f0a4
@jmarrec
Catch the case where neither Shading Material nor Construction are as…
80ffb2f 
…signed in the FT
@jmarrec
Extend the ShadingControl FT test to check all fields currently avail…
7ee6d21 
…able in depth
@jmarrec
Fix #4074 - Implement Setpoint2 and support all Shading Control Type …
d6041d8 
…& improve model logic
@jmarrec
Exit RT for ShadingControl if neither the shadingMaterial nor Constru…
1a92506 
…ction are valid
@jmarrec
Fix RT by using a Construction instead of the not RT'ed WindowMateria…
f95045f 
…l:Blind and test a few more fields
@jmarrec
Add some release notes for this PR
b06fd15
@jmarrec
Missing an override keyword
9d5b2ac
@jmarrec
#4074 Followup: add test for logic, and avoid clearing Setpoint2/Sche…
361e509 
…dule all the time. Left A TODO
@jmarrec
Typo in C# partial class
33df578
@jmarrec
Unrelated C# fixed while I'm at it.
b751a34
@jmarrec
Unrelated issue in ModelObject::getAutosizedValue
bec2af2 
Found it while investigating #4062
@joseph-robertson
Include glare and slat angle control in api.
64f1a6d
@joseph-robertson
Merge branch 'multiple-shading-controls' of github.com:NREL/OpenStudi…
abe551f 
…o into multiple-shading-controls
@jmarrec
Another typo in getAutosizedValue
7bea01b
@joseph-robertson
Updates to release notes draft.
81be659
@jmarrec
Add static typeofSlatAngleControlforBlindsValues
142330d
@jmarrec
Merge remote-tracking branch 'origin/develop' into multiple-shading-c…
e454bfa 
…ontrols
@kbenne
Merge remote-tracking branch 'origin/multiple-shading-controls' into …
d32be89 
…4025-Space-Clone
@kbenne kbenne mentioned this pull request Sep 18, 2020
Merged
30 tasks
@kbenne kbenne merged commit 24e2835 into develop Sep 18, 2020
@kbenne kbenne deleted the 4025-Space-Clone branch September 18, 2020 15:46
@tijcolem tijcolem mentioned this pull request Sep 18, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbenne @joseph-robertson @jmarrec