Fix #3314 - GBXML translate spaces etc even if Facility and/or Building aren't instantiated #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
severity - Normal Bug
component - gbXML
Pull Request - Ready for CI
jmarrec
commented
Jun 18, 2020
Comment on lines
+96
to
+99
| // Facility and Building could not be explicitly instantiated in the model, but the functions still need to be called so that Spaces and surfaces | ||
| // are translated. Facility and Building both are UniqueModelObjects, so passing model here as an argument is harmless | ||
| boost::optional<pugi::xml_node> translateFacility(const openstudio::model::Model& model, pugi::xml_node& parent); | ||
| boost::optional<pugi::xml_node> translateBuilding(const openstudio::model::Model& model, pugi::xml_node& parent); |
There was a problem hiding this comment.
Private methods now take model instead of facility / building. And in there it will conditionally check if there is a facility / building to use or default things.
Comment on lines
+417
to
+428
| // `model` is `const`, so we shouldn't call getUniqueModelObject<model::Facility> which will **create** a new object in there. | ||
| boost::optional<model::Facility> _facility = model.getOptionalUniqueModelObject<model::Facility>(); | ||
|
|
||
| auto result = parent.append_child("Campus"); | ||
| m_translatedObjects[facility.handle()] = result; | ||
| std::string name = "Facility"; | ||
|
|
||
| boost::optional<std::string> name = facility.name(); | ||
| if (_facility) { | ||
| m_translatedObjects[_facility->handle()] = result; | ||
| if (auto _s = _facility->name()) { | ||
| name = _s.get(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Check if there is an actual explicitly instantiated Facility object to use, otherwise default things.
|
|
||
| // translate surfaces | ||
| // TODO: JM 2020-06-18 Why is translateSpace not responsible to call this one? |
There was a problem hiding this comment.
I find it strange that the Surfaces are translated in translateFacility
jmarrec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Also fix a ReverseTranslator issue that I found where the Material
Roughnessends up empty.Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)src/openstudio_lib/library/OpenStudioPolicy.xml)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.