Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2797 - Do not translate a ZoneHVACLowTempRadiant object if it doesn't have any surfaces with Internal Source #3986

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 15, 2020

Pull request overview

Pull Request Author

This PR only touches the ForwardTranslator

  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added component - HVAC component - IDF Translation Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels May 15, 2020
@jmarrec jmarrec requested a review from kbenne May 15, 2020 14:26
@jmarrec jmarrec self-assigned this May 15, 2020
@kbenne
Copy link
Contributor

kbenne commented Aug 10, 2020

@jmarrec can you speculate as to why there is a random test failure on Windows?

The following tests FAILED:
	2366 - EnergyPlusFixture.ForwardTranslatorTest_MultiThreadedLogMessages (Failed)

I'm guessing it is unrelated but it would be nice to know a little more.

@jmarrec
Copy link
Collaborator Author

jmarrec commented Aug 10, 2020

@jmarrec can you speculate as to why there is a random test failure on Windows?

The following tests FAILED:
	2366 - EnergyPlusFixture.ForwardTranslatorTest_MultiThreadedLogMessages (Failed)

I'm guessing it is unrelated but it would be nice to know a little more.

Same as this #3912

@kbenne kbenne merged commit c68fcf6 into develop Aug 10, 2020
@kbenne kbenne deleted the 2797_LowTempRadiant_SurfaceGroups branch August 10, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - HVAC component - IDF Translation Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LowTempRadiant Forward Translations can create empty ZoneHVAC:LowTemperatureRadiant:SurfaceGroup
2 participants