Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3943 - ThreeJS handle ConstructionAirBoundary as "AirWall" material #3971

Merged
merged 3 commits into from
May 7, 2020

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 7, 2020

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Model API methods are tested (in src/model/test)
  • Checked behavior in OpenStudioApplication, adjusted policies as needed (src/openstudio_lib/library/OpenStudioPolicy.xml)
  • All new and existing tests passes

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added severity - Minor Bug component - Geometry Editor Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels May 7, 2020
@jmarrec jmarrec self-assigned this May 7, 2020
@tijcolem tijcolem merged commit 8ae4d88 into develop May 7, 2020
@tijcolem tijcolem deleted the 3943_ThreeJS_ConstructionAirBoundary branch May 7, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - Geometry Editor Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Minor Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThreeJS should handle ConstructionAirBoundary
2 participants