Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching the BCL for components and measures should be more helpful (and more up to date): add version_modified, repo_url to BCLSearchResult #5125

Closed
jmarrec opened this issue Mar 26, 2024 · 1 comment · Fixed by #5126
Closed

Searching the BCL for components and measures should be more helpful (and more up to date): add version_modified, repo_url to BCLSearchResult #5125

jmarrec opened this issue Mar 26, 2024 · 1 comment · Fixed by #5126
Assignees
@jmarrec
Labels
component - Measures component - Utilities Other Enhancement Request

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 26, 2024

Enhancement Request

BCLSearchResult does not contain version_modified, repo_url, org etc.

It does try to get provenance (BCLProvenance). Is that still a thing or it's gone in BCL V2?

Detailed Description

https://bcl.nrel.gov/api/search/*.json?fq=bundle:measure&fq=measure_tags:HVAC

image

https://bcl.nrel.gov/api/search/*.json?fq=bundle:component&fq=component_tags:HVAC

image

Possible Implementation
@jmarrec jmarrec changed the title Searching the BCL for components and measures should be more helpful (and more up to date): add version, repo_url to BCLSearchResult Searching the BCL for components and measures should be more helpful (and more up to date): add version_modified, repo_url to BCLSearchResult Mar 26, 2024
@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 26, 2024

Related would be probably to enhance this too: https://github.com/NREL/bcl-gem/blob/cb26a65eb4569a4dfd92485f7d7d28d5094e39f0/lib/bcl/base_xml.rb#L51-L62

@jmarrec jmarrec self-assigned this Mar 26, 2024
@jmarrec jmarrec mentioned this issue Mar 26, 2024
Closed
jmarrec added a commit that referenced this issue Mar 26, 2024
@jmarrec
Fix #5125 - Add versionModified, repo, org, releaseTag to BCLSEarchRe…
d78870d 
…sult + shush some annoying warnings due to trying to parse VersionString with empty string
@jmarrec jmarrec mentioned this issue Mar 26, 2024
Merged
19 tasks
jmarrec added a commit that referenced this issue Mar 27, 2024
@jmarrec
Merge pull request #5126 from NREL/5125_BCLSearchResult_Improve
1b653ae 
Fix #5125 - Add versionModified, repo, org, releaseTag to BCLSearchResult
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
component - Measures component - Utilities Other Enhancement Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5125 - Add versionModified, repo, org, releaseTag to BCLSearchResult NREL/OpenStudio
1 participant
@jmarrec