Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AirLoopHVACUnitarySystem: Look at changes in Fan energy use between 3.6.1 and current develop #4963

Closed
DavidGoldwasser opened this issue Sep 8, 2023 · 5 comments
Closed

AirLoopHVACUnitarySystem: Look at changes in Fan energy use between 3.6.1 and current develop #4963

DavidGoldwasser opened this issue Sep 8, 2023 · 5 comments
Assignees
@jmarrec
Labels
Triage Issue needs to be assessed and labeled, further information on reported might be needed
Milestone
OpenStudio SDK 3.7.0

Comments

@DavidGoldwasser
Copy link
Collaborator

Issue overview

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context
@DavidGoldwasser DavidGoldwasser added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Sep 8, 2023
@DavidGoldwasser DavidGoldwasser added this to the OpenStudio SDK 3.7.0 milestone Sep 8, 2023
@DavidGoldwasser
Copy link
Collaborator Author

More detail to come later

@mdahlhausen
Copy link
Collaborator

OpenStudio is now defaulting the "Supply Air Flow Rate Method During Heating Operation" and "Supply Air Flow Rate Method During Cooling Operation" fields to "supplyairflowrate", which is causing regression and performance differences in OpenStudio models.
image

jmarrec added a commit that referenced this issue Sep 18, 2023
@jmarrec
Potential fix for #4963 - When Method is None or empty, doesn't matte…
c855d5a 
…r if the flow rate is Autosized, it takes precendence

cf https://github.com/NREL/EnergyPlus/blob/4502b0c6561281693f837217eb99339372b86abd/src/EnergyPlus/UnitarySystem.cc#L6080-L6081
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 18, 2023 •
edited
Loading

This is only on develop, Changed in

@jmarrec jmarrec mentioned this issue Sep 18, 2023
Merged
19 tasks
@mdahlhausen
Copy link
Collaborator

Was the intent of #4873 to set new defaults, and accept the resulting change in fan energy use for models made in prior versions of OpenStudio?

@jmarrec jmarrec mentioned this issue Sep 20, 2023
Closed
@jmarrec jmarrec changed the title Look at changes in Fan energy use between 3.6.1 and current develop AirLoopHVACUnitarySystem: Look at changes in Fan energy use between 3.6.1 and current develop Sep 21, 2023
jmarrec added a commit that referenced this issue Sep 21, 2023
@jmarrec
Potential fix for #4963 - When Method is None or empty, doesn't matte…
be31f38 
…r if the flow rate is Autosized, it takes precendence

cf https://github.com/NREL/EnergyPlus/blob/4502b0c6561281693f837217eb99339372b86abd/src/EnergyPlus/UnitarySystem.cc#L6080-L6081
jmarrec added a commit that referenced this issue Sep 26, 2023
@jmarrec
Potential fix for #4963 - When Method is None or empty, doesn't matte…
7e8f062 
…r if the flow rate is Autosized, it takes precendence

cf https://github.com/NREL/EnergyPlus/blob/4502b0c6561281693f837217eb99339372b86abd/src/EnergyPlus/UnitarySystem.cc#L6080-L6081
jmarrec added a commit that referenced this issue Sep 27, 2023
@jmarrec
Merge pull request #4971 from NREL/4963_Unitary_DefaultWhenNoHeatingO…
e31381d 
…rCoolingRequired

#4963 - AirLoopHVACUnitarySystem Default Supply Air Flow Rate Method When No Cooling or Heating is Required to None
@jmarrec
Copy link
Collaborator

jmarrec commented Oct 2, 2023

@jmarrec jmarrec closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
Triage Issue needs to be assessed and labeled, further information on reported might be needed
Projects
None yet
Milestone
OpenStudio SDK 3.7.0
Development

No branches or pull requests
3 participants
@mdahlhausen @DavidGoldwasser @jmarrec