AvailabilityManagerNightCycle Manger issue

[DavidGoldwasser]

Issue overview

See post and video here
https://unmethours.com/question/45968/simulation-failed-when-adding-night-manager/

Current Behavior

["C:\Users\jenkins\git\OpenStudio\src\model\AvailabilityManagerNightCycle.cpp@243 : Object of type 'OS:AvailabilityManager:NightCycle' and named 'AVM Night Cycle 1' does not have a controlThermalZoneList attached:

Expected Behavior

Steps to Reproduce

1. m = exampleModel()
2. Go to AirLoopHVAC, go to Control
3. Drag an AVM:NightCycle from the Library (do not use the "Use Night cycle" dropdown)

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version):
• Version of OpenStudio (if using an intermediate build, include SHA): 3.0.1 ff0e898

Context

[DavidGoldwasser]

CC @kbenne @mdahlhausen any thoughts on this

[mdahlhausen]

Not sure. Maybe some interaction with always on discrete schedule and the night cycle? I haven't tried this in OS 3.0 yet. Seems like a bug for sure.

[jmarrec]

I was able to reproduce, I edited the OP to include steps to reproduce.

The key is Drag from Library (= Clone) and not use the "Use Night cycle" dropdown (= Constructor).

The Constructor will create the needed ModelObjectList, the clone isn't doing it.

Ideally these would be have children of the AVMNightCycle, I think I didn't do that because of the OSApp (or they would actually show), and I will not do that now either. Either way, the clone/remove need to be overridden