Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gbXML issue with workflow from OSM to came up on OpenStudio 3.0 #4001

Closed
DavidGoldwasser opened this issue Jun 19, 2020 · 3 comments · Fixed by #4005
Closed

gbXML issue with workflow from OSM to came up on OpenStudio 3.0 #4001

DavidGoldwasser opened this issue Jun 19, 2020 · 3 comments · Fixed by #4005
Assignees
@jmarrec
Labels
component - gbXML severity - Normal Bug
Milestone
OpenStudio SDK 3.1.0

Comments

@DavidGoldwasser
Copy link
Collaborator

It appears that with a specific model gbXML export pre OpenStudio 3.0 worked fine into HAP and Trace, but with 3.0 it fails to both of those locations.

See UH post for more details
https://unmethours.com/question/45292/failed-to-export-gbxml/

/--------------

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context
@DavidGoldwasser DavidGoldwasser added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Jun 19, 2020
@DavidGoldwasser
Copy link
Collaborator Author

@kbenne @pflaumingo thought you might have insights or interest in this.

@jmarrec
Copy link
Collaborator

jmarrec commented Jun 22, 2020

I can pick this one up if I get test files to reproduce, I asked @nfonner on UnmetHours to provide some if he can.

@jmarrec jmarrec assigned jmarrec and unassigned tijcolem Jun 23, 2020
@jmarrec
Copy link
Collaborator

jmarrec commented Jun 23, 2020

I got the files from @nfonner. the two OSMs are widely different, so I did something else.

I took his 281 osm, and with 2.8.1, 2.9.1, and 3.0.0 I load that OSM, then GbXMLForwardTranslate it to an xml. Then I proceeded to lint the xmls using xmllint to canonically sort themso I could diff them easily... 281 and 291 linted properly, but 3.0.0 has problems!

(py38)julien@manual (master %=)$ xmllint --c14n model281.xml > lint281.xml
(py38)julien@manual (master %=)$ xmllint --c14n model291.xml > lint291.xml
(py38)julien@manual (master %=)$ xmllint --c14n model300.xml > lint300.xml
model300.xml:1712: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:9166: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:10713: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:10828: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:12371: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:14041: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:14211: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:15180: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:15681: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:16733: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:18412: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:19058: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:19165: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:19588: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:20461: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:21044: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:21624: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:22086: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:24529: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:25212: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:25932: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:26067: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:26562: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:26786: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:27891: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:27929: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:28045: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:28131: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:28511: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:29722: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:29924: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:29972: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:30125: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:30231: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:32008: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"
                                                                               ^
model300.xml:32234: parser error : Attribute surfaceType redefined
 constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade"

Indeed, line 1712 has the following and surfaceType is indeed defined twice and to different values.

    <Surface id="Surface_731" surfaceType="UndergroundSlab" constructionIdRef="ExtSlabCarpet_4in_ClimateZone_1-8" surfaceType="SlabOnGrade">

jmarrec added a commit that referenced this issue Jun 23, 2020
@jmarrec
#4001 - do not duplicate surfaceType when slab
a6d3b4d
jmarrec added a commit that referenced this issue Jun 23, 2020
@jmarrec
Add unit test for #4001
299099e
jmarrec added a commit that referenced this issue Jun 23, 2020
@jmarrec
Fix #4001 - do not duplicate surfaceType when slab
f928802
@jmarrec jmarrec mentioned this issue Jun 23, 2020
Merged
20 tasks
@jmarrec jmarrec added severity - Normal Bug and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jun 23, 2020
@tijcolem tijcolem added this to the OpenStudio SDK 3.1.0 milestone Jul 10, 2020
tijcolem added a commit that referenced this issue Jul 16, 2020
@tijcolem
Merge pull request #4005 from NREL/4001_gbXML_FT_issue
1a2828b 
Fix #4001 - gbXML issue on ForwardTranslation - surfaceType attribute written twice for SlabOnGrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
component - gbXML severity - Normal Bug
Projects
None yet
Milestone
OpenStudio SDK 3.1.0
3 participants
@DavidGoldwasser @jmarrec @tijcolem