Multiple AirLoopHVAC serving the same zone: DSOA is only added the Controller:MechanicalVentilation for the first AirLoopHVAC

[jmarrec]

Issue overview

The guilty part is here:

OpenStudio/src/energyplus/ForwardTranslator/ForwardTranslateSizingZone.cpp

Lines 298 to 345 in d05bc3a

	// Add ThermalZone and associated design objects to ControllerMechanicalVentilation.
	// This would be done in forwardTranslateControllerMechanicalVentilation except doing it here maintains proper order of the idf file.
	boost::optional<model::ControllerMechanicalVentilation> controllerMechanicalVentilation;
	boost::optional<IdfObject> _controllerMechanicalVentilation;
	if( boost::optional<model::AirLoopHVAC> airLoopHVAC = thermalZone.airLoopHVAC() )
	{
	if( boost::optional<model::AirLoopHVACOutdoorAirSystem> oaSystem = airLoopHVAC->airLoopHVACOutdoorAirSystem() )
	{
	model::ControllerOutdoorAir controllerOutdoorAir = oaSystem->getControllerOutdoorAir();
	controllerMechanicalVentilation = controllerOutdoorAir.controllerMechanicalVentilation();
	}
	}
	if( controllerMechanicalVentilation )
	{
	_controllerMechanicalVentilation = translateAndMapModelObject(controllerMechanicalVentilation.get());
	}
	if( _controllerMechanicalVentilation && _thermalZone )
	{
	IdfExtensibleGroup eg = _controllerMechanicalVentilation->pushExtensibleGroup();
	// Thermal Zone Name
	eg.setString(Controller_MechanicalVentilationExtensibleFields::ZoneorZoneListName,_thermalZone->name().get());
	// DesignSpecificationOutdoorAir
	std::vector<model::Space> spaces = thermalZone.spaces();
	if( spaces.size() > 0 )
	{
	if( boost::optional<model::DesignSpecificationOutdoorAir> designOASpec = spaces.front().designSpecificationOutdoorAir() )
	{
	if( boost::optional<IdfObject> _designOASpec = translateAndMapModelObject(designOASpec.get()) )
	{
	eg.setString(Controller_MechanicalVentilationExtensibleFields::DesignSpecificationOutdoorAirObjectName,_designOASpec->name().get());
	}
	}
	}
	// DesignSpecificationZoneAirDistributionObjectName
	if( _thermalZone && isDSZADTranslated )
	{
	eg.setString(Controller_MechanicalVentilationExtensibleFields::DesignSpecificationZoneAirDistributionObjectName, dSZADName);
	}
	}

As you can see, it'll do it for the first airLoopHVAC it finds, not for all of them.

It calls HVACComponent_Impl::airLoopHVAC() whereas it should call ThermalZone::airLoopHVACs() on loop on that

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version): all
• Version of OpenStudio (if using an intermediate build, include SHA): 3.0.0-pre1, d05bc3a

Context

Reported on slack.