Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add window frame and divider to skylights #2895

Closed
asparke2 opened this issue Dec 8, 2017 · 1 comment · Fixed by #4012
Closed

Cannot add window frame and divider to skylights #2895

asparke2 opened this issue Dec 8, 2017 · 1 comment · Fixed by #4012

Comments

@asparke2
Copy link
Member

asparke2 commented Dec 8, 2017

OpenStudio currently limits the attachment of WindowPropertyFrameAndDivider objects to FixedWindow, OperableWindow, and GlassDoor SubSurfaces. This may have been a limitation of EnergyPlus at some point, but does not appear to be one now. The DOE prototype buildings use frames on skylights, which the current implementation prevents.

Solution:
Extend the list of acceptable SubSurface types to include Skylight. Perhaps it should also include other types as well?

@asparke2
Copy link
Member Author

asparke2 commented Dec 8, 2017

I suppose it is important to make sure the the Forward Translator code for this field will work on skylights (I think it will).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants