Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaterHeater:Mixed not forward translated when not on loop #1675

Closed
mbadams5 opened this issue Jun 7, 2015 · 2 comments · Fixed by #4011
Closed

WaterHeater:Mixed not forward translated when not on loop #1675

mbadams5 opened this issue Jun 7, 2015 · 2 comments · Fixed by #4011

Comments

@mbadams5
Copy link
Contributor

mbadams5 commented Jun 7, 2015

If a WaterHeater:Mixed is not on a SWH PlantLoop then it is not forward translated.

A water heater can be standalone when PeakUseFlowRate and UseFlowRateFractionSchedule are set.

I came across this in a few prototype buildings where this is used.

This iddobjectype just need to be added to here

One option around this is to create a plantloop with a pump that has basically zero head pressure and a water use equipment that is the same as the PeakUseFlowRate and has a schedule the same as UseFlowRateFractionSchedule.

fyi @kbenne

@jmarrec
Copy link
Collaborator

jmarrec commented May 14, 2020

Agreed that this should be supported.

One thing I dislike about is that the "Peak Use Flow Rate", which is the condition to check if the WH isn't hooked to a PlantLoop to see if it is really meant standalone, was made required-field and is default-initialized in the ctor to 0.1 m3/s.

That basically means ANY WaterHeaterMixed in your model will be translated no matter what. That could be confusing and could be hard to tell that it is actually happening. Perhaps that's ok though.

@kbenne thoughts please?

@kbenne
Copy link
Contributor

kbenne commented Jun 15, 2020

Given that Peak Use Flow Rate is required, it seems like we don't have the option to selectively translate this type anymore. My feeling is that we should just accept that it is always translated, and therefore do what @mbadams5 suggests and just add it to the list of always translated types.

I'm assuming that making Peak Use Flow Rate optional would be a breaking api change, and I wouldn't changing the API.

jmarrec added a commit that referenced this issue Jul 1, 2020
jmarrec added a commit that referenced this issue Jul 1, 2020
jmarrec added a commit that referenced this issue Jul 1, 2020
typo
kbenne added a commit that referenced this issue Aug 14, 2020
Fix #1675 - ForwardTranslate WaterHeater:Mixed when not on loop but has Peak Use Flow Rate (standalone operation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants