Merge pull request #4986 from NREL/actions_pypi

Fix #4975 - Build python bindings on windows for python 3.11
NREL · Sep 28, 2023 · 1928acf · 1928acf
2 parents b7fb557 + 8c30a2a
commit 1928acf
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/.github/workflows/python_bindings.yml b/.github/workflows/python_bindings.yml
@@ -24,7 +24,7 @@ jobs:
       # fail-fast: Default is true, switch to false to allow one platform to fail and still run others
       fail-fast: false
       matrix:
-        name: [Ubuntu, macOS, Windows_py37, Windows_py38, Windows_py39, Windows_py310]
+        name: [Ubuntu, macOS, Windows_py37, Windows_py38, Windows_py39, Windows_py310, Windows_py311]
         include:
         - name: Ubuntu
           os: ubuntu-20.04
@@ -54,6 +54,10 @@ jobs:
         - name: Windows_py310
           os: windows-2019
           python-version: '3.10'
+          allow_failure: false
+        - name: Windows_py311
+          os: windows-2019
+          python-version: '3.11'
           allow_failure: true  # Possible this fails, don't care yet
 
     steps:
@@ -106,7 +110,7 @@ jobs:
           echo "Using chocolatey to install ninja"
           choco install ninja
           # C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise
-          MSVC_DIR=$(cmd.exe /c "vswhere -products * -requires Microsoft.Component.MSBuild -property installationPath -latest")
+          MSVC_DIR=$(vswhere -products '*' -requires Microsoft.Component.MSBuild -property installationPath -latest)
           echo "Latest is: $MSVC_DIR"
           echo "MSVC_DIR=$MSVC_DIR" >> $GITHUB_ENV
           # add folder containing vcvarsall.bat
@@ -215,7 +219,7 @@ jobs:
         elif [ "$RUNNER_OS" == "macOS" ]; then
           cmake --build . --target package -j 2
         fi;
-          
+
     # We always upload to testpypi
     - name: Build python wheel
       shell: bash
@@ -252,7 +256,7 @@ jobs:
     - name: Install Python dependencies
       run: |
         python -m pip install --upgrade pip
-        # urllib3 2.0 breaks 
+        # urllib3 2.0 breaks
         pip install urllib3==1.26.15
         pip install setuptools wheel twine requests packaging
         mkdir wheels
@@ -297,7 +301,7 @@ jobs:
       # fail-fast: Default is true, switch to false to allow one platform to fail and still run others
       fail-fast: false
       matrix:
-        name: [Ubuntu, macOS, Windows_py37, Windows_py38, Windows_py39, Windows_py310]
+        name: [Ubuntu, macOS, Windows_py37, Windows_py38, Windows_py39, Windows_py310, Windows_py311]
         include:
         - name: Ubuntu
           os: ubuntu-20.04
@@ -322,6 +326,10 @@ jobs:
         - name: Windows_py310
           os: windows-2019
           python-version: '3.10'
+          allow_failure: false
+        - name: Windows_py311
+          os: windows-2019
+          python-version: '3.11'
           allow_failure: true  # Possible this fails, don't care yet
 
     steps: