Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded openstudio version and sha #564

Merged
merged 1 commit into from
May 12, 2020
Merged

Remove hardcoded openstudio version and sha #564

merged 1 commit into from
May 12, 2020

Conversation

nllong
Copy link
Member

@nllong nllong commented May 12, 2020

Remove places where the OpenStudio version and SHAs were hard coded for dev3 development.

@nllong nllong requested a review from brianlball May 12, 2020 20:27
brianlball
brianlball approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@brianlball brianlball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.801% when pulling 0f3395f on remove-hardcoded-install into 1ef3bb9 on develop.

@nllong nllong merged commit 82e25f7 into develop May 12, 2020
@nllong nllong deleted the remove-hardcoded-install branch May 12, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianlball brianlball brianlball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nllong @coveralls @brianlball