Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refrigeration_system: Tank attached to Coil:WaterHeating:Desuperheater isn't connected to anything #113

Closed
jmarrec opened this issue Aug 27, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@jmarrec
Copy link
Contributor

jmarrec commented Aug 27, 2020

In current develop, and also in V940IOFreeze, the test fails due to this NREL/OpenStudio#4011 which doesn't translate a WaterHeater:Mixed if not on a plantloop or with enough schedules to produce stand alone operation.

water_tank = OpenStudio::Model::WaterHeaterMixed.new(model)
water_tank.setAmbientTemperatureIndicator("ThermalZone")
water_tank.setAmbientTemperatureThermalZone(z)
#Schedule Ruleset
setpointTemperatureSchedule = OpenStudio::Model::ScheduleRuleset.new(model)
setpointTemperatureSchedule.setName("Setpoint Temperature Schedule")
setpointTemperatureSchedule.defaultDaySchedule.setName("Setpoint Temperature Schedule Default")
setpointTemperatureSchedule.defaultDaySchedule.addValue(OpenStudio::Time.new(0,24,0,0), 70)
desuperheater = OpenStudio::Model::CoilWaterHeatingDesuperheater.new(model, setpointTemperatureSchedule)
water_tank.setSetpointTemperatureSchedule(setpointTemperatureSchedule)
desuperheater.addToHeatRejectionTarget(water_tank)
desuperheater.setHeatingSource(water_cooled_condenser)

The test is wrong, not the SDK: there is no point at all connecting a coil desuperheater to a tank that actually serves no uses. This is going to produce a deviation in EUI though, so either leave it as is (but this issue explains it), or rewrite the history by re-running the tests... the OSM test is from 1.3.0, so that means rerunning ALL versions back to 2.0.4 (which takes quite some time).

@jmarrec jmarrec added the bug label Aug 27, 2020
@jmarrec jmarrec self-assigned this Aug 27, 2020
@jmarrec jmarrec added this to the 3.1.0 milestone Aug 27, 2020
jmarrec added a commit that referenced this issue Aug 27, 2020
…(it was failing anyways before that), and replace the OSM with that one

m

Delete results too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant