Correct example file PackagedTerminalHeatPump_LatentSizing_SensibleAndLatent Sizing:Zone humidity set point schedules

[rraustad]

Pull request overview

• Fixes Correct example file PackagedTerminalHeatPump_LatentSizing_SensibleAndLatent zone sizing humidity set point schedules #9654
• New example file should have used schedules for Sizing:Zone dehumidification and humidification RH set points

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

Corrects new example file to 1) use schedules instead of numerics, and 2) use a dehumidification set point that is higher than humidification set point.

[Myoldmopar]

👍 makes sense.

[rraustad]

Example file err file is clean:

Program Version,EnergyPlus, Version 22.2.0-ecb51cbf82, YMD=2022.09.12 08:54,
************* Beginning Zone Sizing Calculations
************* Testing Individual Branch Integrity
************* All Branches passed integrity testing
************* Testing Individual Supply Air Path Integrity
************* All Supply Air Paths passed integrity testing
************* Testing Individual Return Air Path Integrity
************* All Return Air Paths passed integrity testing
************* No node connection errors were found.
************* Beginning Simulation
************* Simulation Error Summary *************
************* There are 1 unused schedules in input.
************* Use Output:Diagnostics,DisplayUnusedSchedules; to see them.
************* EnergyPlus Warmup Error Summary. During Warmup: 0 Warning; 0 Severe Errors.
************* EnergyPlus Sizing Error Summary. During Sizing: 0 Warning; 0 Severe Errors.
************* EnergyPlus Completed Successfully-- 0 Warning; 0 Severe Errors; Elapsed Time=00hr 00min  0.56sec

[rraustad]

PackagedTerminalHeatPump_LatentSizing_SensibleAndLatent shows diffs because of 1) the error file is clean now and 2) the schedule values (dehumidify=45% and humidify=40%) are used instead of the default 50% RH.

[Myoldmopar]

Beautiful, thanks @rraustad, merging this directly.

[Myoldmopar]

👍 makes sense.