IDF Editor added dialog explaining workaround for #9010 out of memory error

[JasonGlazer]

Pull request overview

• Fixes Out of memory when IDFEditor reads in a large IDF file #9010
• Adds a dialog box in IDF Editor that displays how to work around this out of memory error. The dialog box only shows up when the memory error occurs.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[JasonGlazer]

@jcyuan2020 could you test this again and see if the dialog box showing the workaround is displayed?

[jcyuan2020]

@JasonGlazer Sure. Also, will this involve compiling the idfeditor from source code? I may need some help with that.

[jcyuan2020]

The first test is on v9.6. The newly added message showed up as expected:

After clicking "OK", then the following message will come up:

Click "OK" again, the IDFEditor window will disappear (presumably being closed).

[JasonGlazer]

Thanks, that is how it should be working now.

[jcyuan2020]

Also, tested on v22.2 IOFreeze using an upgraded idf file, the results are the same.

[mjwitte]

@JasonGlazer I'm curious why the memory error doesn't occur when the file is opened directly from IDFEditor? With this branch, if the file is opened directly, the dialog comes up but there is no memory error. Would a better dialog be to simply suggest opening the file directly from IDF Editor?

[mjwitte]

@JasonGlazer I'm curious why the memory error doesn't occur when the file is opened directly from IDFEditor? With this branch, if the file is opened directly, the dialog comes up but there is no memory error. Would a better dialog be to simply suggest opening the file directly from IDF Editor?

Per @JasonGlazer (in an actual face-to-face conversation) opening the file directly from IDFEditor is not a reliable solution.

@Myoldmopar If you're ok with this change, it can merge.

[Myoldmopar]

No problem here, merging.