Calculate Mean Radiant Temperature (MRT) for Enclosures (not zones) #9628

mjwitte · 2022-08-29T17:30:48Z

Pull request overview

This PR fixes some of Mean Radiant Temperature (MRT) calculations are zone-based (not enclosure-based) #9377
Calculate MRT for enclosure surfaces, not zone surfaces. If there are no airwalls and no spaces in the model, then there is one enclosure per zone and nothing will change. If airwalls or spaces result in enclosures that are <> zones, then this will cause diffs.
Expect surfaces listed in ComfortViewFactorAngles to be in the same radiant enclosure as the People object(s) which use it. Issue warnings if the enclosures don't match up. Surfaces may be in different zones or spaces as long as they are in the same enclosure. If the enclosure rule is violated, a warning is issued, but the simulation will continue with the specified surfaces. Zone Name is now ignored for this (it wasn't a required field, so no IDD change is necessary). The field should be removed after release.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

amirroth · 2022-08-29T17:36:04Z

src/EnergyPlus/DataViewFactorInformation.hh

-    Array1D<DataViewFactorInformation::EnclosureViewFactorInformation> EnclRadInfo;
-    Array1D<DataViewFactorInformation::EnclosureViewFactorInformation> EnclSolInfo;
+    EPVector<DataViewFactorInformation::EnclosureViewFactorInformation> EnclRadInfo;
+    EPVector<DataViewFactorInformation::EnclosureViewFactorInformation> EnclSolInfo;


I love struct/class type names that include the word "Data" or "Information". So what you're saying is ... this struct contains information? I think that's only allowed in C++20 and we're only on C++17.

amirroth · 2022-08-29T17:37:38Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-    for (int radEnclosureNum = 1; radEnclosureNum <= state.dataViewFactor->NumOfRadiantEnclosures; ++radEnclosureNum) {
-        auto &thisEnclosure(state.dataViewFactor->EnclRadInfo(radEnclosureNum));
-        if (!state.dataHeatBal->EnclRadReCalc(radEnclosureNum)) continue;
+    for (auto &thisRadEnclosure : state.dataViewFactor->EnclRadInfo) {


mjwitte · 2022-08-31T20:24:59Z

@nealkruis @shorowit This change results in basement surface temperatures which are cooler on average. Is that what you expect?

nealkruis · 2022-08-31T20:39:23Z

That makes sense to me if the non-basement surfaces are warmer than the basement surfaces on average.

mjwitte · 2022-08-31T23:04:12Z

@Myoldmopar This is mostly ready for review. It addresses part of #9377 but not all. No diffs are expected for the base test suite. This still needs a unit test or two. Handing this off to @jcyuan2020 to add a unit test and respond to comments.

mjwitte

Highlights:

mjwitte · 2022-08-31T23:05:28Z

src/EnergyPlus/DataHeatBalance.hh

-    Array1D<Real64> EnclRadQThermalRad;  // TOTAL THERMAL RADIATION ADDED TO ZONE or Radiant Enclosure (group of zones)
-    Array1D<Real64> EnclRadThermAbsMult; // EnclRadThermAbsMult  - MULTIPLIER TO COMPUTE 'ITABSF'
-    Array1D<bool> EnclSolAbsFirstCalc;   // for error message
-    Array1D<bool> EnclRadReCalc;         // Enclosure solar or thermal radiation properties needs to be recalc due to window/shading status change


Moved to enclosure data. Which then required non-substantive changes throughout the code.

mjwitte · 2022-08-31T23:06:43Z

src/EnergyPlus/ThermalComfort.hh

-    Array1D<Real64> SurfaceAE;                       // Product of area and emissivity for each surface
-    Array1D<Real64> ZoneAESum;                       // Sum of area times emissivity for all zone surfaces


Moved to Surface struct

mjwitte · 2022-08-31T23:07:28Z

src/EnergyPlus/HeatBalanceKivaManager.cc

@@ -372,7 +372,7 @@ void KivaInstanceMap::setBoundaryConditions(EnergyPlusData &state)
                            state.dataHeatBalSurf->SurfQdotRadHVACInPerArea(floorSurface);  // HVAC

    bcs->slabConvectiveTemp = state.dataHeatBal->SurfTempEffBulkAir(floorSurface) + DataGlobalConstants::KelvinConv;
-    bcs->slabRadiantTemp = ThermalComfort::CalcSurfaceWeightedMRT(state, zoneNum, floorSurface, false) + DataGlobalConstants::KelvinConv;
+    bcs->slabRadiantTemp = ThermalComfort::CalcSurfaceWeightedMRT(state, floorSurface, false) + DataGlobalConstants::KelvinConv;


zoneNum is unnecessary. Get the enclosurenum now from the surface.

mjwitte · 2022-08-31T23:12:15Z

src/EnergyPlus/ThermalComfort.cc

-                                  "...invalid " + state.dataIPShortCut->cAlphaFieldNames(2) + "=\"" + state.dataIPShortCut->cAlphaArgs(2) + "\".");
-                ErrorsFound = true;
-            }
+            // Ignore ZoneName cAlphaArgs(2)


Modify ComfortViewFactorAngles to ignore zone name and check that all surfaces and associated People object are in the same radiant enclosure.

mjwitte · 2022-08-31T23:13:15Z

src/EnergyPlus/ThermalComfort.cc

+            for (auto const &thisRadEnclosure : state.dataViewFactor->EnclRadInfo) {
+                for (int const SurfNum2 : thisRadEnclosure.SurfacePtr) {


The heart of all of this - loop over enclosure surfaces instead of zone surfaces.

mjwitte · 2022-08-31T23:13:50Z

src/EnergyPlus/ThermalComfort.cc

+        auto &thisSurface = state.dataSurface->Surface(SurfNum);
+        auto &thisRadEnclosure = state.dataViewFactor->EnclRadInfo(thisSurface.RadEnclIndex);
+        // Recalc SurfaceEnclAESum only if needed due to window shades or EMS
+        if (thisRadEnclosure.radReCalc) {


Recalculate area*emissivity only if needed.

mjwitte · 2022-08-31T23:14:52Z

src/EnergyPlus/ThermalComfort.hh

-        Array1D<Real64> AngleFactor; // Angle factor of each surface
-        std::string Name;            // Angle factor list name
-        Array1D_string SurfaceName;  // Names of the Surfces
-        Array1D_int SurfacePtr;      // ALLOCATABLE to the names of the Surfces
-        int TotAngleFacSurfaces;     // Total number of surfaces
-        std::string ZoneName;        // Name of zone the system is serving
-        int ZonePtr;                 // Point to this zone in the Zone derived type
-
-        // Default Constructor
-        AngleFactorData() : TotAngleFacSurfaces(0), ZonePtr(0)
-        {
-        }
+        EPVector<Real64> AngleFactor;      // Angle factor of each surface


Some gratuitous Array1D --> EPVector scattered about.

mjwitte · 2022-08-31T23:15:12Z

src/EnergyPlus/ThermalComfort.hh

-        this->runningAverageCEN = 0.0;
-        this->useEpwDataCEN = false;
-        this->firstDaySet = false; // first day is set with initiate -- so do not update
+        new (this) ThermalComfortsData();


Use the latest clear_state form.

rraustad · 2022-09-13T15:16:21Z

doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex


-With this choice, the method used will be a factor per floor area of the zone. (The People per Zone Floor Area field should be filled).
+\item[People/Area] With this choice, the method used will be a factor per floor area of the zone. (The People per Zone Floor Area field should be filled).



"floor area of the zone. (The People per Zone Floor Area" Since there is more work here, I would suggest adding to the end of the first sentance "or Space" in the future here and other places like this. Also it's just "People per Floor Area" now, another clean up that could happen in a future commit.

rraustad · 2022-09-13T15:27:00Z

doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex

@@ -827,20 +802,20 @@ \subsection{Simplified ASHRAE 55 Warnings}\label{simplified-ashrae-55-warnings}
 \item
  Eliminate occupancy when conditioning equipment is off.
 \item
-  Note that the ASHRAE graph lower limit is (19.6C to 21.7C) -- heating setpoints may need to be nearer 22.2C (72F) than 21.1C (70F).
+  Note that the ASHRAE graph lower limit is (19.6$^\circ$C to 21.7$^\circ$C)---heating setpoints may need to be nearer 22.2$^\circ$C (72$^\circ$F) than 21.1$^\circ$C (70$^\circ$F).
 \item


I thought we were using \deg or something like that but this does give a good degree symbol and Google shows this is one method.

rraustad · 2022-09-13T15:40:54Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-        for (int const SurfNum : thisEnclosure.SurfacePtr) {
-            if (!Surface(SurfNum).HeatTransSurf) continue;
-            int const ConstrNum = Surface(SurfNum).Construction;
+        for (int const SurfNum : thisRadEnclosure.SurfacePtr) {


Should most of E+ for loops use int const X?

rraustad

Code changes and unit test look good.

rraustad · 2022-09-13T16:36:35Z

@mjwitte is there anything else needed for this pass?

mjwitte · 2022-09-13T16:47:40Z

@mjwitte is there anything else needed for this pass?

Not that I'm aware of. Thanks for the review.

rraustad · 2022-09-13T17:01:16Z

This change has no CI diffs and will merge later today.

mjwitte added 3 commits August 29, 2022 10:30

Move some loose enclosure arrays into EnclRad/SolInfo

96b6b5a

Move some loose enclosure arrays into EnclRad/SolInfo - unit tests

5b5b0cb

Move some loose enclosure arrays into EnclRad/SolInfo - unit tests

1b0d8d6

mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Aug 29, 2022

mjwitte added this to the EnergyPlus 22.2 milestone Aug 29, 2022

amirroth reviewed Aug 29, 2022

View reviewed changes

mjwitte added 5 commits August 29, 2022 15:43

EnclRadAlwaysReCalc back to state

9feb257

Use enclosure surfs in CalcSurfaceWeightedMRT and add radReCalc check

807253b

Merge remote-tracking branch 'remotes/origin/develop' into 9377MRT

ccbec60

Address comments and diffs

3479e29

Merge remote-tracking branch 'remotes/origin/develop' into 9377MRT

1987809

mjwitte added 2 commits August 31, 2022 17:00

ComfortViewFactorAngles surfaces in same enclosure

608a992

ComfortViewFactorAngles IO ref

199fb50

mjwitte mentioned this pull request Aug 31, 2022

MRT calculations and radiant exchange calculations are not consistent #9631

Open

3 tasks

ComfortViewFactorAngles cleanup

00bbec1

mjwitte marked this pull request as ready for review August 31, 2022 23:01

mjwitte commented Aug 31, 2022

View reviewed changes

Fix another format

3eb183d

mjwitte changed the title ~~Calculate Meant Radiant Temperature (MRT) for Enclosures (not zones)~~ Calculate Mean Radiant Temperature (MRT) for Enclosures (not zones) Sep 1, 2022

jcyuan2020 added 2 commits September 1, 2022 10:09

Some IORef documentation updates.

184d78a

Add unit test 1.

50cafc0

rraustad self-assigned this Sep 13, 2022

rraustad reviewed Sep 13, 2022

View reviewed changes

rraustad approved these changes Sep 13, 2022

View reviewed changes

rraustad merged commit 9747686 into develop Sep 13, 2022

rraustad deleted the 9377MRT branch September 13, 2022 20:35

shorowit mentioned this pull request Sep 27, 2022

Use new E+ 9.6 Space object for below-grade conditioned spaces NREL/OpenStudio-HPXML#1097

Closed

12 tasks

mjwitte mentioned this pull request Sep 26, 2023

Mean Radiant Temperature from Zone to Enclosure #10244

Merged

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Calculate Mean Radiant Temperature (MRT) for Enclosures (not zones) #9628

Calculate Mean Radiant Temperature (MRT) for Enclosures (not zones) #9628

mjwitte commented Aug 29, 2022 •

edited by rraustad

Loading

amirroth Aug 29, 2022 •

edited

Loading

amirroth Aug 29, 2022

mjwitte commented Aug 31, 2022

nealkruis commented Aug 31, 2022

mjwitte commented Aug 31, 2022 •

edited

Loading

mjwitte left a comment

mjwitte Aug 31, 2022

mjwitte Aug 31, 2022

mjwitte Aug 31, 2022

mjwitte Aug 31, 2022

mjwitte Aug 31, 2022

mjwitte Aug 31, 2022

mjwitte Aug 31, 2022

mjwitte Aug 31, 2022

rraustad Sep 13, 2022

rraustad Sep 13, 2022

rraustad Sep 13, 2022

rraustad left a comment

rraustad commented Sep 13, 2022

mjwitte commented Sep 13, 2022

rraustad commented Sep 13, 2022

		Array1D<Real64> SurfaceAE; // Product of area and emissivity for each surface
		Array1D<Real64> ZoneAESum; // Sum of area times emissivity for all zone surfaces

		for (auto const &thisRadEnclosure : state.dataViewFactor->EnclRadInfo) {
		for (int const SurfNum2 : thisRadEnclosure.SurfacePtr) {


		With this choice, the method used will be a factor per floor area of the zone. (The People per Zone Floor Area field should be filled).
		\item[People/Area] With this choice, the method used will be a factor per floor area of the zone. (The People per Zone Floor Area field should be filled).

Calculate Mean Radiant Temperature (MRT) for Enclosures (not zones) #9628

Calculate Mean Radiant Temperature (MRT) for Enclosures (not zones) #9628

Conversation

mjwitte commented Aug 29, 2022 • edited by rraustad Loading

Pull request overview

Pull Request Author

Reviewer

amirroth Aug 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Aug 31, 2022

nealkruis commented Aug 31, 2022

mjwitte commented Aug 31, 2022 • edited Loading

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad left a comment

Choose a reason for hiding this comment

rraustad commented Sep 13, 2022

mjwitte commented Sep 13, 2022

rraustad commented Sep 13, 2022

mjwitte commented Aug 29, 2022 •

edited by rraustad

Loading

amirroth Aug 29, 2022 •

edited

Loading

mjwitte commented Aug 31, 2022 •

edited

Loading