Address set sky and ground surfaces view factors for surfaces property object #9441

Nigusse · 2022-05-19T02:23:00Z

Pull request overview

Fixes Incorrect use of sky view factor variable to set ground view factor for surrounding surfaces property object #9437
Removed redundant codes from three separate sections
Refactored the code that sets the sky and ground surfaces to exterior surfaces

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

Nigusse · 2022-05-19T12:37:38Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-                    // If neither ground or sky view factor define, continue to use the original proportion.
-                    Surface(SurfNum).ViewFactorSkyIR *= 1 - SrdSurfsViewFactor;
-                    Surface(SurfNum).ViewFactorGroundIR *= 1 - SrdSurfsViewFactor;
-                }


Refactored by creating a new function InitSurfacePropertyViewFactors(state) used above. Also the new function is used to address failed unit test due to deleted redundant code as part of this fix.

Nigusse · 2022-05-19T12:38:24Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

@@ -294,56 +294,18 @@ void InitSurfaceHeatBalance(EnergyPlusData &state)

    SetSurfaceWindSpeedAt(state);
    SetSurfaceWindDirAt(state);
+    InitSurfacePropertyViewFactors(state);


New function InitSurfacePropertyViewFactors(state) replaced the deleted code below.

Nigusse · 2022-05-19T12:38:55Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+                state.dataSurface->SurfOutDryBulbTemp(SurfNum) = linkedNode.OutAirDryBulb;
+                state.dataSurface->SurfOutWetBulbTemp(SurfNum) = linkedNode.OutAirWetBulb;
+                state.dataSurface->SurfOutWindSpeed(SurfNum) = linkedNode.OutAirWindSpeed;
+                state.dataSurface->SurfOutWindDir(SurfNum) = linkedNode.OutAirWindDir;
            }


Compact and readable.

Nigusse · 2022-05-19T12:40:42Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+        }
+    }
+}
+


New function that replaced a deleted code (refactored).

Nigusse · 2022-05-19T12:45:46Z

src/EnergyPlus/WindowComplexManager.cc

+                        for (SrdSurfNum = 1; SrdSurfNum <= SrdSurfsProperty.TotSurroundingSurface; SrdSurfNum++) {
+                            SrdSurfViewFac = SrdSurfsProperty.SurroundingSurfs(SrdSurfNum).ViewFactor;
+                            SrdSurfTempAbs = GetCurrentScheduleValue(state, SrdSurfsProperty.SurroundingSurfs(SrdSurfNum).TempSchNum) +
+                                             DataGlobalConstants::KelvinConv;
                            OutSrdIR += DataGlobalConstants::StefanBoltzmann * SrdSurfViewFac * (pow_4(SrdSurfTempAbs));


No functional change; modified for readability.

Nigusse · 2022-05-19T12:46:44Z

src/EnergyPlus/WindowEquivalentLayer.cc

-                    if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor != -1) {
-                        state.dataSurface->Surface(SurfNum).ViewFactorGroundIR =
-                            state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor;
-                    }


Same here, deleted redundant code.

Nigusse · 2022-05-19T12:46:53Z

src/EnergyPlus/WindowEquivalentLayer.cc

+                    for (SrdSurfNum = 1; SrdSurfNum <= SrdSurfsProperty.TotSurroundingSurface; SrdSurfNum++) {
+                        SrdSurfViewFac = SrdSurfsProperty.SurroundingSurfs(SrdSurfNum).ViewFactor;
+                        SrdSurfTempAbs = GetCurrentScheduleValue(state, SrdSurfsProperty.SurroundingSurfs(SrdSurfNum).TempSchNum) +
+                                         DataGlobalConstants::KelvinConv;


No functional change; modified for readability.

Nigusse · 2022-05-19T12:47:15Z

src/EnergyPlus/WindowManager.cc

+                        for (SrdSurfNum = 1; SrdSurfNum <= SrdSurfsProperty.TotSurroundingSurface; SrdSurfNum++) {
+                            SrdSurfViewFac = SrdSurfsProperty.SurroundingSurfs(SrdSurfNum).ViewFactor;
+                            SrdSurfTempAbs = GetCurrentScheduleValue(state, SrdSurfsProperty.SurroundingSurfs(SrdSurfNum).TempSchNum) +
+                                             DataGlobalConstants::KelvinConv;
                            OutSrdIR += state.dataWindowManager->sigma * SrdSurfViewFac * pow_4(SrdSurfTempAbs);


No functional change; modified for readability.

Nigusse · 2022-05-19T12:47:37Z

src/EnergyPlus/WindowManager.cc

-                        }
-                        if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor != -1) {
-                            surface.ViewFactorGroundIR = state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor;
-                        }


Same here, deleted redundant code.

Nigusse · 2022-05-19T12:51:01Z

tst/EnergyPlus/unit/WindowManager.unit.cc

@@ -2836,6 +2836,8 @@ TEST_F(EnergyPlusFixture, WindowManager_SrdLWRTest)
    state->dataScheduleMgr->Schedule(1).CurrentValue = 25.0; // Srd Srfs Temp
    // Calculate temperature based on supply flow rate

+    HeatBalanceSurfaceManager::InitSurfacePropertyViewFactors(*state);
+
    WindowManager::CalcWindowHeatBalance(*state, surfNum2, state->dataHeatBalSurf->SurfHConvInt(surfNum2), inSurfTemp, outSurfTemp);


Need to reset the sky and ground surface view factors for exterior surface. This unit test failed due to deletion of the redundant code.

Nigusse · 2022-05-19T12:52:07Z

src/EnergyPlus/WindowComplexManager.cc

-                        if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor != -1) {
-                            state.dataSurface->Surface(SurfNum).ViewFactorGroundIR =
-                                state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor;
-                        }


This deleted code section is redundant because the view factors are already set at this stage. The view factors are constant; no need to reset them every time a window surface is simulated.

Nigusse · 2022-05-19T13:08:55Z

@Myoldmopar This branch is ready for review.

Nigusse · 2022-05-24T15:45:30Z

@amirroth This is the PR that addressed #9441.

Nigusse · 2022-05-25T20:53:45Z

src/EnergyPlus/DataSurfaces.hh

@@ -1323,7 +1323,7 @@ namespace DataSurfaces {
        Array1D<SurroundingSurfProperty> SurroundingSurfs;

        // Default Constructor
-        SurroundingSurfacesProperty() : SkyViewFactor(-1.0), SkyTempSchNum(0), GroundViewFactor(-1.0), GroundTempSchNum(0), TotSurroundingSurface(0)
+        SurroundingSurfacesProperty() : SkyViewFactor(0.0), SkyTempSchNum(0), GroundViewFactor(0.0), GroundTempSchNum(0), TotSurroundingSurface(0)


Changed view factor initialization to 0.0, instead of -1.0. This change also requires some logic change elsewhere.

Nigusse · 2022-05-25T20:54:44Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+    }
+    if (!state.dataHeatBalSurfMgr->InitSurfaceHeatBalancefirstTime) {
+        return;
+    }


Modified per @amirroth review comment.

Nigusse · 2022-05-25T20:56:52Z

src/EnergyPlus/SolarShading.cc

                state.dataSurface->Surface(SurfNum).ViewFactorSkyIR *= state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor;
            }
-            if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor != -1) {
+            if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor != 0) {


Sky and ground view factors are no more initialized to -1.0, so needed these logic changes as well.

I think you misunderstood my comment. Do the addition without the if. It’s faster to add 0 than it is to test if something is not 0 and only add in that case.

I did I understand your comment but there is a reason that this check is needed because it is overriding an existing value. I am actually looking a way to delete this view factor reset.

The view factors update in SolarShading.cc module above are hit prior to state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor and state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor variables are reset due to the current calling order. Thus, the calling point of the new function InitSurfacePropertyViewFactors() should move up before calling SkyDifSolarShading(), preferably in InitHeatBalance(). Quick test shows diffs will be introduced but it is justifiable, I think. I will get rid of the view factor update from SolarShading.cc and see its impact.

Nigusse · 2022-05-26T13:22:23Z

tst/EnergyPlus/unit/HeatBalanceSurfaceManager.unit.cc

@@ -2483,6 +2483,8 @@ TEST_F(EnergyPlusFixture, HeatBalanceSurfaceManager_TestSurfPropertySrdSurfLWR)
    state->dataSurface->SurfTAirRef(2) = DataSurfaces::RefAirTemp::AdjacentAirTemp;
    state->dataSurface->SurfTAirRef(3) = DataSurfaces::RefAirTemp::ZoneSupplyAirTemp;

+    InitSurfacePropertyViewFactors(*state);
+


Added view factor init function to fix an existing failed unit test.

Nigusse · 2022-05-26T13:23:38Z

tst/EnergyPlus/unit/HeatBalanceSurfaceManager.unit.cc

+    EXPECT_DOUBLE_EQ(0.2, Surface_2.ViewFactorGroundIR);
+    EXPECT_DOUBLE_EQ(0.3, Surface_3.ViewFactorSkyIR);
+    EXPECT_DOUBLE_EQ(0.3, Surface_3.ViewFactorGroundIR);
+}


This unit test demonstrates the new function InitSurfacePropertyViewFactors(*state).

Myoldmopar

This is a nice set of cleanups. Centralizing the logic to a new function and handling the view factors properly has led to a lot of deleted redundant code. Great stuff. If there is a defect file I'll need to run it to wrap up the review, but this is a great set of code changes.

Myoldmopar · 2022-05-26T15:44:14Z

CI is showing there is a build warning: unused variable ‘SrdSurfsNum’ [-Wunused-variable]

CI is also showing diffs in the EIO file for a couple surfaces where it appears the view factor has changed from zero to one. I suppose this is the intention of this fix.

I see there's not really a defect file, so I'll instead just take a deeper look at the CI change and go from there.

Nigusse · 2022-05-26T17:07:13Z

@Myoldmopar I am still looking at the code change in the solar shading module. I may have to revert the change for this section based on a new unit test.

Nigusse · 2022-05-26T17:09:52Z

The example file SurfacePropTest_SurfLWR.idf captures most of the changes made.

Nigusse · 2022-05-26T17:44:13Z

src/EnergyPlus/SolarShading.cc

-                state.dataSurface->Surface(SurfNum).ViewFactorSkyIR *= state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor;
-            }
-            if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor != -1) {
-                state.dataSurface->Surface(SurfNum).ViewFactorGroundIR *= state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor;


The deleted section does not guaranty view factors identity because it proportionally adjusts the sky and ground surfaces view factors only.

Nigusse · 2022-05-26T17:46:55Z

src/EnergyPlus/SolarShading.cc

            }
+            state.dataSurface->Surface(SurfNum).ViewFactorGroundIR = 1.0 - state.dataSurface->Surface(SurfNum).ViewFactorSkyIR - SrdSurfsViewFactor;
        }


This new code instead, if there is surrounding surfaces view factors defined, takes the updated sky view factor and backs out the ground surface view factor accounting for the surrounding surfaces view factor.

mjwitte · 2022-05-29T17:49:10Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+            // If both surface sky and ground view factor defined, overwrite with the defined value
+            Surface.ViewFactorSkyIR = SrdSurfsProperty.SkyViewFactor;
+            Surface.ViewFactorGroundIR = SrdSurfsProperty.GroundViewFactor;
+        } else if (SrdSurfsProperty.SkyViewFactor > 0.0 && SrdSurfsProperty.GroundViewFactor == 0.0) {


@Nigusse Zero is not the same as blank in the current code:
GroundViewFactor and SkyViewFactor were initialized to -1, then in GetSurfaceSrdSurfsData if the input field is blank, the value remains at -1 and that property is left at the normal value. But if the user input a zero value, then the value would be set to zero.

This isn't a great design, especially since the IDD defaults are 0.5. So I'm not sure what the best solution is here, but the changes here alter the behavior.

@mjwitte The initialization to -1 were used to preserve the default values (not to alter the values) until the GetSurfaceSrdSurfsData resets them. The proposed change in here did not alter the logic how they are reset and still captures the logic when the fields are blank, I think. Deleting the view factors check and resets codes in the three windows modules were necessary since the view factor reset refactor can be called early and also used to for unit tests otherwise, would fail due to the proposed changes. But the changes in SkyDifSolarShading is the one that is changing the behavior for two reasons.

How does the revised code distinguish between blank and an input value of 0.0?

Below are the two reasons:

First, in the existing code (Develop) the simulation hits SkyDifSolarShading function prior to the view factors reset calculation is done. Therefore, the check was necessary in the existing code (Develop) since the view factors values could be -1.

Second, I think the reset equation is incorrect, we can debate on the logic here.

The proposed code ( the branch) alters two things: (1) moves the view factors reset calculation earlier than the SkyDifSolarShading call such that it avoids the need to check for view factor is -1. (2) altered how the view factor were reset such that the view factor identity is maintained. In the existing code (Develop) , the reset equation does not guarantee the view factor identity. Note that the Surface.SkyViewFactor and Surface.ViewFactorGroundIRr are already reset at this stage and scaling them would violate the view factor identity, I think. See below:

if (state.dataSurface->SurfHasSurroundingSurfProperties(SurfNum)) { SrdSurfsNum = state.dataSurface->SurfSurroundingSurfacesNum(SurfNum); if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor != -1) { state.dataSurface->Surface(SurfNum).ViewFactorSkyIR *= state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor; } if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor != -1) { state.dataSurface->Surface(SurfNum).ViewFactorGroundIR *= state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor; } }

So, the only changes that altered the behavior are those changes in SkyDifSolarShading() function.

mjwitte · 2022-05-31T15:38:02Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-                if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor >= 0 &&
-                    state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor >= 0) {


Previously, blank values hold -1 at this point, so an input value of 0 for SkyViewFactor and/or GroundViewFactor will make one of these if/else if be true, and it would not execute the else at the end.

mjwitte · 2022-05-31T15:42:31Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-                } else if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor < 0 &&
-                           state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor >= 0) {
-                    // If only ground view factor defined, sky view factor = 1 - all other defined view factors.
-                    Surface(SurfNum).ViewFactorGroundIR = state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor;
-                    Surface(SurfNum).ViewFactorSkyIR = 1 - SrdSurfsViewFactor;


For example if SkyViewFactor was blank and GroundViewFactor was 0.0, the old logic would execute this block and the end result would be ViewFactorGroundIR = 0.0 and ViewFactorSkyIR = 1.01 - SrdSurfsViewFactor.

mjwitte · 2022-05-31T15:49:31Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+        } else {
+            // If neither ground nor sky view factor specified, continue to use the original proportion.


With the new code, if I am following correctly, the same inputs (SkyViewFactor is blank and GroundViewFactor is 0.0) will fall to this else block and the end result would be ViewFactorGroundIR and ViewFactorSkyIR proportioned.

@mjwitte I agree, the proposed logic doesn't hold always. There are two options to fix the logic: (1) add two flag variables that can be set to true if these view factor fields are blank, or (2) revert, the view factors initialization to -1. In both approaches we can keep the other code changes as is.

@mjwitte Addressed using option 1 above.

Nigusse · 2022-06-03T13:24:10Z

src/EnergyPlus/DataSurfaces.hh

+        int GroundTempSchNum;         // schedule pointer
+        int TotSurroundingSurface;    // Total number of surrounding surfaces defined for an exterior surface
+        bool IsSkyViewFactorSet;      // false if the sky view factor field is blank
+        bool IsGroundViewFactorSet; // false if the ground view factor field is blank


Added IsSkyViewFactorSet and IsGroundViewFactorSet member variables for checking blank view factor fields. These variables will be reset to true once the actual view factor values are determined in InitSurfacePropertyViewFactors() function. The unit tests were also modified to check for these flag variables.

Nigusse · 2022-06-03T13:27:01Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+            SrdSurfsProperty.SkyViewFactor = Surface.ViewFactorSkyIR;
+            SrdSurfsProperty.GroundViewFactor = Surface.ViewFactorGroundIR;
+            SrdSurfsProperty.IsSkyViewFactorSet = true;
+            SrdSurfsProperty.IsGroundViewFactorSet = true;


The IsSkyViewFactorSet and IsGroundViewFactorSet variables are reset to true once the actual view factor values are updated as shown above.

Nigusse · 2022-06-03T13:28:41Z

src/EnergyPlus/SurfaceGeometry.cc

@@ -8179,6 +8179,7 @@ namespace SurfaceGeometry {
                // N1: sky view factor
                if (!state.dataIPShortCut->lNumericFieldBlanks(1)) {
                    state.dataSurface->SurroundingSurfsProperty(Loop).SkyViewFactor = state.dataIPShortCut->rNumericArgs(1);
+                    state.dataSurface->SurroundingSurfsProperty(Loop).IsSkyViewFactorSet = true;


The IsSkyViewFactorSet variable is set to false if the sky view factor field is blank.

Nigusse · 2022-06-03T13:28:51Z

src/EnergyPlus/SurfaceGeometry.cc

@@ -8189,6 +8190,7 @@ namespace SurfaceGeometry {
                // N2: ground view factor
                if (!state.dataIPShortCut->lNumericFieldBlanks(2)) {
                    state.dataSurface->SurroundingSurfsProperty(Loop).GroundViewFactor = state.dataIPShortCut->rNumericArgs(2);
+                    state.dataSurface->SurroundingSurfsProperty(Loop).IsGroundViewFactorSet = true;


Same as above.

Myoldmopar · 2022-06-08T20:28:02Z

ERR diff is just the warning removal, nice. EIO diffs look to be just the expected change plus some small diffs on warmup convergence. This is all just contained in the one example file, no change to other files. I'm OK with these changes. Anything left to do here @Nigusse @mjwitte ?

Nigusse · 2022-06-08T20:32:46Z

@Myoldmopar That is all from me if @mjwitte is satisfied with final changes I made.

…Issue9437

mjwitte

@Nigusse @Myoldmopar The changes look good to me. I merged in develop for one more round of CI testing.

Myoldmopar · 2022-06-13T17:57:11Z

There's an extra diff popping up here with the merge from develop. Is that somehow expected with the merge from develop? It looks like #9457 did have a couple files with similar diffs, although Decent CI cleaned up those results, and I'm not inclined to go looking through the results history unless it's needed. And this branch is already 38 commits behind develop, so I believe this is simply due to that PR.

I will do a quick build/regression run locally with very latest develop pulled in.

Myoldmopar · 2022-06-13T18:50:15Z

Built locally with the branch as-is and reproduced the extra diffs. Then pulled develop in and reran regressions, back to where we were before. This is good to go. Thanks @Nigusse and @mjwitte.

Nigusse added 8 commits May 18, 2022 11:10

Removed redundant code sections

2fb20f6

Modified code cleanup

79b579d

Refactor Surrounding Surfaces Prop View Factors Set

6d96464

Fixed Failed Unit Test

215f4ab

Code Cleanup

1797861

Renamed Init Surface Property View Factors

75963b2

Added Unit Test

22bad71

Merged Develop into Branch 182223803_Issue9437

cabebbe

Nigusse added the Defect Includes code to repair a defect in EnergyPlus label May 19, 2022

Nigusse commented May 19, 2022

View reviewed changes

src/EnergyPlus/HeatBalanceSurfaceManager.cc

}

}

}

Copy link

Contributor Author

Nigusse May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New function that replaced a deleted code (refactored).

Nigusse commented May 19, 2022

View reviewed changes

Nigusse added 2 commits May 24, 2022 10:19

Merge branch 'develop' into 182223803_Issue9437

285d124

Changed ViewFactor Init to 0 from -1

24da540

Applied Clang Format

fa22872

Nigusse commented May 25, 2022

View reviewed changes

Nigusse added 2 commits May 25, 2022 17:11

Merge branch 'develop' into 182223803_Issue9437

ab192b1

Moved up InitSurfacePropertyViewFactors() calling order

8f3ed46

Nigusse commented May 26, 2022

View reviewed changes

Myoldmopar approved these changes May 26, 2022

View reviewed changes

Added one more unit test

38f5135

Nigusse added 3 commits May 26, 2022 13:31

View factors update based on solar shading

67ff7d8

Merge branch 'develop' into 182223803_Issue9437

5a58604

Applied Clang Format

2fb42bb

Nigusse commented May 26, 2022

View reviewed changes

mjwitte reviewed May 29, 2022

View reviewed changes

mjwitte reviewed May 31, 2022

View reviewed changes

Nigusse added 3 commits May 31, 2022 14:03

Fix Surrounding Surfs GetInput and unit tests

3ba020f

Renamed Vars, updated view factor reset flags and unit tests

b5dfefd

Fixed Clang Format

cc27800

Nigusse commented Jun 3, 2022

View reviewed changes

Deleted incorrect surface name to remove warning error message

a68cff5

Merge remote-tracking branch 'remotes/origin/develop' into 182223803_…

79ce196

…Issue9437

mjwitte approved these changes Jun 10, 2022

View reviewed changes

Myoldmopar merged commit 0870fe2 into develop Jun 13, 2022

Myoldmopar deleted the 182223803_Issue9437 branch June 13, 2022 18:50

		if (state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).SkyViewFactor >= 0 &&
		state.dataSurface->SurroundingSurfsProperty(SrdSurfsNum).GroundViewFactor >= 0) {

		} else {
		// If neither ground nor sky view factor specified, continue to use the original proportion.

Address set sky and ground surfaces view factors for surfaces property object #9441

Address set sky and ground surfaces view factors for surfaces property object #9441

Conversation

Nigusse commented May 19, 2022 • edited Loading

Pull request overview

Pull Request Author

Reviewer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nigusse commented May 19, 2022

Nigusse commented May 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nigusse May 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar left a comment

Choose a reason for hiding this comment

Myoldmopar commented May 26, 2022

Nigusse commented May 26, 2022

Nigusse commented May 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nigusse May 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nigusse May 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar commented Jun 8, 2022

Nigusse commented Jun 8, 2022

mjwitte left a comment

Choose a reason for hiding this comment

Myoldmopar commented Jun 13, 2022

Myoldmopar commented Jun 13, 2022

Nigusse commented May 19, 2022 •

edited

Loading

Nigusse May 26, 2022 •

edited

Loading

Nigusse May 31, 2022 •

edited

Loading

Nigusse May 31, 2022 •

edited

Loading