CondFD Conductivity/Specific Heat Actuator Bug #9221

mitchute · 2022-01-02T20:11:49Z

Pull request overview

Fixes a bug in the CondFD conductivity and specific heat actuators where the k and cp values were not being updated in all places.
Minor doc updates.

… not being updated

mitchute

I boneheadedly missed that the heat flux with/without EMS actuated k and cp values were not matching before 😒 . This is due to missing updating k and cp in two places with the EMS overrides. The heat flux values now match.

The plot below shows the direct and ems heat flux values for one surface. "Direct" values come from setting k and cp directly in the IDF, and the "ems" values come from setting k and cp to different values in the IDF and then modifying them back to the original values using EMS.

mitchute · 2022-01-02T20:12:17Z

doc/ems-application-guide/src/ems-actuators/thermal-envelope.tex

@@ -110,7 +110,7 @@ \subsection{Conduction Finite Difference}\label{conduction-finite-difference}
 Several actuators, called ``CondFD Surface Material Layer,'' are available with actuated component control types for models that use the Conduction Finite Difference solution for conduction through surfaces. These are described below.

 \begin{itemize}
-    \item ``Thermal Conductivity''. Has units of [W/m-K]. Controls the thermal conductivity of the specified material layer within a given surface. Actuator is named from the surface name and material layer name combined with a colon ":". E.g. "SURFNAME:MATERIALLAYERNAME"
+    \item ``Thermal Conductivity''. Has units of [W/m-K]. Controls the thermal conductivity of the specified material layer within a given surface. Actuator is named from the surface name and material layer name combined with a colon ``:''. E.g. ``SURFNAME:MATERIALLAYERNAME''


Updated to use correct quotation marks.

mitchute · 2022-01-02T20:12:46Z

doc/input-output-reference/src/overview/group-surface-construction-elements.tex

+\paragraph{CondFD EMS Heat Source Power After Layer}
+
+This output is the heat power added after material layer N from the EMS heat flux actuator (Component type: ``CondFD Surface Material Layer''; Control type: ``Heat Flux''). Only valid for the CondFD solution algorithm.
+
+\paragraph{CondFD EMS Heat Source Energy After Layer}
+
+This output is the heat energy added after material layer N from the EMS heat flux actuator (Component type: ``CondFD Surface Material Layer''; Control type: ``Heat Flux''). Energy is aggregated on the electricity meter and is only valid for the CondFD solution algorithm.
+


New EMS-specific output vars are now referenced here.

Good addition.

mitchute · 2022-01-02T20:13:48Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

+            ktA1 = kt;
+            ktA2 = kt;


Bugfix: updating conductivity here with EMS override value.

Yep, good call.

mitchute · 2022-01-02T20:14:20Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

+                    // EMS Conductivity 2 Override
+                    if (condActuator2.isActuated) {
+                        kt2 = condActuator1.actuatedValue;
+                    }
+
+                    // EMS Specific Heat 2 Override
+                    if (specHeatActuator2.isActuated) {
+                        Cp2 = specHeatActuator1.actuatedValue;
+                    }
+
+                    // Update EMS internal variables
+                    surfFD.condNodeReport(i) = kt1;
+                    surfFD.specHeatNodeReport(i) = Cp1;
+                    surfFD.condNodeReport(i + 1) = kt2;
+                    surfFD.specHeatNodeReport(i + 1) = Cp2;
+


Bugfix: updating k and cp here with EMS override values.

mitchute · 2022-01-02T20:14:38Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

-                    // EMS Conductivity 2 Override
-                    if (condActuator2.isActuated) {
-                        kt2 = condActuator2.actuatedValue;
-                    }
-


Unused code, removing.

mitchute · 2022-01-02T20:14:53Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

-                    // EMS Specific Heat 2 Override
-                    if (specHeatActuator2.isActuated) {
-                        Cp2 = specHeatActuator2.actuatedValue;
-                    }


Unused code, removing.

mitchute · 2022-01-02T20:15:26Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).condNodeReport(i) = kt1;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).specHeatNodeReport(i) = Cp1;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).condNodeReport(i + 1) = kt2;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).specHeatNodeReport(i + 1) = Cp2;
+                    surfFD.condNodeReport(i) = kt1;
+                    surfFD.specHeatNodeReport(i) = Cp1;
+                    surfFD.condNodeReport(i + 1) = kt2;
+                    surfFD.specHeatNodeReport(i + 1) = Cp2;


Renaming with already-existing local reference.

mitchute · 2022-01-02T20:15:32Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).condNodeReport(i) = kt1;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).specHeatNodeReport(i) = Cp1;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).condNodeReport(i + 1) = kt2;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).specHeatNodeReport(i + 1) = Cp2;
+                    surfFD.condNodeReport(i) = kt1;
+                    surfFD.specHeatNodeReport(i) = Cp1;
+                    surfFD.condNodeReport(i + 1) = kt2;
+                    surfFD.specHeatNodeReport(i + 1) = Cp2;


Renaming with already-existing local reference.

Myoldmopar · 2022-01-04T15:15:37Z

doc/ems-application-guide/src/ems-actuators/thermal-envelope.tex

@@ -110,7 +110,7 @@ \subsection{Conduction Finite Difference}\label{conduction-finite-difference}
 Several actuators, called ``CondFD Surface Material Layer,'' are available with actuated component control types for models that use the Conduction Finite Difference solution for conduction through surfaces. These are described below.

 \begin{itemize}
-    \item ``Thermal Conductivity''. Has units of [W/m-K]. Controls the thermal conductivity of the specified material layer within a given surface. Actuator is named from the surface name and material layer name combined with a colon ":". E.g. "SURFNAME:MATERIALLAYERNAME"
+    \item ``Thermal Conductivity''. Has units of [W/m-K]. Controls the thermal conductivity of the specified material layer within a given surface. Actuator is named from the surface name and material layer name combined with a colon ``:''. E.g. ``SURFNAME:MATERIALLAYERNAME''


Myoldmopar · 2022-01-04T15:15:43Z

doc/input-output-reference/src/overview/group-surface-construction-elements.tex

+\paragraph{CondFD EMS Heat Source Power After Layer}
+
+This output is the heat power added after material layer N from the EMS heat flux actuator (Component type: ``CondFD Surface Material Layer''; Control type: ``Heat Flux''). Only valid for the CondFD solution algorithm.
+
+\paragraph{CondFD EMS Heat Source Energy After Layer}
+
+This output is the heat energy added after material layer N from the EMS heat flux actuator (Component type: ``CondFD Surface Material Layer''; Control type: ``Heat Flux''). Energy is aggregated on the electricity meter and is only valid for the CondFD solution algorithm.
+


Good addition.

Myoldmopar · 2022-01-04T15:15:50Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

+            ktA1 = kt;
+            ktA2 = kt;


Yep, good call.

Myoldmopar · 2022-01-04T15:15:59Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

-                    // EMS Conductivity 2 Override
-                    if (condActuator2.isActuated) {
-                        kt2 = condActuator2.actuatedValue;
-                    }
-


Myoldmopar · 2022-01-04T15:16:06Z

src/EnergyPlus/HeatBalFiniteDiffManager.cc

-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).condNodeReport(i) = kt1;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).specHeatNodeReport(i) = Cp1;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).condNodeReport(i + 1) = kt2;
-                    state.dataHeatBalFiniteDiffMgr->SurfaceFD(Surf).specHeatNodeReport(i + 1) = Cp2;
+                    surfFD.condNodeReport(i) = kt1;
+                    surfFD.specHeatNodeReport(i) = Cp1;
+                    surfFD.condNodeReport(i + 1) = kt2;
+                    surfFD.specHeatNodeReport(i + 1) = Cp2;


Myoldmopar · 2022-01-04T15:17:06Z

Great fix here, the change makes sense, and some extra cleanup along the way. CI is happy with it except the license year, which is fixed separately. Not wasting more cycles just for that. Merging this in, thanks @mitchute !

CondFD Conductivity/Specific Heat Actuator Bug

mitchute added 3 commits December 29, 2021 13:57

fix bug where ems-actuated condfd conductivity and specific heat were…

8a3bb8f

… not being updated

Merge branch 'develop' into condfd-actuator-bug

42b1118

doc updates

38e1815

mitchute added the Defect Includes code to repair a defect in EnergyPlus label Jan 2, 2022

mitchute self-assigned this Jan 2, 2022

mitchute commented Jan 2, 2022

View reviewed changes

Myoldmopar approved these changes Jan 4, 2022

View reviewed changes

Myoldmopar merged commit 1a9288c into develop Jan 4, 2022

Myoldmopar deleted the condfd-actuator-bug branch January 4, 2022 15:17

yujiex pushed a commit that referenced this pull request Jan 27, 2022

Merge pull request #9221 from NREL/condfd-actuator-bug

a359267

CondFD Conductivity/Specific Heat Actuator Bug

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CondFD Conductivity/Specific Heat Actuator Bug #9221

CondFD Conductivity/Specific Heat Actuator Bug #9221

mitchute commented Jan 2, 2022

mitchute left a comment

mitchute Jan 2, 2022

Myoldmopar Jan 4, 2022

mitchute Jan 2, 2022

Myoldmopar Jan 4, 2022

mitchute Jan 2, 2022

Myoldmopar Jan 4, 2022

mitchute Jan 2, 2022

mitchute Jan 2, 2022

Myoldmopar Jan 4, 2022

mitchute Jan 2, 2022

mitchute Jan 2, 2022

Myoldmopar Jan 4, 2022

mitchute Jan 2, 2022

Myoldmopar Jan 4, 2022

Myoldmopar Jan 4, 2022

Myoldmopar Jan 4, 2022

Myoldmopar Jan 4, 2022

Myoldmopar Jan 4, 2022

Myoldmopar commented Jan 4, 2022

CondFD Conductivity/Specific Heat Actuator Bug #9221

CondFD Conductivity/Specific Heat Actuator Bug #9221

Conversation

mitchute commented Jan 2, 2022

Pull request overview

mitchute left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar commented Jan 4, 2022