Space Followup Release #9142
Merged
Space Followup Release #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Myoldmopar
commented
Oct 18, 2021
| @@ -3,7 +3,7 @@ results_path : _posts | |||
| results_base_url : https://nrel.github.io/EnergyPlusBuildResults | |||
| regression_repository : NREL/EnergyPlusRegressionTool | |||
| regression_branch : master # this is the branch of NREL/EnergyPlusRegressionTool to use | |||
| regression_baseline_default : develop # this is the branch to use as the baseline for regressions | |||
| regression_baseline_default : SpaceReleaseBranchBaseline # this is the branch to use as the baseline for regressions | |||
There was a problem hiding this comment.
This change just ensures that regressions will be compared the baseline branch instead of develop, which has moved since release. This is an irrelevant change.
| \item | ||
| There is no full heat balance at the Enclosure level. Each Enclosure only balances the radiant/solar flux on each Surface. These fluxes then become part of the Surface inside heat balance. | ||
| \end{itemize} | ||
| \end{description} |
There was a problem hiding this comment.
This is nice additional detail.
| @@ -243,7 +243,7 @@ \subsubsection{Inputs}\label{inputs-025} | |||
| \begin{figure}[hbtp] % fig 48 | |||
| \centering | |||
| \includegraphics[width=0.9\textwidth, height=0.9\textheight, keepaspectratio=true]{media/image083.png} | |||
| \caption{Graphical representation fo the dynamic predictive clothing insulation model \protect \label{fig:graphical-representation-fo-the-dynamic}} | |||
| \caption{Graphical representation of the dynamic predictive clothing insulation model \protect \label{fig:graphical-representation-of-the-dynamic}} | |||
|
|
||
| The name of the SpaceList object. Must be unique across SpaceLists and Spaces. | ||
| The name of the SpaceList object. This name must be unique across Zone, Space, ZoneList, and SpaceList names. |
There was a problem hiding this comment.
Additional detail is helpful.
| @@ -9261,10 +9261,13 @@ Space, | |||
| \min-fields 3 | |||
| \extensible:1 | |||
| A1, \field Name | |||
| \note Name of the Space. | |||
| \note This name must be unique across Zone, Space, ZoneList, and SpaceList names. | |||
There was a problem hiding this comment.
OK, additional notes don't affect anything.
| cCurrentModuleObject + "=\"" + state.dataIPShortCut->cAlphaArgs(1) + "\", invalid " + | ||
| state.dataIPShortCut->cAlphaFieldNames(2) + "=\"" + state.dataIPShortCut->cAlphaArgs(2) + "\"."); | ||
| ErrorsFound = true; | ||
| int spaceNum = UtilityRoutines::FindItemInList(state.dataIPShortCut->cAlphaArgs(2), state.dataHeatBal->space); |
There was a problem hiding this comment.
OK, so conditionally set the zone num and/or emit a severe error.
| Array1D_bool const &lAlphaBlanks, | ||
| Array1D_string const &cAlphaFields, | ||
| [[maybe_unused]] Array1D_string const &cNumericFields, // Unused | ||
| bool &ErrorsFound // If errors found in input | ||
| bool &ErrorsFound // If errors found in input |
There was a problem hiding this comment.
I'll take less arguments!
| @@ -7039,7 +7039,9 @@ namespace SurfaceGeometry { | |||
| if (Item1 == 0 && state.dataHeatBal->NumOfZoneLists > 0) | |||
| ZLItem = UtilityRoutines::FindItemInList(state.dataIPShortCut->cAlphaArgs(3), state.dataHeatBal->ZoneList); | |||
| if (Item1 > 0) { | |||
| ++NumIntMassSurfaces; | |||
| if (state.dataIPShortCut->lAlphaFieldBlanks(4)) { | |||
There was a problem hiding this comment.
Only increment the number of surfaces if the field is blank. I'm not sure I get why, I'll ask separately.
| @@ -1322,6 +1322,37 @@ void SetUpZoneSizingArrays(EnergyPlusData &state) | |||
| state.dataSize->CalcFinalZoneSizing(CtrlZoneNum).MinOA); | |||
| } | |||
| } | |||
|
|
|||
| // Populate DesignSpecification:OutdoorAir:SpaceList spaces | |||
| @@ -52,7 +52,14 @@ | |||
|
|
|||
| // EnergyPlus Headers | |||
| #include <EnergyPlus/Data/EnergyPlusData.hh> | |||
| #include <EnergyPlus/DataHeatBalance.hh> | |||
There was a problem hiding this comment.
I'm not going to be reviewing any unit test code here for today.
|
Mac is happy here. For expedience I'm going to go ahead and merge this and kick off an RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request from the space branch into the v9.6.0 space baseline branch. This PR is purely for creating a bug fix release package.
See #9132 for the changes included here, though it may differ slightly. That particular PR will bring the changes into develop, which is different from this PR.