Fix zonehvac baseboardradiantconvective, low temperature radiant tube length, and wall:detailed vertice transitions

[jcyuan2020]

Pull request overview

• Fixes ZONEHVAC:BASEBOARD:RADIANTCONVECTIVE:WATER object transition issue from v9.4 to v9.5 (and v9.6) #9131
• ZONEHVAC:BASEBOARD:RADIANTCONVECTIVE:STEAM might also have similar problem in transition. The same fix was also applied to that object transition;
• For tube length missing when transitioning the ZoneHVAC:LowTemperatureRadiant:ConstantFlow object, added the fix suggested in Hydronic Tubing Length field in constant flow radiant objects became empty after transition from v9.4 to v9.5 #9171;
• For problematic vertices field counting when transitioning the Wall:Detailed etc objects, added the fix suggested in PR #8997 breaks transitions for Wall:Detailed, etc for version < 9.6 #9172.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

@jcyuan2020 is this ready for review?

[jcyuan2020]

@Myoldmopar Yes.

[Myoldmopar]

@jcyuan2020 can you pull develop back into this branch again? The clang-format errors should go away and hopefully CI will be all clean.

[Myoldmopar]

This looks really happy to CI. Code changes seem reasonable. I'll run a couple transition tests locally and try to get this in shortly.

[Myoldmopar]

Everything built fine, and I spot checked the transition with the defect files up from older versions. It seems OK with proper values in the new version. Merging this in, thanks @jcyuan2020!

[jcyuan2020]

Thanks! @Myoldmopar