Allow Coil:WaterHeating:Desuperheater to use Coil:Cooling:DX #9051

mitchute · 2021-09-09T01:54:54Z

Pull request overview

Adds support for Coil:WaterHeating:Desuperheater to use Coil:Cooling:DX

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…:Cooling:DX

…kDesuperheater

…ater desuperheater, still with results diffs

…kDesuperheater

rraustad · 2021-09-09T02:08:26Z

src/EnergyPlus/HeatingCoils.cc

+                // get RTF and NominalCapacity from Coil:CoolingDX
+                {
+                    auto &thisCoolingCoil = state.dataCoilCooingDX->coilCoolingDXs[SourceID];
+                    HeatingCoil(CoilNum).RTF = thisCoolingCoil.runTimeFraction;


I see this is how is has been done in the past, but this should be PLR since PLR relates to runtime and RTF relates to power. This is a follow up issue.

Since this->reclaimHeat.AvailCapacity = this->totalCoolingEnergyRate + this->elecCoolingPower, which is air-side energy (PLR) + electricity (RTF), there is a bit of a problem with the portion of the time step each of these represent. Again, for another time.

Now I think RTF is correct in this context.

mitchute

Ready for review.

mitchute · 2021-09-09T01:56:03Z

src/EnergyPlus/HeatingCoils.cc

+            } else if (UtilityRoutines::SameString(Alphas(5), "Coil:Cooling:DX")) {
+                HeatingCoil(CoilNum).ReclaimHeatingSource = HeatObjTypes::COIL_COOLING_DX_NEW;
+                HeatingCoil(CoilNum).ReclaimHeatingSourceIndexNum = CoilCoolingDX::factory(state, Alphas(6));
+                if (HeatingCoil(CoilNum).ReclaimHeatingSourceIndexNum < 0) {
+                    ShowSevereError(
+                        state,
+                        format(
+                            "{}={}, could not find desuperheater coil {}={}", CurrentModuleObject, HeatingCoil(CoilNum).Name, Alphas(5), Alphas(6)));
+                    state.dataHeatingCoils->InputErrorsFound = true;
+                }
+                DataHeatBalance::HeatReclaimDataBase &HeatReclaim =
+                    state.dataCoilCooingDX->coilCoolingDXs[HeatingCoil(CoilNum).ReclaimHeatingSourceIndexNum].reclaimHeat;
+                if (!allocated(HeatReclaim.HVACDesuperheaterReclaimedHeat)) {
+                    HeatReclaim.HVACDesuperheaterReclaimedHeat.allocate(state.dataHeatingCoils->NumDesuperheaterCoil);
+                    for (auto &num : HeatReclaim.HVACDesuperheaterReclaimedHeat)
+                        num = 0.0;
+                }
+                HeatReclaim.ReclaimEfficiencyTotal += HeatingCoil(CoilNum).Efficiency;
+                if (HeatReclaim.ReclaimEfficiencyTotal > 0.3) {
+                    ShowSevereError(state,
+                                    cAllCoilTypes(HeatingCoil(CoilNum).HCoilType_Num) + ", \"" + HeatingCoil(CoilNum).Name +
+                                        "\" sum of heat reclaim recovery efficiencies from the same source coil: \"" +
+                                        HeatingCoil(CoilNum).ReclaimHeatingCoilName + "\" cannot be over 0.3");
+                }
+                state.dataHeatingCoils->ValidSourceType(CoilNum) = true;


New get input support for the new coil in Coil:WaterHeating:DesuperHeater. This is an upstream contribution from your branch @Myoldmopar.

This looks correct.

mitchute · 2021-09-09T01:57:07Z

src/EnergyPlus/HeatingCoils.cc

+            } else if (HeatingCoil(CoilNum).ReclaimHeatingSource == HeatObjTypes::COIL_COOLING_DX_NEW) {
+                DataHeatBalance::HeatReclaimDataBase &HeatReclaim =
+                    state.dataCoilCooingDX->coilCoolingDXs[HeatingCoil(CoilNum).ReclaimHeatingSourceIndexNum].reclaimHeat;
+                if (!allocated(HeatReclaim.HVACDesuperheaterReclaimedHeat)) {
+                    HeatReclaim.HVACDesuperheaterReclaimedHeat.allocate(state.dataHeatingCoils->NumDesuperheaterCoil);
+                    for (auto &num : HeatReclaim.HVACDesuperheaterReclaimedHeat)
+                        num = 0.0;
+                    HeatReclaim.ReclaimEfficiencyTotal += HeatingCoil(CoilNum).Efficiency;
+                    if (HeatReclaim.ReclaimEfficiencyTotal > 0.3) {
+                        ShowSevereError(state,
+                                        cAllCoilTypes(HeatingCoil(CoilNum).HCoilType_Num) + ", \"" + HeatingCoil(CoilNum).Name +
+                                            "\" sum of heat reclaim recovery efficiencies from the same source coil: \"" +
+                                            HeatingCoil(CoilNum).ReclaimHeatingCoilName + "\" cannot be over 0.3");
+                    }
+                }
+                state.dataHeatingCoils->ValidSourceType(CoilNum) = true;


Additional upstream contribution from @Myoldmopar

This also looks correct. I see that HVACDesuperheaterReclaimedHeat is allocated to the total number of desuperheater coils even if this source object only has 1 desuperheater coil attached. Not at all sure if that is necessary or how this array is accessed but just noting it here.

mitchute · 2021-09-09T02:02:52Z

src/EnergyPlus/WaterThermalTanks.cc

+        auto &DesupHtr = state.dataWaterThermalTanks->WaterHeaterDesuperheater(DesuperheaterNum);
+
+        DesupHtr.Name = state.dataIPShortCut->cAlphaArgs(1);
+        DesupHtr.Type = state.dataIPShortCut->cCurrentModuleObject;


New local reference to state.dataWaterThermalTanks->WaterHeaterDesuperheater(DesuperheaterNum) throughout for readability.

mitchute · 2021-09-09T02:05:58Z

src/EnergyPlus/WaterThermalTanks.cc

+                                        DesupHtr.HeatingSourceName + "\" cannot be over 0.3");
+                    ErrorsFound = true;
+                }
+            }
+        } else if (UtilityRoutines::SameString(heatSourceObjType, "Coil:Cooling:DX")) {
+            DesupHtr.ReclaimHeatingSource = CoilObjEnum::CoilCoolingDX;
+            DesupHtr.ReclaimHeatingSourceIndexNum = CoilCoolingDX::factory(state, state.dataIPShortCut->cAlphaArgs(10));
+            if (DesupHtr.ReclaimHeatingSourceIndexNum < 0) {
+                ShowSevereError(state,
+                                format("{}={}, could not find desuperheater coil {}={}",
+                                       state.dataIPShortCut->cCurrentModuleObject,
+                                       DesupHtr.Name,
+                                       state.dataIPShortCut->cAlphaArgs(9),
+                                       state.dataIPShortCut->cAlphaArgs(10)));
+                ErrorsFound = true;
+            } else {
+                DataHeatBalance::HeatReclaimDataBase &HeatReclaim =
+                    state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat;
+                if (!allocated(HeatReclaim.WaterHeatingDesuperheaterReclaimedHeat)) {
+                    HeatReclaim.WaterHeatingDesuperheaterReclaimedHeat.allocate(state.dataWaterThermalTanks->numWaterHeaterDesuperheater);
+                    for (auto &num : HeatReclaim.WaterHeatingDesuperheaterReclaimedHeat)
+                        num = 0.0;
+                }
+                DesupHtr.ValidSourceType = true;
+                HeatReclaim.ReclaimEfficiencyTotal += DesupHtr.HeatReclaimRecoveryEff;
+                if (HeatReclaim.ReclaimEfficiencyTotal > 0.3) {
+                    ShowSevereError(state,
+                                    state.dataIPShortCut->cCurrentModuleObject + ", \"" + DesupHtr.Name +
+                                        "\" sum of heat reclaim recovery efficiencies from the same source coil: \"" + DesupHtr.HeatingSourceName +


Get input for new coil support in the water heater desuperheater.

Also looks correct.

mitchute · 2021-09-09T02:07:05Z

src/EnergyPlus/WaterThermalTanks.cc

+        } else if (DesupHtr.ReclaimHeatingSource == CoilObjEnum::CoilCoolingDX) {
+            AverageWasteHeat = state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.AvailCapacity -
+                               state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.HVACDesuperheaterReclaimedHeatTotal;
+            DesupHtr.DXSysPLR = state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].partLoadRatioReport; // check this


Extending IF/ELSE ladder to support new coil object.

mitchute · 2021-09-09T02:07:40Z

src/EnergyPlus/WaterThermalTanks.cc

+        } else if (DesupHtr.ReclaimHeatingSource == CoilObjEnum::CoilCoolingDX) {
+            state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.WaterHeatingDesuperheaterReclaimedHeat(DesuperheaterNum) = DesupHtr.HeaterRate;
+            state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.WaterHeatingDesuperheaterReclaimedHeatTotal = 0.0;
+            for (auto &num :state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.WaterHeatingDesuperheaterReclaimedHeat)
+                state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.WaterHeatingDesuperheaterReclaimedHeatTotal += num;


Another IF/ELSE case to handle switching on the new coil.

mitchute · 2021-09-09T02:09:25Z

testfiles/CoilWaterDesuperheatingUnitary.idf

@@ -0,0 +1,1639 @@
+!-Generator IDFEditor 1.34


This file takes the original CoileWaterDesuperheating file and converts it to use the unitary system with a single-speed coil. We may not want to keep this extra file around, but this is the baseline I've been comparing against.

mitchute · 2021-09-09T02:10:49Z

testfiles/CoilWaterDesuperheatingUnitaryCoilDX.idf

@@ -0,0 +1,1690 @@
+!-Generator IDFEditor 1.34


This file converts CoilWaterDesuperheatingUnitary from using the old single-speed coil to using the new Coil:Cooling:DX coil. This is what I've been comparing against the baseline.

rraustad · 2021-09-09T03:01:30Z

src/EnergyPlus/WaterThermalTanks.cc

+        } else if (DesupHtr.ReclaimHeatingSource == CoilObjEnum::CoilCoolingDX) {
+            AverageWasteHeat =
+                state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.AvailCapacity -
+                state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.HVACDesuperheaterReclaimedHeatTotal;


This equation keeps confusing me. The *Total is the sum of all reclaimed heat so far? and AvailableCapacity is the max available? and the AverageWasteHeat is the difference. Just hard to wrap your head around this without seeing where HVACDesuperheaterReclaimedHeatTotal is set, or accumulated, or decremented, etc. in code. I just don't see that. But it's the same as everywhere else so this is great.

for (auto &num : state.dataHeatBal->HeatReclaimDXCoil(SourceID).HVACDesuperheaterReclaimedHeat) state.dataHeatBal->HeatReclaimDXCoil(SourceID).HVACDesuperheaterReclaimedHeatTotal += num;

So I left a line out. Zero out the var and then sum it.

state.dataHeatBal->HeatReclaimDXCoil(SourceID).HVACDesuperheaterReclaimedHeatTotal = 0.0; for (auto &num : state.dataHeatBal->HeatReclaimDXCoil(SourceID).HVACDesuperheaterReclaimedHeat) state.dataHeatBal->HeatReclaimDXCoil(SourceID).HVACDesuperheaterReclaimedHeatTotal += num;

The only thing that worries me here is timing of when this happens versus when HVACDesuperheaterReclaimedHeat is set. Good for now, I guess.

rraustad · 2021-09-09T03:08:05Z

src/EnergyPlus/WaterThermalTanks.cc

+            AverageWasteHeat =
+                state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.AvailCapacity -
+                state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].reclaimHeat.HVACDesuperheaterReclaimedHeatTotal;
+            DesupHtr.DXSysPLR = state.dataCoilCooingDX->coilCoolingDXs[DesupHtr.ReclaimHeatingSourceIndexNum].partLoadRatioReport;


OK, so this desuperheater tracks the PLR of the source. But what if this desuperheater is used in a location that has a PLR different from the source? Again, this is what is done everywhere else, I am just ensuring lack of sleep.

nrel-bot-3 · 2022-01-22T00:22:01Z