Update VRF min/max outdoor unit inlet temp field description #8691

rraustad · 2021-04-02T04:17:27Z

Pull request overview

Fixes Water-cooled VRF heating mode operation #8687
User suggestion to clarify min/max operating limit field description

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

rraustad · 2021-04-02T04:20:29Z

doc/input-output-reference/src/overview/group-variable-refrigerant-flow-equipment.tex

@@ -74,13 +74,13 @@ \subsubsection{Inputs}\label{inputs-051}

 This numeric field defines the cooling coefficient of performance at rated conditions. The cooling coefficient of performance includes compressor power and condenser fan power. This COP value does not account for impacts due to the supply air fan. The nominal heat pump cooling COP must be greater than 0. If this field is left blank, a default coefficient of performance of 3.3 is assumed.



A user was confused on the use and interpretation of the next few input fields. A water-cooled VRF will not use the outdoor air temp to determine operation. Generalize the field name and describe in text.

Both coefficient of performance and COP are used. There is no connection between them. I prefer to use "cooling coefficient of performance (COP) in the first sentence and use COP to replace rest of coefficient of performance.

rraustad · 2021-04-02T04:21:26Z

tst/EnergyPlus/unit/HVACVariableRefrigerantFlow.unit.cc

    EXPECT_NEAR(state->dataLoopNodes->Node(thisTU.VRFTUOutletNodeNum).Temp, thisTU.coilTempSetPoint, 0.01);
-    EXPECT_NEAR(state->dataLoopNodes->Node(thisTU.VRFTUOutletNodeNum).Temp, 20.0, 0.01); // TU outlet is at set point = 20
+    EXPECT_NEAR(state->dataLoopNodes->Node(thisTU.VRFTUOutletNodeNum).Temp, 20.0, 0.01);


Add to existing unit test a check on min/max operating limits

rraustad · 2021-04-02T04:31:42Z

Do example file field names need to be updated? Or is there a script for that?

rraustad · 2021-04-02T04:39:46Z

@Myoldmopar I think I nailed it on the "Labels" description yet I got tagged on the PR labeling.

lgu1234 · 2021-04-02T13:45:19Z

doc/input-output-reference/src/overview/group-variable-refrigerant-flow-equipment.tex

@@ -74,13 +74,13 @@ \subsubsection{Inputs}\label{inputs-051}

 This numeric field defines the cooling coefficient of performance at rated conditions. The cooling coefficient of performance includes compressor power and condenser fan power. This COP value does not account for impacts due to the supply air fan. The nominal heat pump cooling COP must be greater than 0. If this field is left blank, a default coefficient of performance of 3.3 is assumed.



Both coefficient of performance and COP are used. There is no connection between them. I prefer to use "cooling coefficient of performance (COP) in the first sentence and use COP to replace rest of coefficient of performance.

lgu1234 · 2021-04-02T13:48:51Z

doc/input-output-reference/src/overview/group-variable-refrigerant-flow-equipment.tex


-This numeric field defines the minimum source temperature allowed for cooling operation. For air-cooled equipment outdoor dry-bulb temperature is used. For water-cooled equipment inlet water temperature is used. Below this temperature, cooling is disabled. If this field is left blank, the default value is -6ºC.
+This numeric field defines the minimum source inlet temperature allowed for cooling operation. For air-cooled equipment outdoor dry-bulb temperature is used. For water-cooled equipment inlet water temperature is used. Below this temperature, cooling is disabled. If this field is left blank, the default value is -6ºC.


My understanding is that this field provides a minimum temperature to disable cooling operation. It can be either air for air cooled equipment, or water for water-cooled equipment. I prefer to remove "Outdoor" in the field name, because it can be water temperature.

Yes, this is a minimum temperature to disable cooling/heating operation, but a minimum temperature of what/where? So my choice was to use "Minimum/Maximum Outdoor Unit Inlet Temperature in Cooling/Heating Mode" or "Minimum/Maximum Condenser Inlet Temperature in Cooling/Heating Mode", however, in heating mode the outdoor unit is actually the evaporator so I tried to be very generic using Minimum/Maximum Outdoor Unit Inlet Temperature in Cooling/Heating Mode. I guess I could change this to "Minimum/Maximum Unit Inlet Temperature in Cooling/Heating Mode" but that doesn't seem as descriptive.

Let's decide what this name should be before I change this.

Choices:

Minimum/Maximum Outdoor Unit Inlet Temperature in Cooling/Heating Mode

Minimum/Maximum Condenser Inlet Temperature in Cooling/Heating Mode

Minimum/Maximum Source Inlet Temperature in Cooling/Heating Mode

Minimum/Maximum Unit Inlet Temperature in Cooling/Heating Mode

Minimum/Maximum Inlet Temperature in Cooling/Heating Mode

Minimum/Maximum Temperature in Cooling/Heating Mode

This is a field in the AirConditioner:VariableRefrigerantFlow object so I guess it's implied to be a temperature in that location. I guess choice 6 seems reasonable.

@mjwitte do you have a preference for this field name? Or other suggestion?

I am going with the last option, Minimum/Maximum Temperature in Cooling/Heating Mode.

Well, given that the node field name is A35, \field Condenser Inlet Node Name, it seems that Min/Max Condenser Inlet Node Temp ... would be the most consistent. If you want to rename this node, that's fine, but it seems these temperature fields should use the same naming.

lgu1234 · 2021-04-02T13:49:17Z

doc/input-output-reference/src/overview/group-variable-refrigerant-flow-equipment.tex


-This numeric field defines the maximum source temperature allowed for cooling operation. For air-cooled equipment outdoor dry-bulb temperature is used. For water-cooled equipment inlet water temperature is used. Above this temperature, cooling is disabled. If this field is left blank, the default value is 43ºC.
+This numeric field defines the maximum source inlet temperature allowed for cooling operation. For air-cooled equipment outdoor dry-bulb temperature is used. For water-cooled equipment inlet water temperature is used. Above this temperature, cooling is disabled. If this field is left blank, the default value is 43ºC.


See above comment.

rraustad · 2021-04-16T23:01:44Z

I am considering A35, \field Fluid Inlet Node Name, and then Min/Max Fluid Inlet Temp..., but am not quite satisfied with that choice even though it is as generic as it gets.

mjwitte · 2021-04-20T18:22:52Z

I don't really like Fluid, because even though technically, air is a "fluid", I tend to think of liquids when I see that word. What you've done already here is adequate, not worth messing with. @mitchute If you're ok with that, then go ahead with final review here.

mitchute

This looks OK to me. I'm with Mike--skip adding "fluid" if to A35 if you can help it.

rraustad · 2021-04-21T01:25:32Z

Well, I don't mind changing to MinMax Condenser Inlet Node Temperature ... It will only take about an hour. Up to you guys.

mitchute · 2021-04-21T14:21:25Z

"MinMax Condenser Inlet Node Temperature" is about as clear as it gets as far as I'm concerned. Go for it.

…7-Water-cooled-VRF-heating-mode-operation

rraustad · 2021-04-30T18:01:57Z

@lgu1234 this should be ready now.

lgu1234 · 2021-05-26T18:40:58Z

@Myoldmopar I am OK for the changes. Please take a final look.

rraustad · 2021-06-09T22:17:04Z

Will change this to EXPECT_NEAR in unit test VRF_SysModel_inAirloop.
EXPECT_EQ(SysOutputProvided, 0.0); where SysOutputProvided = 2.47e-12

For the failed unit test with 2.47e-12 zero issue, the calculation of SysOutputProvided is:

LoadMet = AirMassFlow * PsyDeltaHSenFnTdb2W2Tdb1W1(TempOut, SpecHumOut, TempIn, SpecHumIn); // sensible {W}
AirMassFlow = 0.682...
TempIn = 24.000000000000000
TempOut = 24.000000000000004
SpecHumIn = 0.010000000000000
SpecHumOut = 0.010000000000000

The coils are off. The slight error is in the OA Mixer mixing calculation of mixed air temp.

state.dataMixedAir->OAMixer(OAMixerNum).MixEnthalpy =
    (RecircMassFlowRate * RecircEnthalpy +
     state.dataMixedAir->OAMixer(OAMixerNum).OAMassFlowRate * state.dataMixedAir->OAMixer(OAMixerNum).OAEnthalpy) /
    state.dataMixedAir->OAMixer(OAMixerNum).MixMassFlowRate;
state.dataMixedAir->OAMixer(OAMixerNum).MixHumRat = (RecircMassFlowRate * RecircHumRat + state.dataMixedAir->OAMixer(OAMixerNum).OAMassFlowRate *
                                                                                             state.dataMixedAir->OAMixer(OAMixerNum).OAHumRat) /
                                                    state.dataMixedAir->OAMixer(OAMixerNum).MixMassFlowRate;
state.dataMixedAir->OAMixer(OAMixerNum).MixPressure =
    (RecircMassFlowRate * RecircPressure +
     state.dataMixedAir->OAMixer(OAMixerNum).OAMassFlowRate * state.dataMixedAir->OAMixer(OAMixerNum).OAPressure) /
    state.dataMixedAir->OAMixer(OAMixerNum).MixMassFlowRate;
// Mixed air temperature is calculated from the mixed air enthalpy and humidity ratio.
state.dataMixedAir->OAMixer(OAMixerNum).MixTemp =
    PsyTdbFnHW(state.dataMixedAir->OAMixer(OAMixerNum).MixEnthalpy, state.dataMixedAir->OAMixer(OAMixerNum).MixHumRat);

…nergyPlus into 8687-Water-cooled-VRF-heating-mode-operation

rraustad · 2021-06-09T22:22:43Z

tst/EnergyPlus/unit/UnitaryHybridAirConditioner.unit.cc

@@ -1,1565 +1,1565 @@
-// EnergyPlus, Copyright (c) 1996-2021, The Board of Trustees of the University of Illinois,


I changed 3 lines of code in this unit test file. Good luck finding them. Something is going on with Clang.

Nope, I just changed the VRF unit test file. @Myoldmopar might want to check if line endings is still an issue in UnitaryHybridAirConditioner.unit.cc

Myoldmopar · 2021-06-22T03:11:28Z

Got this tab open to get this reviewed in the morning. I will check on the line endings issue first.

…VRF-heating-mode-operation

Myoldmopar · 2021-06-22T15:29:21Z

This looks great now. I pulled develop in and then converted the line endings in that unit test file back. It is testing now but after it passes I'll push the changes up. Assuming the unitary file now shows proper lines changed I'll merge it in directly. Thanks @rraustad for the changes and @mjwitte @lgu1234 @mitchute for the reviews.

Myoldmopar · 2021-06-22T15:32:26Z

Files changed tab is back in good shape. Merging.

IDD, docs, unit test

eafcbfb

rraustad added the Documentation Related primarily on the LaTeX-based EnergyPlus documentation label Apr 2, 2021

rraustad assigned lgu1234 Apr 2, 2021

rraustad commented Apr 2, 2021

View reviewed changes

lgu1234 reviewed Apr 2, 2021

View reviewed changes

rraustad added the IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) label Apr 2, 2021

rraustad added 2 commits April 5, 2021 10:16

Update docs based on comments

acdd35d

Update IDD based on comments.

0ec2126

mitchute approved these changes Apr 20, 2021

View reviewed changes

rraustad mentioned this pull request Apr 30, 2021

epJSON helper functions to get field values #8738

Merged

25 tasks

rraustad added 3 commits April 30, 2021 09:11

VRF min/max field name update

84028b1

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into 868…

ff8a3dd

…7-Water-cooled-VRF-heating-mode-operation

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into 868…

184e82a

…7-Water-cooled-VRF-heating-mode-operation

rraustad added the Defect Includes code to repair a defect in EnergyPlus label Apr 30, 2021

rraustad added 2 commits April 30, 2021 13:50

Clang format and 1 more doc change

c422cfc

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into 868…

e6f2d58

…7-Water-cooled-VRF-heating-mode-operation

Fix unit test and Merge branch 'develop' of https://github.com/NREL/E…

ab3bcd8

…nergyPlus into 8687-Water-cooled-VRF-heating-mode-operation

rraustad commented Jun 9, 2021

View reviewed changes

Merge remote-tracking branch 'origin/develop' into 8687-Water-cooled-…

fd25396

…VRF-heating-mode-operation

Fix line endings in hybrid ac unit test file

be19650

Myoldmopar merged commit e32b496 into develop Jun 22, 2021

Myoldmopar deleted the 8687-Water-cooled-VRF-heating-mode-operation branch June 22, 2021 15:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update VRF min/max outdoor unit inlet temp field description #8691

Update VRF min/max outdoor unit inlet temp field description #8691

rraustad commented Apr 2, 2021 •

edited

Loading

rraustad Apr 2, 2021

lgu1234 Apr 2, 2021

rraustad Apr 2, 2021

rraustad commented Apr 2, 2021

rraustad commented Apr 2, 2021

lgu1234 Apr 2, 2021

lgu1234 Apr 2, 2021

rraustad Apr 2, 2021

rraustad Apr 2, 2021

rraustad Apr 2, 2021

rraustad Apr 2, 2021

mjwitte Apr 5, 2021

lgu1234 Apr 2, 2021

rraustad commented Apr 16, 2021

mjwitte commented Apr 20, 2021

mitchute left a comment

rraustad commented Apr 21, 2021

mitchute commented Apr 21, 2021

rraustad commented Apr 30, 2021

lgu1234 commented May 26, 2021

rraustad commented Jun 9, 2021

rraustad Jun 9, 2021

rraustad Jun 9, 2021 •

edited

Loading

Myoldmopar commented Jun 22, 2021

Myoldmopar commented Jun 22, 2021

Myoldmopar commented Jun 22, 2021

		@@ -74,13 +74,13 @@ \subsubsection{Inputs}\label{inputs-051}

		This numeric field defines the cooling coefficient of performance at rated conditions. The cooling coefficient of performance includes compressor power and condenser fan power. This COP value does not account for impacts due to the supply air fan. The nominal heat pump cooling COP must be greater than 0. If this field is left blank, a default coefficient of performance of 3.3 is assumed.


		This numeric field defines the minimum source temperature allowed for cooling operation. For air-cooled equipment outdoor dry-bulb temperature is used. For water-cooled equipment inlet water temperature is used. Below this temperature, cooling is disabled. If this field is left blank, the default value is -6ºC.
		This numeric field defines the minimum source inlet temperature allowed for cooling operation. For air-cooled equipment outdoor dry-bulb temperature is used. For water-cooled equipment inlet water temperature is used. Below this temperature, cooling is disabled. If this field is left blank, the default value is -6ºC.


		This numeric field defines the maximum source temperature allowed for cooling operation. For air-cooled equipment outdoor dry-bulb temperature is used. For water-cooled equipment inlet water temperature is used. Above this temperature, cooling is disabled. If this field is left blank, the default value is 43ºC.
		This numeric field defines the maximum source inlet temperature allowed for cooling operation. For air-cooled equipment outdoor dry-bulb temperature is used. For water-cooled equipment inlet water temperature is used. Above this temperature, cooling is disabled. If this field is left blank, the default value is 43ºC.

		@@ -1,1565 +1,1565 @@
		// EnergyPlus, Copyright (c) 1996-2021, The Board of Trustees of the University of Illinois,

Update VRF min/max outdoor unit inlet temp field description #8691

Update VRF min/max outdoor unit inlet temp field description #8691

Conversation

rraustad commented Apr 2, 2021 • edited Loading

Pull request overview

Pull Request Author

Reviewer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Apr 2, 2021

rraustad commented Apr 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Apr 16, 2021

mjwitte commented Apr 20, 2021

mitchute left a comment

Choose a reason for hiding this comment

rraustad commented Apr 21, 2021

mitchute commented Apr 21, 2021

rraustad commented Apr 30, 2021

lgu1234 commented May 26, 2021

rraustad commented Jun 9, 2021

Choose a reason for hiding this comment

rraustad Jun 9, 2021 • edited Loading

Choose a reason for hiding this comment

Myoldmopar commented Jun 22, 2021

Myoldmopar commented Jun 22, 2021

Myoldmopar commented Jun 22, 2021

rraustad commented Apr 2, 2021 •

edited

Loading

rraustad Jun 9, 2021 •

edited

Loading