Fix #8670 - Example IDF File not valid per IDD: UnitaryHybridAC_DedicatedOutsideAir.idf

[jmarrec]

Pull request overview

• Fix Example IDF File not valid per IDD: UnitaryHybridAC_DedicatedOutsideAir.idf #8670 - Example IDF File not valid per IDD: UnitaryHybridAC_DedicatedOutsideAir.idf

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[mjwitte]

@jmarrec Energy+.idd is also missing this field.

  A110, \field Mode 10 Name
        \type alpha
        \retaincase
        \note Enter a name for Mode 10.
        \type alpha
        \retaincase
        \note Enter the name of the Supply Air Temperature Lookup Table for Mode 10.
        \note Units for lookup table values should be in C.
        \note If this field is blank, Mode 10 will not be considered for any time step that requires ventilation, heating, cooling, humidification, or dehumidification.
  A111, \field Mode 10 Supply Air Humidity Ratio Lookup Table Name
        \type object-list
        \object-list MultivariateFunctions
        \note Enter the name of the Supply Air Humidity Ratio Lookup Table for Mode 10.
        \note Units for lookup table values should be in kgWater/kgDryAir.
        \note If this field is blank, Mode 10 will not be considered for any time step that requires ventilation, heating, cooling, humidification, or dehumidification.
  A112, \field Mode 10 System Electric Power Lookup Table Name

[jmarrec]

That would explain it... I'll add it

[jmarrec]

Thanks for the catch @mjwitte

Added IDD field in 670e196.

This object really would be better off being an actual Extensible object... It is 5000 lines long, 660 fields.

[Myoldmopar]

@mjwitte if you are satisfied with this, you don't need to wait on all of CI to finish. I believe this is the last thing that can go in prior to the wrap up PRs.

[mjwitte]

@Myoldmopar I'm a little puzzled why there weren't any diffs from the first change to idf only. Maybe it doesn't use these higher modes?

[jmarrec]

@Myoldmopar I'm a little puzzled why there weren't any diffs from the first change to idf only. Maybe it doesn't use these higher modes?

I think it's because the Mode 6 is plain empty. On

EnergyPlus/src/EnergyPlus/HybridUnitaryAirConditioners.cc

Line 636 in a229933

for (int modeIter = 0; modeIter <= Numberofoperatingmodes - 1; ++modeIter) {

Numberofoperatingmodes = 6

[jmarrec]

Yup,

EnergyPlus/src/EnergyPlus/HybridUnitaryAirConditioners.cc

Lines 628 to 634 in a229933

	for (int i = FirstModeAlphaNumber; i <= NumAlphas; i = i + NumberOfAlphasPerMode) {
	if (!lAlphaBlanks(i)) {
	++Numberofoperatingmodes;
	} else {
	break;
	}
	}

So when it reaches

    ,                        !- Mode 6 Name

lAlphaBlanks(i) is true, so break. The rest is never read

Really, None of the others are actually filled out. The IDF snippet should be truncated at the end of Mode 5. This looks like a case of IDF Editor filling the default fields out, because this object isn't extensible.

[jmarrec]

I cut the IDF object at end of Mode 5 in 24ad155 @mjwitte

[mjwitte]

@jmarrec I was just coming to the same conclusion that it's not using most of that object. It also doesn't even look at A8, \field Method to Choose Controlled Inputs and Part Runtime Fraction.
Tested the revised file locally. All good.