Add an explicit "EnergyPlus" namespace to a state argument

[jasondegraw]

Pull request overview

This is a defect, but is so small I didn't bother with the issue

There's one function in CoilCoolingDXCurveFitPerformance.cc that is missing the explicit EnergyPlus namespace on the state argument. On Visual Studio 16.3.8, this triggers errors about an ambiguous symbol:

4>C:\...\EnergyPlus\src\EnergyPlus\Coils\CoilCoolingDXCurveFitPerformance.cc(535,67): error C2872: 'EnergyPlusData': ambiguous symbol
4>C:\...\EnergyPlus\src\EnergyPlus/InputProcessing/InputProcessor.hh(72,8): message : could be 'EnergyPlusData'
4>C:\...\EnergyPlus\src\EnergyPlus/TempSolveRoot.hh(68,8): message : or       'EnergyPlus::EnergyPlusData'

Newer versions (and maybe older versions) of Visual Studio do not have this problem. I'm currently stuck on this version for a while, or else I would just update. I think the using namespace EnergyPlus; at the top of the file is probably the thing that's really to blame, but this change at least makes the argument declaration all the same.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs