Set default value for OpaqueSkyCover when missing

[matthew-larson]

Pull request overview

• Fixes Opaque Sky Cover is used in Calculation when Horizontal Infrared Radiation Intensity is not missing in Simualtion Weather File #8610
• This pull request sets the default value for OpaqueSkyCover to the same default value set in WeatherManager. Currently OpaqueSkyCover gets set to 99 if value is missing in the weather file, which results in an incorrect calculation for ESky. I also additional checks for other kivaWeather properties to cover everything.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally

[Myoldmopar]

No problem setting these to the predefined missing values.

[Myoldmopar]

👍

[Myoldmopar]

Pulled develop and built and ran unit tests, all good. Changes look good. Merging.