Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moisture source and transport mechanisms to HAMT #8443

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

jasondegraw
Copy link
Member

@jasondegraw jasondegraw commented Dec 31, 2020

Pull request overview

This PR implements a new feature undertaken some time ago that was never merged. It adds a moisture source to the HAMT feature and implements three ways that the source is computed:

  • User defined, in which a user-specified airflow is used,
  • Stack and overpressure, in which a simplified model is used, and
  • AirflowNetwork, in which the pressure network model results are used.

There's an NFP from 2019 that documents the approach, but if there was documentation done it appears to be missing, so will
have to look into that. There also appears to have never been any unit testing put together, so will need to look into that as well.
This PR should go in after #8442.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide full documentation of the new feature
  • Transition up the example files from the older version
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jasondegraw jasondegraw added NewFeature Includes code to add a new feature to EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels Dec 31, 2020
@nrel-bot-3
Copy link

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@mjwitte
Copy link
Contributor

mjwitte commented Feb 5, 2021

@jasondegraw For 9.5 or future?

@jasondegraw
Copy link
Member Author

@mjwitte This one is definitely future.

@jasondegraw jasondegraw added this to the EnergyPlus Future milestone Feb 12, 2021
@nrel-bot-2
Copy link

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-3
Copy link

@jasondegraw @lgentile it has been 31 days since this pull request was last updated.

@Myoldmopar Myoldmopar removed this from the EnergyPlus 9.6 IOFreeze milestone Aug 18, 2021
@nrel-bot-2c
Copy link

@jasondegraw it has been 12 days since this pull request was last updated.

@nrel-bot-2b
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2b
Copy link

@jasondegraw it has been 10 days since this pull request was last updated.

1 similar comment
@nrel-bot-2
Copy link

@jasondegraw it has been 10 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

1 similar comment
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2b
Copy link

@jasondegraw it has been 19 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 11 days since this pull request was last updated.

1 similar comment
@nrel-bot-2b
Copy link

@jasondegraw it has been 11 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 10 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 9 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

2 similar comments
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 9 days since this pull request was last updated.

@nrel-bot-2b
Copy link

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 21 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

1 similar comment
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 10 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

1 similar comment
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 9 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

2 similar comments
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 8 days since this pull request was last updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) NewFeature Includes code to add a new feature to EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants