-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moisture source and transport mechanisms to HAMT #8443
base: develop
Are you sure you want to change the base?
Conversation
@jasondegraw @lgentile it has been 28 days since this pull request was last updated. |
@jasondegraw For 9.5 or future? |
@mjwitte This one is definitely future. |
…ureSource for example idf files.
…o hamt-1-and-2 merge some changes after i cloned the repo.
@jasondegraw @lgentile it has been 28 days since this pull request was last updated. |
@jasondegraw @lgentile it has been 28 days since this pull request was last updated. |
@jasondegraw @lgentile it has been 31 days since this pull request was last updated. |
@jasondegraw it has been 12 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 10 days since this pull request was last updated. |
1 similar comment
@jasondegraw it has been 10 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
1 similar comment
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 19 days since this pull request was last updated. |
@jasondegraw it has been 11 days since this pull request was last updated. |
1 similar comment
@jasondegraw it has been 11 days since this pull request was last updated. |
@jasondegraw it has been 10 days since this pull request was last updated. |
@jasondegraw it has been 9 days since this pull request was last updated. |
@jasondegraw it has been 8 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
2 similar comments
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 9 days since this pull request was last updated. |
@jasondegraw it has been 8 days since this pull request was last updated. |
@jasondegraw it has been 21 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
1 similar comment
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 10 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 8 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
1 similar comment
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 9 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
2 similar comments
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 7 days since this pull request was last updated. |
@jasondegraw it has been 8 days since this pull request was last updated. |
Pull request overview
This PR implements a new feature undertaken some time ago that was never merged. It adds a moisture source to the HAMT feature and implements three ways that the source is computed:
There's an NFP from 2019 that documents the approach, but if there was documentation done it appears to be missing, so will
have to look into that. There also appears to have never been any unit testing put together, so will need to look into that as well.
This PR should go in after #8442.
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.