Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Space Concept to EnergyPlus Zone Structure, Part 1 #8394

Merged
merged 121 commits into from
Aug 21, 2021
Merged
Show file tree
Hide file tree
Changes from 120 commits
Commits
Show all changes
121 commits
Select commit Hold shift + click to select a range
e694abc
NFP for Space
mjwitte Nov 25, 2020
06ace49
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Dec 11, 2020
00d64cd
Space NFP updates
mjwitte Dec 11, 2020
0bb911e
Add historical Space NFP for reference
mjwitte Dec 11, 2020
1b0e7f9
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Dec 17, 2020
bf631c2
Space - rename old NFP to avoid confusion
mjwitte Dec 17, 2020
bfb7410
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte May 11, 2021
85db3f8
Space NFP Plan C
mjwitte May 11, 2021
5604cba
Space NFP Plan C - fix figures
mjwitte May 12, 2021
4793fbc
Revert "Space NFP Plan C"
mjwitte May 12, 2021
d8c1cb6
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte May 19, 2021
5d9462e
Space NFP Plan D
mjwitte May 19, 2021
dff7946
Space NFP Plan D - fix typos
mjwitte May 19, 2021
3b92576
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte May 25, 2021
14c7c3b
Space NFP Plan D - conf call notes
mjwitte May 25, 2021
e963950
Space NFP Plan D - fix figure
mjwitte May 28, 2021
aff8376
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jun 7, 2021
e5c2eca
Space NFP Plan D - Design doc
mjwitte Jun 8, 2021
6b47dc7
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jun 16, 2021
5c27cd0
Space and SpaceList inputs
mjwitte Jun 16, 2021
578e769
Space - fix build warnings
mjwitte Jun 16, 2021
f29eeba
Space - drop zone name string
mjwitte Jun 17, 2021
c8178c4
Space - add field to surfaces
mjwitte Jun 17, 2021
77a1a60
Space - transition for surfaces
mjwitte Jun 17, 2021
8de8956
Space - transition testfiles
mjwitte Jun 17, 2021
44e3048
Space and SpaceList inputs - fix
mjwitte Jun 17, 2021
4c98b94
Space - transition unit tests
mjwitte Jun 18, 2021
0dec20a
Space - fix transition errors
mjwitte Jun 18, 2021
1777cb7
Space - expandobjects for GHT
mjwitte Jun 18, 2021
a358735
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jun 18, 2021
2185eaa
Space - CreateMissingSpaces
mjwitte Jun 18, 2021
5f4055e
Space - Move enclosures from zones to spaces part 1
mjwitte Jun 23, 2021
0bca57e
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jun 23, 2021
bba1775
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jun 24, 2021
6eb4804
Space - Internal gains
mjwitte Jun 25, 2021
0bb0cc3
Space - Add floor area input and calc
mjwitte Jun 25, 2021
015ee17
Space - People
mjwitte Jun 26, 2021
7097f64
Space - Radiant enclosures and some solar enclosures
mjwitte Jul 14, 2021
71810c9
Space - Merge cleanup?
mjwitte Jul 14, 2021
e3d4458
Space - Daylighting part 1
mjwitte Jul 15, 2021
b4c80ab
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jul 15, 2021
93b60b5
Space - fix failures and formatting
mjwitte Jul 15, 2021
d067ec9
Space - fix more problems
mjwitte Jul 19, 2021
04b3eb1
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jul 19, 2021
531fff6
Space - unit test repairs and formatting
mjwitte Jul 20, 2021
e09b772
Formatting
mjwitte Jul 20, 2021
7486e9d
Space - fix build warnings
mjwitte Jul 20, 2021
b0aca1f
Space - fix surface space assignments
mjwitte Jul 20, 2021
d06fb71
Space - fix People input processing
mjwitte Jul 20, 2021
dbd7fc7
Space - move call to GetSpaceData and add check for Spaces with no surfs
mjwitte Jul 20, 2021
2de351f
Space - more unit test repairs
mjwitte Jul 20, 2021
cfa218a
Formatting
mjwitte Jul 20, 2021
d80b0f9
Space - more unit test repairs and various refinements
mjwitte Jul 21, 2021
ee8379c
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jul 22, 2021
b5922de
Space - Fix more unit tests and daylighting problem
mjwitte Jul 22, 2021
53b1a41
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jul 22, 2021
75909b4
Space - Update new SetUpOutputVariable calls
mjwitte Jul 22, 2021
4a010d0
Space - fix field names in epJSON test file
mjwitte Jul 23, 2021
a34dfd7
Space - more unit test repairs and fix internal gains repvar bools
mjwitte Jul 23, 2021
58baba3
Space - propagate internal gains setup and comment new output vars
mjwitte Jul 23, 2021
6fd04fe
Space - fix zone enclosure numbers
mjwitte Jul 26, 2021
05c39ec
Space - fix some daylighting issues and revert some changes
mjwitte Jul 26, 2021
16b8acf
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jul 27, 2021
9582936
Space - fix air boundaries and user view factors
mjwitte Jul 27, 2021
638d213
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Jul 30, 2021
ffdc09a
Space - spaceTypes
mjwitte Jul 31, 2021
585c477
Space - NumOfSpaces -> numSpaces
mjwitte Jul 31, 2021
d4d3074
Space - fix spaceTypes allocation
mjwitte Jul 31, 2021
5a2eba4
Space - InputVerificationandResultsSummary
mjwitte Aug 1, 2021
9301c0a
Space - example file
mjwitte Aug 1, 2021
0e8bc59
Space - InputVerificationandResultsSummary cleanup add tags
mjwitte Aug 2, 2021
df66277
Space - naming cleanup
mjwitte Aug 2, 2021
b828a71
Space - naming cleanup 2nd pass
mjwitte Aug 2, 2021
aa5e2cc
Space - fix sql unit test
mjwitte Aug 2, 2021
5a961f3
Space - internal gains plan B - people
mjwitte Aug 4, 2021
9cb52ed
Space - fix instance naming for People
mjwitte Aug 5, 2021
d47aac4
Space - lets go with spaceIndex(es)
mjwitte Aug 5, 2021
33f7a1e
Space - DesignSpecification:OutdoorAir:SpaceList idd
mjwitte Aug 6, 2021
286a617
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Aug 6, 2021
7a4b932
Space - Fix new and old unit tests
mjwitte Aug 6, 2021
aa0698b
Space - DesignSpecification:OutdoorAir:SpaceList
mjwitte Aug 8, 2021
86d2bec
Space - repairs
mjwitte Aug 8, 2021
de24f91
PTAC unit test formatting
mjwitte Aug 8, 2021
f7531f4
Space - add Space Name to new test file
mjwitte Aug 9, 2021
e00fe1c
Space - desFlowPerZoneArea and desFlowPerZonePerson more
mjwitte Aug 9, 2021
3e32ba1
Space - DesignSpecification:OutdoorAir:SpaceList input processing
mjwitte Aug 10, 2021
dc8d216
Space - Fix internal gains by space
mjwitte Aug 10, 2021
6a0e4d7
Space - Support floor-only spaces and fix space surf lists
mjwitte Aug 10, 2021
adb587d
Space - Enclosure refinements and fixes
mjwitte Aug 10, 2021
5b736ca
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Aug 10, 2021
27cec54
Space - DSOA:SpaceList repairs
mjwitte Aug 10, 2021
4c68f2f
Space - fix diffs and unit tests
mjwitte Aug 11, 2021
f1758c1
Space - fix unit tests
mjwitte Aug 12, 2021
fa014e1
Space - setupIHGZonesAndSpaces and setupIHGOutputs for People
mjwitte Aug 12, 2021
7bf5185
Space - missing unit test include
mjwitte Aug 12, 2021
b40cc7b
Space - Lights
mjwitte Aug 13, 2021
477aaf7
Space - SpaceType meters
mjwitte Aug 13, 2021
7e74f43
Space - initialize numGainInstances
mjwitte Aug 13, 2021
3d653fe
Space - SetupOutputVariable revert ZoneKey and add SpaceType
mjwitte Aug 13, 2021
0a7253e
Space - partly address comments and test failures
mjwitte Aug 13, 2021
c8a069e
Space - fix sub-enduse zone and spacetype meters
mjwitte Aug 13, 2021
9fd14a0
Space - More on lighting summary report
mjwitte Aug 16, 2021
7a8f75c
Space - meter parameter name cleanup
mjwitte Aug 16, 2021
bca9228
Space - ABUPS enduse by space type
mjwitte Aug 16, 2021
7e2c6a4
Remove unused parameter from meter addEndUseSubcategory and SpaceType
mjwitte Aug 17, 2021
adb8c16
Space - Plug and Process Equipment
mjwitte Aug 17, 2021
b5b949b
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Aug 17, 2021
4744f65
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Aug 19, 2021
3748c12
Space - Replace new example file
mjwitte Aug 19, 2021
0fe6f1f
Space - Address comments and fix output variables
mjwitte Aug 19, 2021
0f1c86a
Space - address build warnings and use DataGlobalConstantsData::iEndU…
mjwitte Aug 19, 2021
3e2d7a1
Space - fix InternalHeatGains pasteos
mjwitte Aug 19, 2021
5fc2331
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Aug 19, 2021
f177d90
Space - input and output rules
mjwitte Aug 19, 2021
8b7cf07
Merge remote-tracking branch 'remotes/origin/develop' into spaces
mjwitte Aug 19, 2021
7421b46
Space - final IDD changes and input rules
mjwitte Aug 20, 2021
24376bc
Space - one more IDD note
mjwitte Aug 20, 2021
1216007
Space - fix more InternalHeatGains pasteos
mjwitte Aug 20, 2021
02e72c1
Space - update new test files
mjwitte Aug 20, 2021
70389a2
Space - one more input rule
mjwitte Aug 20, 2021
0bc8f15
Resolve conflict in input file
Myoldmopar Aug 21, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
503 changes: 503 additions & 0 deletions design/FY2021/NFP-Spaces.md

Large diffs are not rendered by default.

Binary file added design/FY2021/Space-Examples-FloorArea.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added design/FY2021/Space-Examples-FullGeometry.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
484 changes: 484 additions & 0 deletions design/FY2021/ZZZ-OLDNFP Space-2020-04-06-early discussions.md

Large diffs are not rendered by default.

708 changes: 630 additions & 78 deletions idd/Energy+.idd.in

Large diffs are not rendered by default.

270 changes: 228 additions & 42 deletions performance_tests/15zonePSZ.idf

Large diffs are not rendered by default.

270 changes: 228 additions & 42 deletions performance_tests/15zonePTAC.idf

Large diffs are not rendered by default.

270 changes: 228 additions & 42 deletions performance_tests/15zonePVAV.idf

Large diffs are not rendered by default.

270 changes: 228 additions & 42 deletions performance_tests/15zonevav.idf

Large diffs are not rendered by default.

252 changes: 219 additions & 33 deletions performance_tests/15zonevav_no_reports.idf

Large diffs are not rendered by default.

514 changes: 442 additions & 72 deletions performance_tests/30zonePSZ.idf

Large diffs are not rendered by default.

514 changes: 442 additions & 72 deletions performance_tests/30zonePTAC.idf

Large diffs are not rendered by default.

514 changes: 442 additions & 72 deletions performance_tests/30zonePVAV.idf

Large diffs are not rendered by default.

514 changes: 442 additions & 72 deletions performance_tests/30zonevav.idf

Large diffs are not rendered by default.

758 changes: 656 additions & 102 deletions performance_tests/45zonePSZ.idf

Large diffs are not rendered by default.

758 changes: 656 additions & 102 deletions performance_tests/45zonePTAC.idf

Large diffs are not rendered by default.

758 changes: 656 additions & 102 deletions performance_tests/45zonePVAV.idf

Large diffs are not rendered by default.

758 changes: 656 additions & 102 deletions performance_tests/45zonevav.idf

Large diffs are not rendered by default.

971 changes: 850 additions & 121 deletions performance_tests/BenchmarkHospitalNew_USA_CA_SAN_FRANCISCO.idf

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

197 changes: 110 additions & 87 deletions performance_tests/PipingSystem_Underground_FHX.idf
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
FHX House, !- Name
0.0, !- North Axis {deg}
Suburbs, !- Terrain
0.05, !- Loads Convergence Tolerance Value
0.05, !- Loads Convergence Tolerance Value {W}
0.05, !- Temperature Convergence Tolerance Value {deltaC}
FullInteriorAndExterior, !- Solar Distribution
35, !- Maximum Number of Warmup Days
Expand Down Expand Up @@ -92,7 +92,9 @@
Yes, !- Do System Sizing Calculation
Yes, !- Do Plant Sizing Calculation
Yes, !- Run Simulation for Sizing Periods
No; !- Run Simulation for Weather File Run Periods
No, !- Run Simulation for Weather File Run Periods
, !- Do HVAC Sizing Simulation for Sizing Periods
; !- Maximum Number of HVAC Sizing Simulation Passes

!***********************************************************
!****** LOCATION SPECIFIC OBJECTS **************************
Expand Down Expand Up @@ -201,7 +203,12 @@
0, !- Heating Design Air Flow Rate {m3/s}
, !- Heating Maximum Air Flow per Zone Floor Area {m3/s-m2}
, !- Heating Maximum Air Flow {m3/s}
; !- Heating Maximum Air Flow Fraction
, !- Heating Maximum Air Flow Fraction
, !- Design Specification Zone Air Distribution Object Name
, !- Account for Dedicated Outdoor Air System
, !- Dedicated Outdoor Air System Control Strategy
, !- Dedicated Outdoor Air Low Setpoint Temperature for Design {C}
; !- Dedicated Outdoor Air High Setpoint Temperature for Design {C}

Sizing:Zone,
Main Floor, !- Zone or ZoneList Name
Expand All @@ -225,7 +232,12 @@
0, !- Heating Design Air Flow Rate {m3/s}
, !- Heating Maximum Air Flow per Zone Floor Area {m3/s-m2}
, !- Heating Maximum Air Flow {m3/s}
; !- Heating Maximum Air Flow Fraction
, !- Heating Maximum Air Flow Fraction
, !- Design Specification Zone Air Distribution Object Name
, !- Account for Dedicated Outdoor Air System
, !- Dedicated Outdoor Air System Control Strategy
, !- Dedicated Outdoor Air Low Setpoint Temperature for Design {C}
; !- Dedicated Outdoor Air High Setpoint Temperature for Design {C}

Sizing:Plant,
Condenser Loop, !- Plant or Condenser Loop Name
Expand Down Expand Up @@ -352,6 +364,7 @@
Wall, !- Surface Type
Basement Wall/Floor Construction, !- Construction Name
Basement, !- Zone Name
, !- Space Name
OtherSideConditionsModel,!- Outside Boundary Condition
BasementWallOSCM, !- Outside Boundary Condition Object
NoSun, !- Sun Exposure
Expand All @@ -368,6 +381,7 @@
Wall, !- Surface Type
Basement Wall/Floor Construction, !- Construction Name
Basement, !- Zone Name
, !- Space Name
OtherSideConditionsModel,!- Outside Boundary Condition
BasementWallOSCM, !- Outside Boundary Condition Object
NoSun, !- Sun Exposure
Expand All @@ -384,6 +398,7 @@
Wall, !- Surface Type
Basement Wall/Floor Construction, !- Construction Name
Basement, !- Zone Name
, !- Space Name
OtherSideConditionsModel,!- Outside Boundary Condition
BasementWallOSCM, !- Outside Boundary Condition Object
NoSun, !- Sun Exposure
Expand All @@ -400,6 +415,7 @@
Wall, !- Surface Type
Basement Wall/Floor Construction, !- Construction Name
Basement, !- Zone Name
, !- Space Name
OtherSideConditionsModel,!- Outside Boundary Condition
BasementWallOSCM, !- Outside Boundary Condition Object
NoSun, !- Sun Exposure
Expand All @@ -416,6 +432,7 @@
Floor, !- Surface Type
Basement Wall/Floor Construction, !- Construction Name
Basement, !- Zone Name
, !- Space Name
OtherSideConditionsModel,!- Outside Boundary Condition
BasementFloorOSCM, !- Outside Boundary Condition Object
NoSun, !- Sun Exposure
Expand All @@ -432,6 +449,7 @@
Ceiling, !- Surface Type
Ceiling Construction, !- Construction Name
Basement, !- Zone Name
, !- Space Name
Zone, !- Outside Boundary Condition
Main Floor, !- Outside Boundary Condition Object
NoSun, !- Sun Exposure
Expand Down Expand Up @@ -475,6 +493,7 @@
Wall, !- Surface Type
Main Floor Wall Construction, !- Construction Name
Main Floor, !- Zone Name
, !- Space Name
Outdoors, !- Outside Boundary Condition
, !- Outside Boundary Condition Object
SunExposed, !- Sun Exposure
Expand All @@ -491,6 +510,7 @@
Wall, !- Surface Type
Main Floor Wall Construction, !- Construction Name
Main Floor, !- Zone Name
, !- Space Name
Outdoors, !- Outside Boundary Condition
, !- Outside Boundary Condition Object
SunExposed, !- Sun Exposure
Expand All @@ -507,6 +527,7 @@
Wall, !- Surface Type
Main Floor Wall Construction, !- Construction Name
Main Floor, !- Zone Name
, !- Space Name
Outdoors, !- Outside Boundary Condition
, !- Outside Boundary Condition Object
SunExposed, !- Sun Exposure
Expand All @@ -523,6 +544,7 @@
Wall, !- Surface Type
Main Floor Wall Construction, !- Construction Name
Main Floor, !- Zone Name
, !- Space Name
Outdoors, !- Outside Boundary Condition
, !- Outside Boundary Condition Object
SunExposed, !- Sun Exposure
Expand All @@ -539,6 +561,7 @@
Roof, !- Surface Type
Roof Construction, !- Construction Name
Main Floor, !- Zone Name
, !- Space Name
Outdoors, !- Outside Boundary Condition
, !- Outside Boundary Condition Object
SunExposed, !- Sun Exposure
Expand Down Expand Up @@ -830,97 +853,97 @@
Zone 2 Outlet Node; !- Return Air Stream Node Name

Curve:QuadLinear,
TotCoolCapCurve, ! Curve Name
-9.149069561, !- CoefficientC1
10.87814026, !- CoefficientC2
-1.718780157, !- CoefficientC3
0.746414818, !- CoefficientC4
0.0, !- CoefficientC5
-100, ! Minimum Value of w
100, ! Maximum Value of w
-100, ! Minimum Value of x
100, ! Maximum Value of x
0, ! Minimum Value of y
100, ! Maximum Value of y
0, ! Minimum Value of z
100, ! Maximum Value of z
0, ! Minimum Curve Output
38; ! Maximum Curve Output
TotCoolCapCurve, !- Name
-9.149069561, !- Coefficient1 Constant
10.87814026, !- Coefficient2 w
-1.718780157, !- Coefficient3 x
0.746414818, !- Coefficient4 y
0.0, !- Coefficient5 z
-100, !- Minimum Value of w
100, !- Maximum Value of w
-100, !- Minimum Value of x
100, !- Maximum Value of x
0, !- Minimum Value of y
100, !- Maximum Value of y
0, !- Minimum Value of z
100, !- Maximum Value of z
0, !- Minimum Curve Output
38; !- Maximum Curve Output

Curve:QuadLinear,
CoolPowCurve, ! Curve Name
-3.205409884, !- CoefficientC1
-0.976409399, !- CoefficientC2
3.97892546, !- CoefficientC3
0.938181818, !- CoefficientC4
0.0, !- CoefficientC5
-100, ! Minimum Value of w
100, ! Maximum Value of w
-100, ! Minimum Value of x
100, ! Maximum Value of x
0, ! Minimum Value of y
100, ! Maximum Value of y
0, ! Minimum Value of z
100, ! Maximum Value of z
0, ! Minimum Curve Output
38; ! Maximum Curve Output
CoolPowCurve, !- Name
-3.205409884, !- Coefficient1 Constant
-0.976409399, !- Coefficient2 w
3.97892546, !- Coefficient3 x
0.938181818, !- Coefficient4 y
0.0, !- Coefficient5 z
-100, !- Minimum Value of w
100, !- Maximum Value of w
-100, !- Minimum Value of x
100, !- Maximum Value of x
0, !- Minimum Value of y
100, !- Maximum Value of y
0, !- Minimum Value of z
100, !- Maximum Value of z
0, !- Minimum Curve Output
38; !- Maximum Curve Output

Curve:QuadLinear,
HeatCapCurve, ! Curve Name
-1.361311959, !- CoefficientC1
-2.471798046, !- CoefficientC2
4.173164514, !- CoefficientC3
0.640757401, !- CoefficientC4
0.0, !- CoefficientC5
-100, ! Minimum Value of w
100, ! Maximum Value of w
-100, ! Minimum Value of x
100, ! Maximum Value of x
0, ! Minimum Value of y
100, ! Maximum Value of y
0, ! Minimum Value of z
100, ! Maximum Value of z
0, ! Minimum Curve Output
38; ! Maximum Curve Output
HeatCapCurve, !- Name
-1.361311959, !- Coefficient1 Constant
-2.471798046, !- Coefficient2 w
4.173164514, !- Coefficient3 x
0.640757401, !- Coefficient4 y
0.0, !- Coefficient5 z
-100, !- Minimum Value of w
100, !- Maximum Value of w
-100, !- Minimum Value of x
100, !- Maximum Value of x
0, !- Minimum Value of y
100, !- Maximum Value of y
0, !- Minimum Value of z
100, !- Maximum Value of z
0, !- Minimum Curve Output
38; !- Maximum Curve Output

Curve:QuadLinear,
HeatPowCurve, ! Curve Name
-2.176941116, !- CoefficientC1
0.832114286, !- CoefficientC2
1.570743399, !- CoefficientC3
0.690793651, !- CoefficientC4
0.0, !- CoefficientC5
-100, ! Minimum Value of w
100, ! Maximum Value of w
-100, ! Minimum Value of x
100, ! Maximum Value of x
0, ! Minimum Value of y
100, ! Maximum Value of y
0, ! Minimum Value of z
100, ! Maximum Value of z
0, ! Minimum Curve Output
38; ! Maximum Curve Output
HeatPowCurve, !- Name
-2.176941116, !- Coefficient1 Constant
0.832114286, !- Coefficient2 w
1.570743399, !- Coefficient3 x
0.690793651, !- Coefficient4 y
0.0, !- Coefficient5 z
-100, !- Minimum Value of w
100, !- Maximum Value of w
-100, !- Minimum Value of x
100, !- Maximum Value of x
0, !- Minimum Value of y
100, !- Maximum Value of y
0, !- Minimum Value of z
100, !- Maximum Value of z
0, !- Minimum Curve Output
38; !- Maximum Curve Output

Curve:QuintLinear,
CoolSensCapCurve, ! Curve Name
-5.462690012, !- CoefficientC1
17.95968138, !- CoefficientC2
-11.87818402, !- CoefficientC3
-0.980163419, !- CoefficientC4
0.767285761, !- CoefficientC5
0.0, !- CoefficientC6
-100, ! Minimum Value of v
100, ! Maximum Value of v
-100, ! Minimum Value of w
100, ! Maximum Value of w
-100, ! Minimum Value of x
100, ! Maximum Value of x
0, ! Minimum Value of y
100, ! Maximum Value of y
0, ! Minimum Value of z
100, ! Maximum Value of z
0, ! Minimum Curve Output
38; ! Maximum Curve Output
CoolSensCapCurve, !- Name
-5.462690012, !- Coefficient1 Constant
17.95968138, !- Coefficient2 v
-11.87818402, !- Coefficient3 w
-0.980163419, !- Coefficient4 x
0.767285761, !- Coefficient5 y
0.0, !- Coefficient6 z
-100, !- Minimum Value of v
100, !- Maximum Value of v
-100, !- Minimum Value of w
100, !- Maximum Value of w
-100, !- Minimum Value of x
100, !- Maximum Value of x
0, !- Minimum Value of y
100, !- Maximum Value of y
0, !- Minimum Value of z
100, !- Maximum Value of z
0, !- Minimum Curve Output
38; !- Maximum Curve Output

Coil:Cooling:WaterToAirHeatPump:EquationFit,
Sys 2 Heat Pump Cooling Mode, !- Name
Expand Down
3 changes: 3 additions & 0 deletions scripts/dev/generate_epJSON_schema/modify_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ def isInt(s):
'RoofCeiling:Detailed': 'vertices',
'Shading:Site:Detailed': 'vertices',
'Wall:Detailed': 'vertices',
'Space': 'tags',
'SpaceList': 'spaces',
'DesignSpecification:OutdoorAir:SpaceList': 'space_specs',
'ZoneList': 'zones',
'Floor:Detailed': 'vertices',
'Shading:Building:Detailed': 'vertices',
Expand Down
17 changes: 11 additions & 6 deletions src/EnergyPlus/DataDaylighting.hh
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,13 @@ namespace DataDaylighting {
}
};

struct EnclDaylightCalc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Begin moving enclosure-level variables to their own struct to avoid confusion.

{
Real64 aveVisDiffReflect = 0.0; // Area-weighted average inside surface visible reflectance of zone
Real64 totInsSurfArea = 0.0; // Total inside surface area of a daylit zone (m2)
Real64 floorVisRefl = 0.0; // Area-weighted visible reflectance of floor of a daylit zone
};

struct ZoneDaylightCalc
{
// Members
Expand All @@ -141,7 +148,6 @@ namespace DataDaylighting {
int LightControlSteps; // Number of levels (excluding zero) of stepped control system
Real64 LightControlProbability; // For manual control of stepped systems, probability that lighting will
int TotalExtWindows; // Total number of exterior windows in the zone or same solar enclosure
Real64 AveVisDiffReflect; // Area-weighted average inside surface visible reflectance of zone
Real64 DElightGriddingResolution; // Field: Delight Gridding Resolution
Array1D<Real64> RefPtPowerReductionFactor; // =1.0 ! Electric power reduction factor at reference points
// due to daylighting
Expand All @@ -163,8 +169,6 @@ namespace DataDaylighting {
// sublists a just a single index to a fenestration surface if they are deployed one at a time.
Array1D_int MapShdOrdToLoopNum; // list that maps back the original loop order when using ShadeDeployOrderExtWins for shade deployment
Real64 MinIntWinSolidAng; // Minimum solid angle subtended by an interior window in a zone
Real64 TotInsSurfArea; // Total inside surface area of a daylit zone (m2)
Real64 FloorVisRefl; // Area-weighted visible reflectance of floor of a daylit zone
Real64 InterReflIllFrIntWins; // Inter-reflected illuminance due to beam and diffuse solar passing
// through a zone's interior windows (lux)
Array1D<Real64> BacLum; // =0.0 ! Background luminance at each reference point (cd/m2)
Expand Down Expand Up @@ -209,9 +213,9 @@ namespace DataDaylighting {
ZoneDaylightCalc()
: DaylightMethod(iDaylightingMethod::NoDaylighting), AvailSchedNum(0), TotalDaylRefPoints(0), LightControlType(iLtgCtrlType::Continuous),
glareRefPtNumber(0), ViewAzimuthForGlare(0.0), MaxGlareallowed(0), MinPowerFraction(0.0), MinLightFraction(0.0), LightControlSteps(0),
LightControlProbability(0.0), TotalExtWindows(0), AveVisDiffReflect(0.0), DElightGriddingResolution(0.0), ZonePowerReductionFactor(1.0),
NumOfIntWinAdjZones(0), NumOfIntWinAdjZoneExtWins(0), NumOfDayltgExtWins(0), MinIntWinSolidAng(0.0), TotInsSurfArea(0.0),
FloorVisRefl(0.0), InterReflIllFrIntWins(0.0), AdjZoneHasDayltgCtrl(false), MapCount(0)
LightControlProbability(0.0), TotalExtWindows(0), DElightGriddingResolution(0.0), ZonePowerReductionFactor(1.0), NumOfIntWinAdjZones(0),
NumOfIntWinAdjZoneExtWins(0), NumOfDayltgExtWins(0), MinIntWinSolidAng(0.0), InterReflIllFrIntWins(0.0), AdjZoneHasDayltgCtrl(false),
MapCount(0)
{
}
};
Expand Down Expand Up @@ -329,6 +333,7 @@ struct DaylightingData : BaseGlobalStruct
bool DFSReportAllShadowCalculationDays = false;
int TotDElightCFS = 0;

Array1D<DataDaylighting::EnclDaylightCalc> enclDaylight;
Array1D<DataDaylighting::ZoneDaylightCalc> ZoneDaylight;
Array1D<DataDaylighting::IllumMapData> IllumMap;
Array1D<DataDaylighting::MapCalcData> IllumMapCalc;
Expand Down
Loading