Remove EP_UNUSED and use C++17's [[maybe_unused]] #8382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefticus
added
the
Refactoring
|
I'm super excited for this. Every time we eliminate one of our custom solutions for something standard it makes me very happy. Thanks for c++17, I know there are many things we can evolve in this way. This looks totally ready, and since the other couple wide-reaching PRs look like they will need additional commits, I think I'll drop this in. Thanks for this quick transition, @lefticus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Move from
EP_UNUSEDmacro to the C++17[[maybe_unused]]attribute.No expected changes.