Add Output Variables to Ideal Air loads #8302

jmythms · 2020-09-24T20:46:25Z

Pull request overview

Fixes Add New Zone Ideal Loads Output Variables #8284 Add New Zone Ideal Loads Output Variables
This was a request to add four new output variables to Ideal Air loads. The four new variables added are:

Zone Ideal Loads Supply Air Temperature
Zone Ideal Loads Supply Air Humidity Ratio
Zone Ideal Loads Mixed Air Temperature
Zone Ideal Loads Mixed Air Humidity Ratio

The documentation has also been changed.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

mitchute

This will need a few minor cleanups. But it should be ready after that.

mitchute · 2020-09-29T18:05:45Z

doc/input-output-reference/src/overview/group-zone-forced-air-units.tex

@@ -486,6 +490,16 @@ \subsubsection{Outputs}\label{outputs-043}

 The volume flow rate of the supply air stream in m3/s using the standard density. The standard density is determined for dry air at the standard barometric pressure for the location's elevation and a temperature of 20.0ºC. The standard density does not vary over time.

+\paragraph{Zone Ideal Loads Supply Air Temperature {[}C{]}}\label{zone-ideal-loads-supply-air-temperature-c}
+
+The dry bulb temperature of the supply air stream in ºC.


We should use the \SI package for units.

Shall I change all of the title lines (like line 493) to use the \SI package? Or just in the text portion, like line 495?

Just change the in-text units. In this case, just move to \si{\celsius} (or whatever it ends up being). If you see others in this file, feel free to change them.

Got it, thanks!

mitchute · 2020-09-29T18:06:55Z

doc/input-output-reference/src/overview/group-zone-forced-air-units.tex

+
+\paragraph{Zone Ideal Loads Supply Air Humidity Ratio {[}kgWater/kgDryAir{]}}\label{zone-ideal-loads-supply-air-humidity-ratio-kgWaterkgDryAir}
+
+The humidity ratio of the supply air stream in kgWater/kgDryAir.


These units are fine, though 🙈

mitchute · 2020-09-29T18:07:55Z

src/EnergyPlus/PurchasedAirManager.cc

@@ -2785,6 +2802,8 @@ namespace PurchasedAirManager {
        PurchAir(PurchAirNum).OutdoorAirVolFlowRateStdRho = OAMassFlowRate / StdRhoAir;
        PurchAir(PurchAirNum).SupplyAirMassFlowRate = SupplyMassFlowRate;
        PurchAir(PurchAirNum).SupplyAirVolFlowRateStdRho = SupplyMassFlowRate / StdRhoAir;
+        PurchAir(PurchAirNum).ZoneIdealLoadsSupplyAirTemperature = Node(InNodeNum).Temp;


This is just passing the inlet temp and hum-rat through. I believe we want to use the already existing local variables SupplyTemp and SupplyHumRat to set these values.

Or would it work to just move SupplyTemp and SupplyHumRat from local into the PurchAir struct?

And while you're in here, MixedAirTemp and MixedAirHumRat would also be useful outputs.

That's fine with me.

mitchute · 2020-09-29T18:09:05Z

src/EnergyPlus/PurchasedAirManager.hh

@@ -247,6 +247,9 @@ namespace PurchasedAirManager {
        int ZonePtr;               // pointer to a zone served by an Ideal load air system
        int HVACSizingIndex;       // index of a HVAC Sizing object for an Ideal load air system

+        Real64 ZoneIdealLoadsSupplyAirTemperature; // ZoneIdealLoadsSupplyAirTemperature [C]


I'd shorten these to just SupplyAirTemp and SupplyHumRat.

…ruct

jmythms · 2020-10-06T17:40:49Z

doc/input-output-reference/src/overview/group-zone-forced-air-units.tex

+
+\paragraph{Zone Ideal Loads Mixed Air Humidity Ratio {[}kgWater/kgDryAir{]}}\label{zone-ideal-loads-supply-air-humidity-ratio-kgWaterkgDryAir}
+
+The humidity ratio of the mixed air stream after mixing the recirculation air stream and outdoor air stream (if present) in kgWater/kgDryAir.


New addition. Does it look ok?

Yes, this looks reasonable. I thought about adding "entering the zone inlet node" to be more specific but with the change for zone/spaces coming it's probably better at this point to leave this generic.

jmythms · 2020-10-07T05:32:05Z

doc/input-output-reference/src/overview/group-zone-forced-air-units.tex


 \paragraph{Field: Minimum Cooling Supply Air Humidity Ratio}\label{field-minimum-cooling-supply-air-humidity-ratio-000}

-The minimum humidity ratio (kg of water per kg of dry air) of the cool supply air. The default is 0.0077 kgWater/kgDryAir which corresponds to a 10C (50F) dew point.
+The minimum humidity ratio (kg of water per kg of dry air) of the cool supply air. The default is 0.0077 kgWater/kgDryAir which corresponds to a 10\si{\degreeCelsius} (50F) dew point.

 \paragraph{Field: Heating Limit}\label{field-heating-limit-000}



Mostly changing the tex code to use the siunitx package.

jmythms · 2020-10-07T05:39:58Z

testfiles/HVACTemplate-5ZonePurchAir.idf

+  Output:Variable,*,Zone Ideal Loads Mixed Air Humidity Ratio,Detailed;
+
+  Output:Variable,*,System Node Mass Flow Rate,Detailed;
+


Now the results appear in the test file output. Should I change the reporting frequency to hourly? Also, the effects are better visible for an annual simulation.

Yes, I would make the reporting frequency consistent - looks like everything else is hourly.

jmythms · 2020-10-07T05:49:45Z

src/EnergyPlus/PurchasedAirManager.cc

@@ -2080,6 +2106,8 @@ namespace PurchasedAirManager {
        PurchAir(PurchAirNum).MinOAMassFlowRate = 0.0;
        PurchAir(PurchAirNum).TimeEconoActive = 0.0;
        PurchAir(PurchAirNum).TimeHtRecActive = 0.0;
+        PurchAir(PurchAirNum).SupplyTemp = 0.0;
+        PurchAir(PurchAirNum).SupplyHumRat = 0.0;


Not sure if they need to be reset, and if 0.0 is ok.

jmythms · 2020-10-07T05:51:45Z

src/EnergyPlus/PurchasedAirManager.hh

@@ -175,8 +175,6 @@ namespace PurchasedAirManager {
        Real64 SupplyAirMassFlowRate;       // Supply air mass flow rate [kg/s]
        Real64 SupplyAirVolFlowRateStdRho;  // supply air volume flow using standard density [m3/s]
        // Intermediate results
-        Real64 FinalMixedAirTemp;     // Dry-bulb temperature of the mixed air, saved for system ventilation load reporting [C]
-        Real64 FinalMixedAirHumRat;   // Humidity ratio of the mixed air, saved for system ventilation load reporting [kgWater/kgDryAir]
        Real64 HtRecSenOutput;        // Sensible heating/cooling rate from heat recovery (<0 means cooling) [W]


Removed them since I felt the new mixedairtemp and mixedairhumrat were doing the same thing?

And it appears that FinalMixedAirTemp and FinalMixedAirHumRat weren't being used anywhere, so find to replace them here.

mitchute · 2020-10-07T19:55:19Z

@jmythms I'm not sure what the deal is with the regressions. Maybe we hit an API limit? (FYI @Myoldmopar ) Regardless of that, there are still some build warnings that will need to be addressed. Let me know if you need help figuring those out.

nrel-bot-2 · 2020-11-05T00:43:28Z

@jmythms @lgentile it has been 28 days since this pull request was last updated.

jmythms · 2021-02-11T14:27:52Z

@mjwitte May I get a review on this PR please? I added a new unit test for the new output variables.

rraustad · 2021-02-11T15:16:03Z

src/EnergyPlus/PurchasedAirManager.hh

@@ -274,8 +276,7 @@ namespace PurchasedAirManager {
              EMSValueMassFlowRate(0.0), EMSOverrideOAMdotOn(false), EMSValueOAMassFlowRate(0.0),
              EMSOverrideSupplyTempOn(false), EMSValueSupplyTemp(0.0), EMSOverrideSupplyHumRatOn(false),
              EMSValueSupplyHumRat(0.0), MinOAMassFlowRate(0.0),
-              OutdoorAirMassFlowRate(0.0), OutdoorAirVolFlowRateStdRho(0.0), SupplyAirMassFlowRate(0.0), SupplyAirVolFlowRateStdRho(0.0),
-              FinalMixedAirTemp(0.0), FinalMixedAirHumRat(0.0), HtRecSenOutput(0.0), HtRecLatOutput(0.0), OASenOutput(0.0), OALatOutput(0.0),
+              OutdoorAirMassFlowRate(0.0), OutdoorAirVolFlowRateStdRho(0.0), SupplyAirMassFlowRate(0.0), SupplyAirVolFlowRateStdRho(0.0), HtRecSenOutput(0.0), HtRecLatOutput(0.0), OASenOutput(0.0), OALatOutput(0.0),


Not sure why this line didn't wrap earlier. It's much longer than all the rest. Was Clang format used?

@rraustad I just checked this, it was disabled in my IDE. Shall I do one more commit after reformatting?

@Myoldmopar is it worth another commit for Clang formatting the hh file? I don't see any other changes needed, but I haven't tested the example file yet. Unit tests run clean locally.

rraustad · 2021-02-11T15:25:48Z

@mjwitte I have reviewed and this looks good. I would expect 0 diff's with this change so as long as CI shows that it should be ready to merge (save any last minute edits). Also, these new report variables, do those need to be included in a new report variable summary for users?

mjwitte · 2021-02-11T15:32:00Z

@rraustad We don't normally list new outputs in the output changes doc, maybe we should, but I wouldn't hold up this one. Did you reiew I/O Ref pdf to make sure all the changes are ok? Feel free to complete this review and merge.

rraustad · 2021-02-11T17:37:16Z

OK, I'll build the docs and run the example file. I see MTD and big table diff's on HVACTemplate-5ZonePurchAir. @jmythms did you review those diff's?

jmythms · 2021-02-11T20:19:15Z

OK, I'll build the docs and run the example file. I see MTD and big table diff's on HVACTemplate-5ZonePurchAir. @jmythms did you review those diff's?

The diffs were generated because I asked for the new variables in the IDF file.

The MTD diffs are changes in meter numbers, screenshot attached below.

Big table diffs are changes to the input fields, which were created from asking for these new variables:

rraustad · 2021-02-11T20:36:06Z

doc/input-output-reference/src/overview/group-zone-forced-air-units.tex

 This output reports the outdoor air temperature.  The outdoor air temperature is inherited from the associated outdoor air node in each timestep.  The output is the average over the reporting period.

 \paragraph{Zone Hybrid Unitary HVAC Supply Air Humidity Ratio [kgWater/kgDryAir]}
-This output reports the supply air humidity ratio. For each timestep the value is calculated as a supply air mass weighted average of the supply air humidity ratio for each of the settings selected for the time step. For example, if the system operates for half of the timestep with supply air mass flow rate of 1 kg/s and supply air humidity ratio of 0.016 kg/kg, and for half of the timestep at 2 kg/s and 0.010 kg/kg, the supply air humidity ratio calculated for the time step would be 0.012 °C. The output is the average over the reporting period.
+This output reports the supply air humidity ratio. For each timestep the value is calculated as a supply air mass weighted average of the supply air humidity ratio for each of the settings selected for the time step. For example, if the system operates for half of the timestep with supply air mass flow rate of 1 kg/s and supply air humidity ratio of 0.016 kg/kg, and for half of the timestep at 2 kg/s and 0.010 kg/kg, the supply air humidity ratio calculated for the time step would be 0.012\si{\degreeCelsius}. The output is the average over the reporting period.



There is an error here in the units (i.e., 0.012 C). The existing units were converted correctly, however, the units should be kgWater/kgDryAir. Also, the previous sentence uses kg/kg, these units could also be updated to be consistent. This is the only issue I found with the doc changes.

@jmythms there is a correction needed in the doc. This gives you the opportunity to Clang format the hh as needed (and cc? but I didn't see anything there). Give me a little time for more review before you make a commit.

That was a stupid mistake on my part. I will make the changes, and add the reformatted "src/EnergyPlus/PurchasedAirManager.hh" file in with that commit.

Fixed this:

rraustad · 2021-02-11T20:53:27Z

Results using new example file. This looks good. SA humidity ratio is unchanged in heating mode and always lower than mixed air in cooling mode.

rraustad · 2021-02-11T20:54:34Z

@jmythms I have finished my review. Go ahead and make your changes and commit.

rraustad

Reviewed code, docs and unit test. With the next commit this is ready for merge.

rraustad · 2021-02-11T20:57:37Z

@mjwitte @Myoldmopar this is ready to go after this next commit. I will merge when I can, just acknowledging my review and that this is approved and good to go.

jmythms · 2021-02-11T21:03:31Z

@jmythms I have finished my review. Go ahead and make your changes and commit.

Thank you so much for the review!

rraustad · 2021-02-11T21:34:25Z

@jmythms also check off the boxes in the Pull request overview above under Pull request author. I could do that but I would like you to start doing that for your PRs. It's a reminder check against our work so we don't forget anything.

jmythms · 2021-02-11T23:13:29Z

@jmythms also check off the boxes in the Pull request overview above under Pull request author. I could do that but I would like you to start doing that for your PRs. It's a reminder check against our work so we don't forget anything.

I have checked it for this PR and will start doing it for the other ones. The requested changes were made. Thanks again.

I also accidentally clang-formatted the "ScheduleManager.hh" file in the 863baf5 commit, did not revert it since I thought leaving it formatted would be a good thing. Just wanted to let you know.

rraustad · 2021-02-12T01:14:44Z

@jmythms, a tip moving forward. I want you to notice how much has changed when you clang format a file. I am glad I did not have to review the code with these format changes included with yours. The reviewer would have a very difficult time finding the actual code changes. Either format only the code you touch (in MSVS highlight the code, select Edit on the menu, then Advanced, then format selection) or clang format the file after reviewers have a chance to look at your changes. Just a tip to make the reviewers life easier. Anyway, I think this is ready now and I will run the unit tests one more time and then this can be merged.

rraustad · 2021-02-12T01:23:51Z

Unit tests run clean locally as expected.

rraustad · 2021-02-12T03:48:41Z

There is another diff here, the SolarShadingTestGPU example file but I think that has caused this same diff for some time.

rraustad · 2021-02-12T03:57:00Z

@jmythms did you have a pivotal ticket for this? I can't find one.

Add two output variables to Ideal Air loads

861cfef

jmythms added the NewFeature Includes code to add a new feature to EnergyPlus label Sep 24, 2020

jmythms added this to the EnergyPlus Future milestone Sep 24, 2020

jmythms self-assigned this Sep 24, 2020

mitchute requested changes Sep 29, 2020

View reviewed changes

jmythms added 3 commits September 29, 2020 16:04

Moved SupplyTemp and SupplyHumRat from local into the PurchAir struct

908ab51

Merge branch 'develop' into Add-New-Zone-Ideal-Loads-Output-Variables

6b7b538

Moved MixedAirTemp and MixedAirHumRat from local into the PurchAir st…

5acf86f

…ruct

mitchute changed the title ~~Add two output variables to Ideal Air loads~~ Add Output Variables to Ideal Air loads Sep 30, 2020

jmythms added 2 commits October 6, 2020 07:48

Merge branch 'develop' into Add-New-Zone-Ideal-Loads-Output-Variables

0bc4fdf

New Output Vars + Documentation + Removed old redundant vars

a5b0833

jmythms commented Oct 6, 2020

View reviewed changes

jmythms added 4 commits October 6, 2020 12:08

Fixed labels

14dbd0d

Unit fix

7bf3209

White spaces

6b73be5

Modifying testfiles to add the new outputs.

a33d794

jmythms requested review from mitchute and mjwitte October 7, 2020 05:28

jmythms commented Oct 7, 2020

View reviewed changes

Cleaning up degree symbols

e5f0e2a

jmythms commented Oct 7, 2020

View reviewed changes

Reorder members in the constructor

89a70d3

jmythms added 3 commits November 5, 2020 09:38

Merge branch 'develop' into Add-New-Zone-Ideal-Loads-Output-Variables

18e8fb9

Fixing output variables

279aa5c

Merge branch 'develop' into Add-New-Zone-Ideal-Loads-Output-Variables

747afea

jmythms marked this pull request as draft November 9, 2020 17:29

jmythms added 6 commits February 8, 2021 23:10

changed MixedAirHumRat to PurchAir(PurchAirNum).MixedAirHumRat

660dacb

broken unit test

fd33e3e

Intermediate commit for Unit test question

7fbaa76

fixed unit test

f67fbc8

Merge branch 'develop' into Add-New-Zone-Ideal-Loads-Output-Variables

ec0199d

Merge branch 'develop' into Add-New-Zone-Ideal-Loads-Output-Variables

bebe31c

rraustad reviewed Feb 11, 2021

View reviewed changes

rraustad requested changes Feb 11, 2021

View reviewed changes

jmythms added 3 commits February 11, 2021 15:09

Unit change+ .hh file clang formatting

863baf5

Clang formatted PurchasedAirManager.cc

e4ade3a

clang formatted PurchasedAirManager.hh

3cfe237

rraustad merged commit ec78ec2 into develop Feb 12, 2021

rraustad deleted the Add-New-Zone-Ideal-Loads-Output-Variables branch February 12, 2021 03:54

mjwitte mentioned this pull request Mar 3, 2021

EMS actuator no changing Air temperature in Ideal Loads #8579

Closed

3 tasks


		\paragraph{Zone Ideal Loads Supply Air Humidity Ratio {[}kgWater/kgDryAir{]}}\label{zone-ideal-loads-supply-air-humidity-ratio-kgWaterkgDryAir}

		The humidity ratio of the supply air stream in kgWater/kgDryAir.


		\paragraph{Zone Ideal Loads Mixed Air Humidity Ratio {[}kgWater/kgDryAir{]}}\label{zone-ideal-loads-supply-air-humidity-ratio-kgWaterkgDryAir}

		The humidity ratio of the mixed air stream after mixing the recirculation air stream and outdoor air stream (if present) in kgWater/kgDryAir.

		Output:Variable,*,Zone Ideal Loads Mixed Air Humidity Ratio,Detailed;

		Output:Variable,*,System Node Mass Flow Rate,Detailed;

Add Output Variables to Ideal Air loads #8302

Add Output Variables to Ideal Air loads #8302

Conversation

jmythms commented Sep 24, 2020 • edited by rraustad Loading

Pull request overview

Pull Request Author

Reviewer

mitchute left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitchute commented Oct 7, 2020

nrel-bot-2 commented Nov 5, 2020

jmythms commented Feb 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Feb 11, 2021

mjwitte commented Feb 11, 2021

rraustad commented Feb 11, 2021

jmythms commented Feb 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Feb 11, 2021 • edited Loading

rraustad commented Feb 11, 2021

rraustad left a comment

Choose a reason for hiding this comment

rraustad commented Feb 11, 2021

jmythms commented Feb 11, 2021

rraustad commented Feb 11, 2021

jmythms commented Feb 11, 2021

rraustad commented Feb 12, 2021

rraustad commented Feb 12, 2021

rraustad commented Feb 12, 2021

rraustad commented Feb 12, 2021

jmythms commented Sep 24, 2020 •

edited by rraustad

Loading

rraustad commented Feb 11, 2021 •

edited

Loading