Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new slinky ground heat exchanger simulation model #4692

Merged
merged 36 commits into from
Mar 3, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
a5e2e94
First pass at modifying GLHE models to make them object oriented.
Jan 20, 2015
5b35bf7
More work at introducing OOP to GLHE.
Jan 21, 2015
1875158
More work incorporating OOP in the GLHE code.
Jan 22, 2015
3caafe1
Correcting errors causing regression diffs.
Jan 23, 2015
85c700a
Start at making variables camelCase
Jan 29, 2015
77733f1
Cleaning up local variables. Removing, where possible, the use of: th…
Jan 30, 2015
122be1d
Some code cleanup after working some OOP into the GLHE.
Jan 30, 2015
100179a
More cleanup removing unnecessary local variables. Moving the updateG…
Feb 4, 2015
b223a67
Merge branch 'develop' into 1540218-SlinkyGroundHX
Feb 4, 2015
def1ffa
Adding input GSHP-Slinky.idf input file.
Feb 4, 2015
4f7eda4
Some cleanup from setting up the new model in the plant. Need to star…
Feb 5, 2015
ab2fbc0
Minor changes to IDD and GSHP-Slinky.idf.
Feb 6, 2015
418165e
Horizontal slinky g-function code implemented. Need to implement vert…
Feb 11, 2015
94aef01
Added changes to allowing calculation of vertical g-functions.
Feb 12, 2015
f965b76
Added field in IDD and IDF to allow user to specify maximum simulatio…
Feb 12, 2015
b0d7d0d
Merge branch 'develop' into 1540218-SlinkyGroundHX
Feb 12, 2015
beef0f7
Merge develop; resolve conflicts
Myoldmopar Feb 13, 2015
1846281
std::pow() to pow_2 cleanup, as well as other cleanup. Added the slin…
Feb 16, 2015
ec4dcb5
Getting close! Slinky and Vertical GLHE's are running. Still working …
Feb 20, 2015
444beca
Changed "name" to "Name." Hoping this will get this building on other…
Feb 23, 2015
f24f9fe
Restructuring "name" for VerifyName. Fixed missing parentheses in the…
Feb 23, 2015
beef740
Remove Sim use of .Name(); other minor cleanup
Myoldmopar Feb 24, 2015
a0a498d
Bug fix where ground temperature was not being updated.
Feb 24, 2015
37ea996
Merge branch '1540218-SlinkyGroundHX' of github.com:NREL/EnergyPlus i…
Feb 24, 2015
23a57f9
Moved AGG and SubAGG to the getInput routine for consistency. Removed…
Feb 25, 2015
7026a66
Changed slinky g-functions to be generated using base 'e' to keep con…
Feb 25, 2015
f055f2f
Merge remote-tracking branch 'remotes/origin/develop' into 1540218-Sl…
Feb 26, 2015
517ee87
Moved more into getGFunc routines because slinky g-functions are log …
Feb 26, 2015
0dfc625
Adding comments. Some other cleanups.
Feb 26, 2015
3eb936f
Stubbing out unit tests for GHX's.
Feb 27, 2015
ec09436
Adding unit tests.
Mar 2, 2015
ac45e44
Merge branch 'develop' into 1540218-SlinkyGroundHX
Mar 2, 2015
6513246
Fixed bug prevHour was not reset at the beginning of each environment…
Mar 3, 2015
393cbd4
Unit test cleanup.
Mar 3, 2015
ca5e498
Merge branch '1540218-SlinkyGroundHX' of github.com:NREL/EnergyPlus i…
Mar 3, 2015
10d0493
Changing EXPECT_DOUBLE_EQ to EXPECT_NEAR in the unit tests.
Mar 3, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 150 additions & 0 deletions idd/Energy+.idd.in
Original file line number Diff line number Diff line change
Expand Up @@ -62171,6 +62171,156 @@ GroundHeatExchanger:HorizontalTrench,
\note = 0.5 : short grass, much like a manicured lawn
\note = 1 : standard reference state (12 cm grass)
\note = 1.5 : wild growth

GroundHeatExchanger:Slinky,
\memo This models a slinky horizontal heat exchanger
\memo placed in a series of trenches
\memo The model uses the model developed by:
\memo Xiong, Z., D.E. Fisher, and J.D. Spitler. 2015.
\memo Development and Validation of a Slinky Ground Heat
\memo Exchanger Model. Applied Energy 141: 57-69.
A1 , \field Name
\required-field
A2 , \field Inlet Node Name
\type node
\required-field
A3 , \field Outlet Node Name
\type node
\required-field
N1 , \field Design Flow Rate
\type real
\units m3/s
\minimum> 0
\default 0.002
N4 , \field Soil Thermal Conductivity
\type real
\units W/m-K
\minimum> 0
\default 1.08
N2 , \field Soil Density
\type real
\units kg/m3
\minimum> 0
\default 962
N3, \field Soil Specific Heat
\required-field
\type real
\units J/kg-K
\minimum> 0
\default 2576
N7, \field Pipe Thermal Conductivity
\type real
\units W/m-K
\minimum> 0
\default 0.4
N5, \field Pipe Density
\type real
\units kg/m3
\minimum> 0
\default 641
N6, \field Pipe Specific Heat
\type real
\units J/kg-K
\minimum> 0
\default 2405
N8 , \field Pipe Outer Diameter
\type real
\units m
\minimum> 0
\ip-units in
\default 0.02667
N9 , \field Pipe Thickness
\type real
\units m
\minimum> 0
\ip-units in
\default 0.002413
A4 , \field Heat Exchanger Configuration
\note This is the orientation of the heat exchanger
\type choice
\key Vertical
\key Horizontal
N10 ,\field Coil Diameter
\note This is the diameter of the heat exchanger coil
\type real
\units m
\minimum> 0
\ip-units ft
\default 1.0
N7 , \field Coil Pitch
\note This is the center-to-center distance between coils
\type real
\units m
\minimum> 0
\ip-units ft
\default 0.20
N7 , \field Trench Depth
\note This is the distance from the ground surface to the
\note trench bottom
\type real
\units m
\minimum> 0
\ip-units ft
\default 1.8
N2 , \field Trench Length
\note This is the total length of a single trench
\note This assumes the heat exchanger runs the full length
\note of the trench
\type real
\units m
\minimum> 0
\ip-units ft
\default 10
N3 , \field Number of Trenches
\note This is the number of parallel trenches that
\note has a heat exchanger, one per trench
\type integer
\minimum 1
\default 1
N4 , \field Horizontal Spacing Between Pipes
\note This represents the average horizontal spacing
\note between any two
\note trenches for heat exchangers that have multiple trenches
\type real
\units m
\minimum> 0
\ip-units ft
\default 2.0
N16, \field Kusuda-Achenbach Average Surface Temperature
\note This is the parameter for average annual surface
\note temperature
\note This is an optional input in that if it is missing, a
\note Site:GroundTemperature:Shallow object must be found
\note in the input
\note The undisturbed ground temperature will be
\note approximated from this object
\type real
\units C
N17, \field Kusuda-Achenbach Average Amplitude of Surface
\note Temperature
\note This is the parameter for annual average amplitude from
\note average surface temperature
\note This is an optional input in that if it is missing, a
\note Site:GroundTemperature:Shallow object must be found
\note in the input
\note The undisturbed ground temperature will be approximated
\note from this object
\type real
\units deltaC
N18, \field Kusuda-Achenbach Phase Shift of Minimum Surface
\note Temperature
\note This is the parameter for phase shift from minimum
\note surface temperature
\note This is an optional input in that if it is missing, a
\note Site:GroundTemperature:Shallow object must be found
\note in the input
\note The undisturbed ground temperature will be approximated
\note from this object
\type real
\units days
N19; \field Maximum Length of Simulation
\type real
\units years

HeatExchanger:FluidToFluid,
\memo A fluid/fluid heat exchanger designed to couple the supply side of one loop to the demand side of another loop
Expand Down
Loading