Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include fan power in EIO file #10610

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Include fan power in EIO file #10610

merged 1 commit into from
Aug 12, 2024

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Jul 17, 2024 •
edited
Loading

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If structural output changes, add to output rules file and add OutputChange label

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze labels Jul 17, 2024
@lymereJ
Copy link
Collaborator Author

lymereJ commented Jul 17, 2024 •
edited
Loading

Here's an excerpt from the EIO of the defect file with this branch:

Component Sizing Information, Fan:ZoneExhaust, MAIN_CORRIDOR_ZN_1_FLR_1 EXHAUST FAN, User-Specified Maximum Flow Rate [m3/s], 0.00000
Component Sizing Information, Fan:ZoneExhaust, MAIN_CORRIDOR_ZN_1_FLR_1 EXHAUST FAN, Design Electric Power Consumption [W], 0.00000
Component Sizing Information, Fan:ZoneExhaust, MAIN_CORRIDOR_ZN_1_FLR_2 EXHAUST FAN, User-Specified Maximum Flow Rate [m3/s], 0.00000
Component Sizing Information, Fan:ZoneExhaust, MAIN_CORRIDOR_ZN_1_FLR_2 EXHAUST FAN, Design Electric Power Consumption [W], 0.00000
Component Sizing Information, Fan:ZoneExhaust, BATHROOMS_ZN_1_FLR_1 EXHAUST FAN, Design Electric Power Consumption [W], 221.22536
Component Sizing Information, Fan:ZoneExhaust, BATHROOMS_ZN_1_FLR_2 EXHAUST FAN, Design Electric Power Consumption [W], 221.22536
Component Sizing Information, Fan:ZoneExhaust, GYM_ZN_1_FLR_1 EXHAUST FAN, User-Specified Maximum Flow Rate [m3/s], 0.00000
Component Sizing Information, Fan:ZoneExhaust, GYM_ZN_1_FLR_1 EXHAUST FAN, Design Electric Power Consumption [W], 0.00000
Component Sizing Information, Fan:ZoneExhaust, KITCHEN_ZN_1_FLR_1 EXHAUST FAN, Design Electric Power Consumption [W], 2212.25364
Component Sizing Information, Fan:VariableVolume, VAV_POD_1 FAN, Design Size Maximum Flow Rate [m3/s], 16.75454
Component Sizing Information, Fan:VariableVolume, VAV_POD_1 FAN, Design Electric Power Consumption [W], 38262.80534
Component Sizing Information, Fan:VariableVolume, VAV_POD_2 FAN, Design Size Maximum Flow Rate [m3/s], 16.63218
Component Sizing Information, Fan:VariableVolume, VAV_POD_2 FAN, Design Electric Power Consumption [W], 37983.37018
Component Sizing Information, Fan:VariableVolume, VAV_POD_3 FAN, Design Size Maximum Flow Rate [m3/s], 17.55324
Component Sizing Information, Fan:VariableVolume, VAV_POD_3 FAN, Design Electric Power Consumption [W], 40086.82139
Component Sizing Information, Fan:VariableVolume, VAV_OTHER FAN, Design Size Maximum Flow Rate [m3/s], 20.50267
Component Sizing Information, Fan:VariableVolume, VAV_OTHER FAN, Design Electric Power Consumption [W], 46573.72490
Component Sizing Information, Fan:SystemModel, PSZ-AC_3:7_ADDAQ_UNITARY_PACKAGE_FAN, Design Size Design Maximum Air Flow Rate [m3/s], 12.06948
Component Sizing Information, Fan:SystemModel, PSZ-AC_3:7_ADDAQ_UNITARY_PACKAGE_FAN, Design Electric Power Consumption [W], 20465.66481
Component Sizing Information, Fan:SystemModel, PSZ-AC_1:5_ADDAQ_UNITARY_PACKAGE_FAN, Design Size Design Maximum Air Flow Rate [m3/s], 10.89831
Component Sizing Information, Fan:SystemModel, PSZ-AC_1:5_ADDAQ_UNITARY_PACKAGE_FAN, Design Electric Power Consumption [W], 18479.76339
Component Sizing Information, Fan:SystemModel, PSZ-AC_2:6_ADDAQ_UNITARY_PACKAGE_FAN, Design Size Design Maximum Air Flow Rate [m3/s], 9.35793
Component Sizing Information, Fan:SystemModel, PSZ-AC_2:6_ADDAQ_UNITARY_PACKAGE_FAN, Design Electric Power Consumption [W], 17303.29172
Component Sizing Information, Fan:SystemModel, PSZ-AC_4:8_ADDAQ_UNITARY_PACKAGE_FAN, Design Size Design Maximum Air Flow Rate [m3/s], 2.83168
Component Sizing Information, Fan:SystemModel, PSZ-AC_4:8_ADDAQ_UNITARY_PACKAGE_FAN, Design Electric Power Consumption [W], 3099.29442
Component Sizing Information, Fan:SystemModel, PSZ-AC_5:9_ADDAQ_UNITARY_PACKAGE_FAN, Design Size Design Maximum Air Flow Rate [m3/s], 6.33983
Component Sizing Information, Fan:SystemModel, PSZ-AC_5:9_ADDAQ_UNITARY_PACKAGE_FAN, Design Electric Power Consumption [W], 11903.02449

Only diffs are AUD/EIO changes due to the fact that fan power is now reported.

@lymereJ lymereJ added this to the EnergyPlus 24.2 IOFreeze milestone Jul 17, 2024
Myoldmopar
Myoldmopar approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem here, thanks @lymereJ

@Myoldmopar Myoldmopar merged commit 923c94e into develop Aug 12, 2024
18 checks passed
@Myoldmopar Myoldmopar deleted the rep_fan_W branch August 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

Assignees

@Myoldmopar Myoldmopar

Labels
Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze
Projects
None yet
Milestone
EnergyPlus 24.2 IOFreeze
Development

Successfully merging this pull request may close these issues.

EIO file only include Electric Power Consumption for Fan:SystemModel
7 participants
@lymereJ @Myoldmopar @nrel-bot @nrel-bot-2 @nrel-bot-3 @nrel-bot-2b @nrel-bot-2c