Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10122 - Floating point test equalities failing on Apple Silicon Macs #10598

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Jul 9, 2024

Pull request overview

After fix:

ctest -j 10

100% tests passed, 0 tests failed out of 2846

Total Test time (real) = 183.65 sec

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

…PECT_EQ with EXPECT_DOUBLE_EQ or EXPECT_NEAR

```
ctest -R '(EnergyPlusFixture.BaseSizer_setZoneCoilInletConditions|EnergyPlusFixture.DXCoils_Test1|EnergyPlusFixture.TestCalcCBF|EnergyPlusFixture.VRFFluidControl_FanSysModel_OnOffModeTest|EnergyPlusFixture.HeatBalanceManager_TestZonePropertyLocalEnv|EnergyPlusFixture.HeatBalanceSurfaceManager_TestSurfPropertyLocalEnv|EnergyPlusFixture.ITE_Env_Class_Update_Class_H1|SQLiteFixture.UpdateSizing_EndSysSizingCalc|EnergyPlusFixture.BIPVT_calculateBIPVTMaxHeatGain|EnergyPlusFixture.Psychrometrics_PsyCpAirFn_Test|ZoneIdealLoadsTest.IdealLoads_Fix_SA_HumRat_Test|EnergyPlusFixture.SolarShadingTest_CTRANS|EnergyPlusFixture.VentilatedSlab_InitVentilatedSlabTest|EnergyPlusFixture.StratifiedTankSourceTemperatures)' --output-on-failure
```
@jmarrec jmarrec added Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) labels Jul 9, 2024
@jmarrec jmarrec requested a review from Myoldmopar July 9, 2024 11:44
@jmarrec jmarrec self-assigned this Jul 9, 2024
@Myoldmopar
Copy link
Member

Looks great to me, all reasonable. Let's merge.

@Myoldmopar Myoldmopar merged commit cc6cceb into develop Jul 9, 2024
15 checks passed
@Myoldmopar Myoldmopar deleted the 10122_FloatingPoint_Eq_MacM1 branch July 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating point test equalities failing on M1 Mac
7 participants