Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More IO Freeze Fixes #10411

Merged
merged 13 commits into from
Feb 23, 2024
Merged

More IO Freeze Fixes #10411

merged 13 commits into from
Feb 23, 2024

Conversation

Myoldmopar
Copy link
Member

Fixed a few issues identified during IO freeze RC testing, and a little extra stuff I was already working on.

@Myoldmopar Myoldmopar added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Feb 22, 2024
Copy link
Member Author

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I am going to fix up some TeX warnings as well and push them up. After that, I'll merge this in and retry an IO freeze RC. Hopefully today is the day!

@@ -74,6 +74,7 @@ cmake-build-*
build-wheel/
dist/
energyplus.egg-info
wheelhouse/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auditwheel package puts patched up wheels into the wheelhouse directory, so I'm just adding that to the ignore list here.

python:
install:
- requirements: doc/readthedocs/requirements.txt

submodules:
exclude: all
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a bit of extra stuff to the read-the-docs config file so hopefully those docs build again.

@@ -57,6 +57,8 @@ install(FILES "versions/V9-5-0-Energy+.idd" DESTINATION "PreProcess/IDFVersionUp
install(FILES "versions/V9-6-0-Energy+.idd" DESTINATION "PreProcess/IDFVersionUpdater")
install(FILES "versions/V22-1-0-Energy+.idd" DESTINATION "PreProcess/IDFVersionUpdater")
install(FILES "versions/V22-2-0-Energy+.idd" DESTINATION "PreProcess/IDFVersionUpdater")
install(FILES "versions/V23-1-0-Energy+.idd" DESTINATION "PreProcess/IDFVersionUpdater")
install(FILES "versions/V23-2-0-Energy+.idd" DESTINATION "PreProcess/IDFVersionUpdater")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was informed we were missing an IDD from the install, and I found both 23.1 and 23.2 were missing from this list. Apparently 23.2 is there from a different CMake command, but I'm putting them both here for completion.

]
)
print(f"EnergyPlus finished with outputs in directory: {run_dir}")
exit(return_value)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a script that no one needs to worry about really. When I need to debug code that specifically calls into EnergyPlus from the API, this will be a very helpful little script to keep right in the repo. I doubt anyone else will ever use it...

@@ -97,7 +97,7 @@ def get_current_wheel_details():
},
"Linux": {
"x86_64": {
"wheel": "linux_x86_64",
"wheel": "manylinux_2_17_x86_64",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we should be able to meet the constraints of the manylinux_2_17_x86_64 wheel, so that's nice.

// https://docs.python.org/3/c-api/init_config.html#preinitialize-python-with-pypreconfig
// It looks like we don't need to initialize from config again, it should be all set up with
// the init calls above, so just initialize and move on.
Py_Initialize();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment.

@Myoldmopar
Copy link
Member Author

I tested this on all 3 platforms, including basic install structure, running a Python Plugin file, and running Fortran-based transition on a 23.2 file and seeing it successfully transition and run. Merging this and tagging IO freeze.

@Myoldmopar Myoldmopar merged commit 69e977a into develop Feb 23, 2024
28 of 31 checks passed
@Myoldmopar Myoldmopar deleted the WheelFixes branch February 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants