Fix HVAC radiant heat gain with CondFD #10310

mjwitte · 2023-11-30T22:50:29Z

Pull request overview

Fixes Surface Inside Face System Radiation Heat Gain is always zero for ConductionFiniteDifference #10304
Streamlines tracking of surfaces that receive radiant system heat gains and surfaces with SurfaceProperty:HeatBalanceSourceTerm.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…Gain10304

mjwitte

Code walkthru.

mjwitte · 2023-12-15T22:06:29Z

src/EnergyPlus/DataHeatBalFanSys.hh

@@ -89,6 +89,15 @@ namespace DataHeatBalFanSys {
        int DualPMVErrIndex = 0; // Dual PMV setpoint error index
    };

+    struct SurfQRadFromHVACData


New struct to hold the old Array1Ds for SurfQHTRadSys, SurfQHWBaseboard, etc.

mjwitte · 2023-12-15T22:07:26Z

src/EnergyPlus/DataHeatBalance.hh

-        bool anySurfacesWithoutSpace = false; // True if any surfaces in a zone do not have a space assigned in input
-        bool anySurfacesWithSpace = false;    // True if any surfaces in a zone have a space assigned in input


Unrelated to the main defect, but moved these out of state.

mjwitte · 2023-12-15T22:08:20Z

src/EnergyPlus/DataSurfaces.hh

+    std::vector<int> allInsideSourceSurfaceList;       // List of all surfaces with SurfaceProperty:HeatBalanceSourceTerm for inside face
+    std::vector<int> allOutsideSourceSurfaceList;      // List of all surfaces with SurfaceProperty:HeatBalanceSourceTerm for outside face
+    std::vector<int> allGetsRadiantHeatSurfaceList;    // List of all surfaces that receive radiant HVAC output


New surface lists for special cases.

mjwitte · 2023-12-15T22:08:45Z

src/EnergyPlus/ElectricBaseboardRadiator.cc

@@ -409,6 +409,7 @@ namespace ElectricBaseboardRadiator {
                }
                if (elecBaseboard.SurfacePtr(SurfNum) != 0) {
                    state.dataSurface->surfIntConv(elecBaseboard.SurfacePtr(SurfNum)).getsRadiantHeat = true;
+                    state.dataSurface->allGetsRadiantHeatSurfaceList.emplace_back(elecBaseboard.SurfacePtr(SurfNum));


Example of building the allGetsRadiantHeatSurfaceList vector.

mjwitte · 2023-12-15T22:11:37Z

src/EnergyPlus/ElectricBaseboardRadiator.cc

-        state.dataHeatBalFanSys->SurfQElecBaseboard = 0.0;
+        for (auto &elecBaseboard : state.dataElectBaseboardRad->ElecBaseboard) {
+            for (int radSurfNum = 1; radSurfNum <= elecBaseboard.TotSurfToDistrib; ++radSurfNum) {
+                int surfNum = elecBaseboard.SurfacePtr(radSurfNum);
+                state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum).ElecBaseboard = 0.0;


Instead of zeroing this for all surfaces, only need to touch the surfaces that actually receive radiant heat from electric baseboards. Similar changes for the other four equipment types (chilled panel, HW baseboard, Steam baseboard, high temp radiant).

mjwitte · 2023-12-15T22:18:06Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

@@ -7571,11 +7568,12 @@ void CalcHeatBalanceInsideSurf(EnergyPlusData &state,
        state.dataHeatBalSurfMgr->calcHeatBalInsideSurEnvrnFlag = true;
    }

+    sumSurfQdotRadHVAC(state);


This is the main fix for the defect. A new function to gather all of the radiant impacts on the pertinent surfaces. One call here no matter the surface type or the heat transfer algorithm.

mjwitte · 2023-12-15T22:18:43Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-                    EnergyPlus::ScheduleManager::GetCurrentScheduleValue(state, state.dataSurface->Surface(SurfNum).InsideHeatSourceTermSchedule);
-            }
-        }
+    for (int surfNum : state.dataSurface->allInsideSourceSurfaceList) {


Streamline inside source.

mjwitte · 2023-12-15T22:19:26Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-                    if (state.dataHeatBalSurf->AnyRadiantSystems(SurfNum))
-                        state.dataHeatBalSurf->SurfQdotRadHVACInPerArea(SurfNum) = GetSurfQdotRadHVACInPerArea(state, SurfNum);


Replaced with new call to sumSurfQdotRadHVAC, here and several other places.

mjwitte · 2023-12-15T22:21:05Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-    return state.dataHeatBalFanSys->SurfQHTRadSys(SurfNum) + state.dataHeatBalFanSys->SurfQHWBaseboard(SurfNum) +
-           state.dataHeatBalFanSys->SurfQSteamBaseboard(SurfNum) + state.dataHeatBalFanSys->SurfQElecBaseboard(SurfNum) +
-           state.dataHeatBalFanSys->SurfQCoolingPanel(SurfNum);
+    for (int surfNum : state.dataSurface->allGetsRadiantHeatSurfaceList) {


New function sumSurfQdotRadHVAC sums radiant fluxes only for pertinent surfaces.

mjwitte · 2023-12-15T22:21:53Z

src/EnergyPlus/SurfaceGeometry.cc

+        EPVector<bool> anySurfacesWithSpace;    // True if any surfaces in a zone do not have a space assigned in input
+        EPVector<bool> anySurfacesWithoutSpace; // True if any surfaces in a zone have a space assigned in input


Moved from state. Not related to the defect.

mjwitte · 2023-12-15T22:43:34Z

Defect file results, before, Surface Inside Face System Radiation Heat Gain Rate is always zero.

And with this branch, now there are values.

Myoldmopar

This is wonderful. Quite a few small cleanups to go along with the actual defect fix. I am getting a little blurry about all the different lists of surfaces, but I understand it is helping the code move in the right direction. I would be happy to brainstorm where these should go in the future to avoid the list becoming excessive, but I am not complaining about where it is at.

I'll go ahead and confirm CI, and build/test locally, and see if this can go in.

Myoldmopar · 2024-01-05T15:35:17Z

src/EnergyPlus/DataHeatBalFanSys.hh

@@ -89,6 +89,15 @@ namespace DataHeatBalFanSys {
        int DualPMVErrIndex = 0; // Dual PMV setpoint error index
    };

+    struct SurfQRadFromHVACData


Myoldmopar · 2024-01-05T15:35:38Z

src/EnergyPlus/DataHeatBalance.hh

-        bool anySurfacesWithoutSpace = false; // True if any surfaces in a zone do not have a space assigned in input
-        bool anySurfacesWithSpace = false;    // True if any surfaces in a zone have a space assigned in input


Myoldmopar · 2024-01-05T15:41:32Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+        thisSurfQRadFromHVAC.SteamBaseboard = 0.0;
+        thisSurfQRadFromHVAC.ElecBaseboard = 0.0;
+        thisSurfQRadFromHVAC.CoolingPanel = 0.0;
+    }


This is fine as is. But if this is actually zeroing out every member variable, it could be nice to include a "reset" function on the struct that zeroes out all the members there. It's not functionally different, but could future proof things. If we add more member variables to the struct in the future, having the reset function right there in the struct would make it easier to remember to initialize them. Don't sweat it now unless there are more changes needed.

Myoldmopar · 2024-01-05T15:41:53Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

@@ -7571,11 +7568,12 @@ void CalcHeatBalanceInsideSurf(EnergyPlusData &state,
        state.dataHeatBalSurfMgr->calcHeatBalInsideSurEnvrnFlag = true;
    }

+    sumSurfQdotRadHVAC(state);


Myoldmopar · 2024-01-05T15:42:39Z

src/EnergyPlus/SurfaceGeometry.cc

+        EPVector<bool> anySurfacesWithSpace;    // True if any surfaces in a zone do not have a space assigned in input
+        EPVector<bool> anySurfacesWithoutSpace; // True if any surfaces in a zone have a space assigned in input


Myoldmopar · 2024-01-05T17:32:09Z

CI was totally happy here when it ran. I built and tested locally and it's happy. Let's get this merged in as well. Thanks @mjwitte !

mjwitte added 2 commits November 30, 2023 16:23

Set AnyRadiantSystems by surface

3305e69

Single call to sumSurfQdotRadHVAC

041dbd7

mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Nov 30, 2023

mjwitte added 10 commits December 1, 2023 10:21

Merge remote-tracking branch 'remotes/origin/develop' into SysRadHeat…

a5bed1f

…Gain10304

Move anySurfacesWith/WithoutSpace out of state

10d17cd

add global anyRadiantSystems delete AnyRadiantSystems surface array

fd480aa

Streamline SurfaceProperty:HeatBalanceSourceTerm

6062c0e

Streamline SurfQdotRadHVACInPerArea

195ee79

surfQRadFromHVAC struct

37275cb

refine surfQRadFromHVAC

1d98cf0

extend some unit tests

5ed25d1

Merge remote-tracking branch 'remotes/origin/develop' into SysRadHeat…

e52dca0

…Gain10304

zero only pertinent surfQRadFromHVAC

08d9724

mjwitte commented Dec 15, 2023

View reviewed changes

mjwitte marked this pull request as ready for review December 15, 2023 22:22

Myoldmopar self-assigned this Dec 20, 2023

Myoldmopar approved these changes Jan 5, 2024

View reviewed changes

Myoldmopar merged commit 5436820 into develop Jan 5, 2024
15 checks passed

Myoldmopar deleted the SysRadHeatGain10304 branch January 5, 2024 17:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix HVAC radiant heat gain with CondFD #10310

Fix HVAC radiant heat gain with CondFD #10310

mjwitte commented Nov 30, 2023 •

edited

Loading

mjwitte left a comment

mjwitte Dec 15, 2023

Myoldmopar Jan 5, 2024

mjwitte Dec 15, 2023

Myoldmopar Jan 5, 2024

mjwitte Dec 15, 2023

mjwitte Dec 15, 2023

mjwitte Dec 15, 2023

mjwitte Dec 15, 2023

Myoldmopar Jan 5, 2024

mjwitte Dec 15, 2023

mjwitte Dec 15, 2023

mjwitte Dec 15, 2023

mjwitte Dec 15, 2023

Myoldmopar Jan 5, 2024

mjwitte commented Dec 15, 2023

Myoldmopar left a comment

Myoldmopar Jan 5, 2024

Myoldmopar Jan 5, 2024

Myoldmopar Jan 5, 2024

Myoldmopar Jan 5, 2024

Myoldmopar Jan 5, 2024

Myoldmopar commented Jan 5, 2024

		bool anySurfacesWithoutSpace = false; // True if any surfaces in a zone do not have a space assigned in input
		bool anySurfacesWithSpace = false; // True if any surfaces in a zone have a space assigned in input

		if (state.dataHeatBalSurf->AnyRadiantSystems(SurfNum))
		state.dataHeatBalSurf->SurfQdotRadHVACInPerArea(SurfNum) = GetSurfQdotRadHVACInPerArea(state, SurfNum);

		EPVector<bool> anySurfacesWithSpace; // True if any surfaces in a zone do not have a space assigned in input
		EPVector<bool> anySurfacesWithoutSpace; // True if any surfaces in a zone have a space assigned in input

Fix HVAC radiant heat gain with CondFD #10310

Fix HVAC radiant heat gain with CondFD #10310

Conversation

mjwitte commented Nov 30, 2023 • edited Loading

Pull request overview

Pull Request Author

Reviewer

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Dec 15, 2023

Myoldmopar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar commented Jan 5, 2024

mjwitte commented Nov 30, 2023 •

edited

Loading