Skip to content

Commit

Permalink
Refactor NFP mark sample IDF and IDD changes
Browse files Browse the repository at this point in the history
The NFP mentions proposals for new keys for the
GroundHeatExchanger:System. This would result in new lines in IDF and
IDD sections. Sample IDF and IDD are presented with proposed changes.
It is helpful for the reader to quickly be able to distinguish the
new lines.

The code blocks in markdown do not allow for highlighting (e.g. bold,
underline, etc.). Additionally, html font highlighting did not appear
to render in the .md file on github. The changed lines were placed
below, and were intended to be highlighted in red (rendering md in atom
offline looked fine), but were not. Therefore, the proposed changed
lines now begin with a ">" to show distinction.
  • Loading branch information
j_c_cook committed Apr 10, 2021
1 parent c127355 commit e042488
Showing 1 changed file with 9 additions and 18 deletions.
27 changes: 9 additions & 18 deletions design/FY2021/NFP-Fast_gFunc_Calc_cpgfunction.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ object, the “g-function calculation model name”, with values of:
- UBHWTcalc for the new calculation method that utilizes uniform borehole wall
temperature boundary conditions.

Sample IDF and IDD follow with changes marked in red:
Sample IDF and IDD follow, new lines are marked with ">" at the beginning of
the line:

```
!!! IDF example using GHE:Vertical:Array input !!!
Expand All @@ -188,10 +189,10 @@ GroundHeatExchanger:System,
2.5, !- Ground Thermal Conductivity {W/m-K}
2.5E+06, !- Ground Thermal Heat Capacity {J/m3-K}
, !- GHE:Vertical:ResponseFactors Object Name
UHFcalc, !- g-function Calculation Model Name
>UHFcalc, !- g-function Calculation Model Name
GHE-Array; !- GHE:Vertical:Array Object Name
```
<span style="color:red">UHFcalc, !- g-function Calculation Model Name</span>


```
!!! IDF example using GHE:Vertical:Single input !!!
Expand All @@ -206,21 +207,21 @@ GroundHeatExchanger:System,
2.5, !- Ground Thermal Conductivity {W/m-K}
2.5E+06, !- Ground Thermal Heat Capacity {J/m3-K}
, !- GHE:Vertical:ResponseFactors Object Name
UHFcalc, !- g-function Calculation Model Name
>UHFcalc, !- g-function Calculation Model Name
, !- GHE:Vertical:Array Object Name
BH1, !- GHE:Vertical:Single Object Name 1
BH2; !- GHE:Vertical:Single Object Name 2
```
<span style="color:red">UHFcalc, !- g-function Calculation Model Name</span>


```
!!! IDD Modifications !!!
GroundHeatExchanger:System,
\memo Models vertical ground heat exchangers systems using the response factor approach
\memo developed by Eskilson. Response factors are calculated using a finite line source
\memo model assuming uniform heat flux at the borehole wall if UHFcalc is specified,
\memo or uniform borehole wall temperature if UBHWTcalc is specified.
>\memo model assuming uniform heat flux at the borehole wall if UHFcalc is specified,
>\memo or uniform borehole wall temperature if UBHWTcalc is specified.
\extensible:1
\min-fields 9
A1, \field Name
Expand All @@ -230,7 +231,7 @@ GroundHeatExchanger:System,
A6, \field GHE:Vertical:ResponseFactors Object Name
\type object-list
\object-list GroundHeatExchangerVerticalResponseFactorNames
A7, \field g-function Calculation Model Name
>A7, \field g-function Calculation Model Name
\type choice
\key UHFcalc
\key UBHWTcalc
Expand All @@ -239,16 +240,6 @@ GroundHeatExchanger:System,
\object-list GroundHeatExchangerVerticalArrayNames
...
```
<span style="color:red">\memo model assuming uniform heat flux at the borehole
wall if UHFcalc is specified,</span>

<span style="color:red">\memo or uniform borehole wall temperature if UBHWTcalc
is specified.</span>

<span style="color:red">A7, \field g-function Calculation Model Name
\type choice
\key UHFcalc
\key UBHWTcalc</span>

## Engineering Reference Documentation

Expand Down

0 comments on commit e042488

Please sign in to comment.