Skip to content

Commit

Permalink
finish NFP
Browse files Browse the repository at this point in the history
  • Loading branch information
yzhou601 committed Jul 1, 2021
1 parent aaa71d3 commit 1edaf0c
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions design/FY2021/ReportIndividualInfiltrationObject.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,15 @@ The idea is to follow how`People` object is implemented to report both individua
The requested feature will be implemented by allocating new variable `state.dataHeatBal->Infiltration(NumInfil).HeatLoss`, etc. Since `state.dataHeatBal->Infiltration` already arranges and contains infiltration objects that only point to single zone (instead of zone or zone list), the total number of `state.dataHeatBal->Infiltration` should be equal to `state.dataHeatBal->TotInfiltration`. This structure will store calculated infiltration data at object level. It will be calculated at HVACManager.cc or ZoneEquipmentManager.cc or HeatBalanceAirManager.cc depending on detailed implementation.

New variables will be set up for Infiltration objects.

## Testing

No new example file needed. Assume it isn't supposed to be any diffs expected on ci testing. Local tests should verify that the new variables are able to be requested and reported correctly.

## Input Output Reference Documentation ##

Need to update the output descriptions for infiltration objects as reporting both at zone and individual object level.

## IDD Changes and Transition

None

5 comments on commit 1edaf0c

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infiltration-reporting (yzhou601) - x86_64-MacOS-10.15-clang-11.0.0: OK (3099 of 3099 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infiltration-reporting (yzhou601) - Win64-Windows-10-VisualStudio-16: OK (2349 of 2349 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infiltration-reporting (yzhou601) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3140 of 3140 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infiltration-reporting (yzhou601) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1654 of 1654 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infiltration-reporting (yzhou601) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (726 of 726 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.