Skip to content

Commit

Permalink
Merge pull request #10500 from NREL/Add-more-convergence-check-for-CO…
Browse files Browse the repository at this point in the history
…2-and-Cont

Add convergence check for co2 and contaminant
  • Loading branch information
Myoldmopar authored May 29, 2024
2 parents fcc6cf2 + 434b1dd commit 1b333b5
Show file tree
Hide file tree
Showing 6 changed files with 473 additions and 205 deletions.
26 changes: 18 additions & 8 deletions src/EnergyPlus/DataConvergParams.hh
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ namespace DataConvergParams {
constexpr Real64 HVACTemperatureSlopeToler(0.001); // Slope tolerance for Temperature, Deg C/iteration
constexpr Real64 HVACTemperatureOscillationToler(0.000001); // tolerance for detecting duplicate temps in stack
constexpr Real64 HVACEnergyToler(10.0); // Tolerance for Energy comparisons (in Watts W)
constexpr Real64 HVACCO2Toler(0.1); // Tolerance for CO2 comparisons (in ppm)
constexpr Real64 HVACGenContamToler(0.1); // Tolerance for generic contaminant comparisons (in ppm)
// to be consistent, should be 20.d0 (BG Aug 2012)

constexpr Real64 HVACCpApprox(1004.844); // Air Cp (20C,0.0Kg/Kg) Only for energy Tolerance Calculation
Expand Down Expand Up @@ -136,14 +138,22 @@ namespace DataConvergParams {
std::array<Real64, ConvergLogStackDepth> HVACTempSupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<bool, 3> HVACEnergyNotConverged = {false}; // Flag to show energy convergence or failure
std::array<Real64, ConvergLogStackDepth> HVACEnergyDemandToSupplyTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnergySupplyDeck1ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnergySupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnthalpyDemandToSupplyTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnthalpySupplyDeck1ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnthalpySupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACPressureDemandToSupplyTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACPressureSupplyDeck1ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACPressueSupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnergySupplyDeck1ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnergySupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnthalpyDemandToSupplyTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnthalpySupplyDeck1ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACEnthalpySupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACPressureDemandToSupplyTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACPressureSupplyDeck1ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACPressueSupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<bool, 3> HVACCO2NotConverged = {false}; // Flag to show mass flow convergence
std::array<Real64, ConvergLogStackDepth> HVACCO2DemandToSupplyTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACCO2SupplyDeck1ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACCO2SupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<bool, 3> HVACGenContamNotConverged = {false}; // Flag to show mass flow convergence
std::array<Real64, ConvergLogStackDepth> HVACGenContamDemandToSupplyTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACGenContamSupplyDeck1ToDemandTolValue = {0.0}; // Queue of convergence "results"
std::array<Real64, ConvergLogStackDepth> HVACGenContamSupplyDeck2ToDemandTolValue = {0.0}; // Queue of convergence "results"
};

struct PlantIterationConvergenceStruct
Expand Down
Loading

10 comments on commit 1b333b5

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-MacOS-10.18-clang-15.0.0: OK (2780 of 2780 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2779 of 2779 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (2801 of 2801 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1991 of 1991 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (791 of 791 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3398CondFDTempLimitsNeedMaxMinTempLimitWarnings (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2779 of 2779 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3398CondFDTempLimitsNeedMaxMinTempLimitWarnings (Myoldmopar) - x86_64-MacOS-10.18-clang-15.0.0: OK (3567 of 3567 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3398CondFDTempLimitsNeedMaxMinTempLimitWarnings (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3608 of 3608 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3398CondFDTempLimitsNeedMaxMinTempLimitWarnings (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1991 of 1991 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3398CondFDTempLimitsNeedMaxMinTempLimitWarnings (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (791 of 791 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.