Remove RoundSigDigits and TrimSigDigits, use libfmt

* Remove the RoundSigDigits and TrimSigDigits functions
  * They were over used and misused for integer->string conversions
* Merge any string concatenations that used Round/Trim functions
  into libfmt operations
* Overall binary is ~2% smaller
* Diff set still needs to be formatted

src/EnergyPlus/AirLoopHVACDOAS.cc

@@ -442,7 +442,7 @@ namespace AirLoopHVACDOAS {
                         if (!(CompNum == 1 || CompNum == state.dataAirLoop->OutsideAirSys(thisDOAS.m_OASystemNum).NumComponents)) {
                             ShowSevereError(state, "The fan placement is either first as blow through or last as draw through in" + CurrentModuleObject +
                                             " = " + state.dataAirLoop->OutsideAirSys(thisDOAS.m_OASystemNum).ComponentName(CompNum));
-                            ShowContinueError(state, "The current position is number " + General::RoundSigDigits(CompNum));
+                            ShowContinueError(state, format("The current position is number {}", CompNum));
                             errorsFound = true;
                         }
                     } else if (SELECT_CASE_var == "FAN:COMPONENTMODEL") {
@@ -461,7 +461,7 @@ namespace AirLoopHVACDOAS {
                         if (!(CompNum == 1 || CompNum == state.dataAirLoop->OutsideAirSys(thisDOAS.m_OASystemNum).NumComponents)) {
                             ShowSevereError(state, "The fan placement is either first as blow through or last as draw through in" + CurrentModuleObject +
                                             " = " + state.dataAirLoop->OutsideAirSys(thisDOAS.m_OASystemNum).ComponentName(CompNum));
-                            ShowContinueError(state, "The current position is number " + General::RoundSigDigits(CompNum));
+                            ShowContinueError(state, format("The current position is number {}", CompNum));
                             errorsFound = true;
                         }
                     } else if (SELECT_CASE_var == "COIL:COOLING:WATER") {
@@ -743,8 +743,7 @@ namespace AirLoopHVACDOAS {
                 thisDOAS.NumOfAirLoops = fields.at("number_of_airloophvac"); //
                 if (thisDOAS.NumOfAirLoops < 1) {
                     cFieldName = "Number of AirLoopHVAC";
-                    ShowSevereError(state, cCurrentModuleObject + ", \"" + thisDOAS.Name + "\" " + cFieldName + " = " +
-                                    General::TrimSigDigits(thisDOAS.NumOfAirLoops));
+                    ShowSevereError(state, fmt::format("{}, \"{}\" {} = {}", cCurrentModuleObject, thisDOAS.Name, cFieldName, thisDOAS.NumOfAirLoops));
                     ShowContinueError(state, " The minimum value should be 1.");
                     errorsFound = true;
                 }
@@ -1022,8 +1021,7 @@ namespace AirLoopHVACDOAS {
                 if (loop.ConveCount == 0) {
                     ++loop.ConveCount;
                     ShowWarningError(state, "Convergence limit is above 1.0e-6 for unit=" + loop.Name);
-                    ShowContinueErrorTimeStamp(state, "The max difference of node temperatures between AirLoopDOAS outlet and OA mixer inlet =" +
-                                               General::RoundSigDigits(maxDiff, 6));
+                    ShowContinueErrorTimeStamp(state, format("The max difference of node temperatures between AirLoopDOAS outlet and OA mixer inlet ={:.6R}", maxDiff));
                 } else {
                     ++loop.ConveCount;
                     ShowRecurringWarningErrorAtEnd(loop.Name +

src/EnergyPlus/AirflowNetwork/src/Properties.cpp

@@ -73,18 +73,15 @@ namespace AirflowNetwork {
             if (lowerLimitErrIdx == 0) {
                 ShowWarningMessage(state, "Air temperature below lower limit of -20C for conductivity calculation");
             }
-            ShowRecurringWarningErrorAtEnd("Air temperature below lower limit of -20C for conductivity calculation. "
-                                           "Air temperature of " + General::RoundSigDigits(LowerLimit, 1) +
-                                           " used for conductivity calculation.",
+            ShowRecurringWarningErrorAtEnd(format("Air temperature below lower limit of -20C for conductivity calculation. Air temperature of {:.1R} used for conductivity calculation.", LowerLimit),
                                            lowerLimitErrIdx);
             T = LowerLimit;
         } else if (T > UpperLimit) {
             if (upperLimitErrIdx == 0) {
                 ShowWarningMessage(state, "Air temperature above upper limit of 70C for conductivity calculation");
             }
-            ShowRecurringWarningErrorAtEnd("Air temperature below lower limit of 70C for conductivity calculation. "
-                                           "Air temperature of " + General::RoundSigDigits(UpperLimit, 1) +
-                                           " used for conductivity calculation.",
+            ShowRecurringWarningErrorAtEnd(format("Air temperature above upper limit of 70C for conductivity calculation. Air temperature of {:.1R} used for conductivity calculation.",
+                                                  UpperLimit),
                                            upperLimitErrIdx);
             T = UpperLimit;
         }