Fix for name issue raised in #170 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaquu
reviewed
Nov 2, 2019
Shaquu
requested changes
Nov 2, 2019
Shaquu
requested changes
Nov 2, 2019
lib/HAPBridgeNode.js
Outdated
| const paddedStr = noDecimalStr.padStart(16, '0') | ||
| return paddedStr.match(/.{1,2}/g).join(':') | ||
| const noDecimalStr = nodeId.replace('.', ''); | ||
| const paddedStr = noDecimalStr.padEnd(12, '0"); |
There was a problem hiding this comment.
Does it work? I can see single quote and double quote used (end of line 160, 0 has single quote on the left and double on the right).
There was a problem hiding this comment.
A big oops yesterday, I was trying to be quick with the browser editor, rather than using the proper tools
Shaquu
approved these changes
Nov 7, 2019
Shaquu
approved these changes
Nov 7, 2019
|
Thanks, hope it won't break anything. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will cause all end users devices to go "not responding" and you must unpair and repair in the Home app to resolve. You will lose all your room settings and automations with this fix.