Skip to content

Commit

Permalink
Merge pull request #207 from NRCHKB/dependencies
Browse files Browse the repository at this point in the history
1.0.0-dev.8
  • Loading branch information
Shaquu authored Jan 29, 2020
2 parents 72ec91b + b22f095 commit baec3f8
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 12 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Corrections regarding issue [#12](https://github.com/NRCHKB/node-red-contrib-homekit-bridged/issues/12) so that changes can be deployed without restarting node-red
- Automatically creating a new service and replacing the old one if the service type changed
- Automatically replacing an accessory with a new one if the accessory information changes (e.g. Name, Manufacturer, ...)
- Video Filter value in Camera Control is now optional [#194](https://github.com/NRCHKB/node-red-contrib-homekit-bridged/issues/194) (can be empty, before it was generated if was empty)
- Removed updateReachability as it is deprecated (and doesn't make a difference)

### Added

Expand Down
10 changes: 3 additions & 7 deletions lib/cameraSource/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -365,13 +365,9 @@ Camera.prototype.handleStreamRequest = function(request) {
let audioSsrc = sessionInfo['audio_ssrc']
let vf = []

let videoFilter =
this.videoFilter === ''
? 'scale=' + width + ':' + height + ''
: this.videoFilter // empty string indicates default
// In the case of null, skip entirely
if (videoFilter !== null && videoFilter !== 'none') {
vf.push(videoFilter)
// Skip vf entirely if videoFilter is empty
if (this.videoFilter !== null && this.videoFilter !== '') {
vf.push(this.videoFilter)

if (this.hflip) vf.push('hflip')

Expand Down
5 changes: 1 addition & 4 deletions lib/utils/ServiceUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,11 @@ module.exports = function(node) {
const noResponseMsg = 'NO_RESPONSE'

if (msg.payload[key] === noResponseMsg) {
node.accessory.updateReachability(false)
characteristic.updateValue(new Error(noResponseMsg))

return
}

node.accessory.updateReachability(true)

if (context !== null) {
characteristic.setValue(
msg.payload[key],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "node-red-contrib-homekit-bridged",
"version": "1.0.0-dev.8",
"version": "1.0.0-dev.9",
"description": "Node-RED nodes to simulate Apple HomeKit devices.",
"main": "homekit.js",
"scripts": {
Expand Down

0 comments on commit baec3f8

Please sign in to comment.