Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build workflow #206

Merged
merged 5 commits into from
Nov 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 60 additions & 41 deletions .github/workflows/ci_build.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
name: Build and test
name: Build and Test

on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

env:
BUILD_DIR: src\Build\Bin
MSBUILD_TOOLSET: v143
ARTIFACT_PREFIX: NppJSONViewer_

jobs:
build:

runs-on: windows-latest
strategy:
fail-fast: false
Expand All @@ -17,45 +21,60 @@ jobs:
build_platform: [Win32, x64, ARM64]

steps:
# Step 1: Check out the code from the repo
- name: Checkout repo
uses: actions/checkout@v4
with:
# Step 1: Check out the code from the repo
- name: Checkout repo
uses: actions/checkout@v4
with:
submodules: recursive

# Step 2: Prepare for build
- name: Pre Build
uses: microsoft/setup-msbuild@v2
# Step 2: Prepare for build
- name: Setup MSBuild
uses: microsoft/setup-msbuild@v2

# Step 3: Build projects and unit test
- name: Build
working-directory: src
run: msbuild NppJSONViewer.sln /m /p:configuration="${{ matrix.build_configuration }}" /p:platform="${{ matrix.build_platform }}" /p:PlatformToolset="v143"

# Step 4: Upload build binary artifacts
- name: Archive binaries artifacts
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.build_platform}}_${{ matrix.build_configuration}}
path: src\Build\Bin\${{ matrix.build_configuration}}\${{ matrix.build_platform}}\NPPJSONViewer.dll

# Step 5: Upload build pdb artifacts
- name: Archive symbols artifacts
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.build_platform}}_${{ matrix.build_configuration}}_pdb
path: src\Build\Bin\${{ matrix.build_configuration}}\${{ matrix.build_platform}}\NPPJSONViewer.pdb

# Step 6: Run unit tests for x86 | Release
- name: Run tests x86 | Release
if: matrix.build_platform == 'Win32' && matrix.build_configuration == 'Release'
run: |
cd src\Build\Bin\Release\Win32
./UnitTest.exe

# Step 7: Run unit tests for x64 | Release
- name: Run tests x64 | Release
if: matrix.build_platform == 'x64' && matrix.build_configuration == 'Release'
run: |
cd src\Build\Bin\Release\x64
./UnitTest.exe
# Step 3: Build projects and unit test
- name: Build code
working-directory: src
run: msbuild NppJSONViewer.sln /m /p:configuration="${{matrix.build_configuration}}" /p:platform="${{matrix.build_platform}}" /p:PlatformToolset=${{env.MSBUILD_TOOLSET}}

# Step 4: Upload build binary artifacts for deployment
- name: Archive binaries artifacts
uses: actions/upload-artifact@v4
with:
name: ${{env.ARTIFACT_PREFIX}}${{matrix.build_platform}}_${{matrix.build_configuration}}
path: ${{env.BUILD_DIR }}\${{matrix.build_configuration}}\${{matrix.build_platform}}\NPPJSONViewer.dll

# Step 5: Upload build pdb artifacts
- name: Archive symbols artifacts
uses: actions/upload-artifact@v4
with:
name: ${{env.ARTIFACT_PREFIX}}${{matrix.build_platform}}_${{matrix.build_configuration}}_pdb
path: ${{env.BUILD_DIR }}\${{matrix.build_configuration}}\${{matrix.build_platform}}\NPPJSONViewer.pdb

# Step 6: Run unit tests for x86 and x64
- name: Run unit tests
if: matrix.build_platform == 'Win32' || matrix.build_platform == 'x64'
run: |
cd ${{env.BUILD_DIR}}\${{matrix.build_configuration}}\${{matrix.build_platform}}
./UnitTest.exe

upload-full-artifacts:
# Trigger this job only after all 'build' jobs are complete
needs: build
runs-on: windows-latest
strategy:
fail-fast: true

steps:
# Step 7: Download all artifacts from the build job
- name: Download all artifacts
uses: actions/download-artifact@v4
with:
pattern: ${{env.ARTIFACT_PREFIX}}*
path: all_artifacts\

# Step 8: Upload consolidated artifacts as a single artifact
- name: Upload full artifact
uses: actions/upload-artifact@v4
with:
name: ${{env.ARTIFACT_PREFIX}}ALL
path: all_artifacts\**