Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Czech translation (by me) and usage of accented characters in fonts #1580

Open
ententeak opened this issue Aug 11, 2022 · 7 comments
Assignees
Labels
To be tested Dev is done, it should now be tested

Comments

@ententeak
Copy link

hello, i've made Czech translation, but dont know how to post it here on github, so here is my file.

Is your feature request related to a problem? Please describe.**

I just have issues with the used Font, where aren't accented symbols like ěščř...

Describe the solution you'd like

So if its possible to enable for translators to use "custom" fonts (*.ttf) and state them in the localizaton file to avoid this issue...

@antontimmermans
Copy link
Collaborator

@estarriol @NPBruce

  1. is this Czech easy to add/enable? there seems to be a placeholder for it in the Options menu.
  2. I suppose there is a solution for this special character issue? after all, it's not the first language in Valkyrie that uses special characters.

@ententeak
Copy link
Author

ententeak commented Aug 16, 2022

@estarriol @NPBruce

  1. is this Czech easy to add/enable? there seems to be a placeholder for it in the Options menu.

It's now possible in %Appdata%/Valkyrie/config.ini temporarily change language to Czech (the in app button is currently disabled)

Edit: since I don't own MoM, I'm not sure with some translations if they are lore or official translation - friendly...

@mayjak mayjak self-assigned this Oct 26, 2022
@mayjak
Copy link
Collaborator

mayjak commented Oct 26, 2022

Fonts used by valkyrie are available here:
https://github.com/NPBruce/valkyrie/tree/master/unity/Assets/Resources/Fonts

As far as fonts are concerned
D2E uses:
Gara_Scenario_Desc
Windl
Descent_symbol

MoM uses:
Mostly MAD Garamond Pro, which should support Czech.
Headers: OldNewspaperTypes, which doesn't support Czech diactrics

Currently I can't dynamically assign the font based on the language, but if you have font suggestions we can try to add that in a future release.

@mayjak
Copy link
Collaborator

mayjak commented Oct 26, 2022

I'll add the provided localization with standard fonts in 2.5.8 this week.

mayjak pushed a commit that referenced this issue Oct 26, 2022
@ententeak
Copy link
Author

Currently I can't dynamically assign the font based on the language, but if you have font suggestions we can try to add that in a future release.

I think this looks similar (Lucky Typewriter): https://www.ceskefonty.cz/ceske-fonty/lucky-typewriter
("Stáhnout font" = "Download font")

@mayjak mayjak added the To be tested Dev is done, it should now be tested label Oct 26, 2022
@antontimmermans
Copy link
Collaborator

Language is selectable on 2.5.8a Windows build.
I cannot verify the correctness.

@ententeak
Copy link
Author

Maybe for Descent can be used this font Ringbearer on CeskeFonty.cz (on DaFonts is font with the same name and design, but without accents)

And only "Menu's" are wrong. In Editor its okay...

Screenshot 2022-10-27 15 50 09
Screenshot 2022-10-27 15 53 34
Screenshot 2022-10-27 15 54 08
Screenshot 2022-10-27 15 57 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To be tested Dev is done, it should now be tested
Projects
None yet
Development

No branches or pull requests

3 participants