-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Trigger for final round #1571
Comments
ZZZTriggerTest 2.5.7b.zip
Up to(and including) step 11, the behavior seems working correctly. This means that if properly programmed, the scenario can end properly after the death of an investigator, without Mythos and without monster activation. |
With the same test scenario, the event sequence is now:
The only thing remaining is that if the Eliminated event is called, you have to hit the End Turn button again (step 12) to make it end the turn. In my opinion, this is not really a problem because this only happens if you have an event linked to the Eliminated trigger, which means that the scenario writer is handling it. If there is no event linked to the Eliminated trigger, the game just continues as before. I like the changed sequence of first calling StartFinalRound and then StartRound. |
Yes, the scenario should end either in Eliminated or Mythos triggers in this case. This is just meant as a failsafe for mishandled Eliminated events as I'd hate to lock the players out of the game cycle. I could theoretically check if the game ended after the Eliminated trigger was resolved, but due to asynchronous nature of it that's a lot more work and something I'm not comfortable changing right now. Maybe for a future release. |
Released in Valkyrie V2.5.7 |
Is your feature request related to a problem? Please describe.**
the current trigger for 'Eliminated' is called AFTER the next full round (including mythos and monster activation) after the menu option 'Investigator eliminated' is set.
This is almost as official rules dictate, with the exception of the additional Mythos and Monster Activation. There is no way to work around this in the scenarios.
Describe the solution you'd like
Add a trigger 'StartFinalRound' that is called at the start of the round when the menu option 'Investigator Eliminated' is selected.
The trigger condition would be : start round AND #eliminated='1'
This new trigger would allow the Scenario writer to for example:
Describe alternatives you've considered
Alternatively, a scenario writer could check for variables a the trigger 'EndInvestigatorTurn'
"#eliminated" - it means it's currently selected in the menu
"#eliminatedprev" - "Eliminated" was selected last turn (this is the last round of the game)
"#eliminatedcomplete" - this is set to 1 after the last investigator phase, when this is set to 1 it also triggers "Eliminated" events
However, these variables are NOT available in the Valkyrie editor which would mean that scenario writer would have to add that code with a text editor in the .ini files
An alternative solution could be to NOT add a trigger, But to make the #eliminatedprev variable selectable in the valkyrie editor, and then the scenario writer could check this at the StartRound or EndInvestigatorTurn trigger
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: