Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Continuing an Attack or Evade when the monster is fully damaged causes unintended behavior #1560

Open
Hobbeslionheart opened this issue Apr 2, 2022 · 2 comments
Assignees
Labels
bug To be tested Dev is done, it should now be tested

Comments

@Hobbeslionheart
Copy link

A clear and concise description of what the bug is.

Continuing an Attack or Evade when the monster is fully damaged causes unintended behavior. This leads to the finished or cancel button in the subsequent actions to not be able to be clicked which means the monster has to be defeated to advance which can be frustrating if accidentally clicked.

Steps to reproduce the behavior:

  1. Click on any monster.
  2. Increase their damage to the full capacity of the monster
  3. Click on Attack or Evade while the monster's health is full
  4. The Cancel Button or Finished button is grayed out, inactive.

A clear and concise description of what you expected to happen.

Either prevent an attack or an evade from happening when the monster's health is full or activate the button when the monster's health goes below maximum value.

Screenshots

image

Valkyrie Version

2.5.6

@Hobbeslionheart
Copy link
Author

I'm working to fix this as I noticed this while fixing #1548 , but just logging the issue it for tracking purposes.

Hobbeslionheart added a commit to Hobbeslionheart/valkyrie that referenced this issue May 3, 2022
Using the new methods in UIElement, the buttons have been refactored to be inactive to solve issue NPBruce#1560 if the monster's health is fully damaged. This will prevent some unintended behavior going forward, but more work will be needed in other scripts to prevent this.
@mayjak mayjak self-assigned this Oct 26, 2022
mayjak pushed a commit that referenced this issue Oct 26, 2022
mayjak pushed a commit that referenced this issue Oct 26, 2022
@mayjak mayjak added the To be tested Dev is done, it should now be tested label Oct 26, 2022
@antontimmermans
Copy link
Collaborator

Tested OK on 2.5.8a Windows build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug To be tested Dev is done, it should now be tested
Projects
None yet
Development

No branches or pull requests

3 participants