Added more logging for possible content pack download issues.

NPBruce · Dec 28, 2024 · e3199a7 · e3199a7
1 parent 7b1cea2
commit e3199a7
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/unity/Assets/Scripts/Content/ContentData.cs b/unity/Assets/Scripts/Content/ContentData.cs
@@ -279,12 +279,23 @@ private static ContentPack GetPackData(string path, string gameTypeName, bool ch
 
         // Some packs have a type
         string type = d.Get("ContentPack", "type");
-        if (!checkGameType || type.StartsWith(gameTypeName))
+        if (
+            !checkGameType || 
+            (
+                !string.IsNullOrWhiteSpace(gameTypeName) 
+                && type.StartsWith(gameTypeName)
+            )
+        )
         {
             var pack = GetContentPack(path, d, type);
+            if(pack == null)
+            {
+                ValkyrieDebug.Log("Could not find content pack file: " + path + $"Please check if type=\"{gameTypeName}\" was set correctly in content_pack.ini file.");
+            }
             return pack;
         }
 
+        ValkyrieDebug.Log("Could not find content pack file: " + path);
         return null;
     }
 

diff --git a/unity/Assets/Scripts/Content/RemoteContentPack.cs b/unity/Assets/Scripts/Content/RemoteContentPack.cs
@@ -27,7 +27,7 @@ public class RemoteContentPack
 
         public RemoteContentPack(string identifier, Dictionary<string, string> iniData)
         {
-            this.identifier = identifier.ToLower();
+            this.identifier = identifier;
             valid = Populate(iniData);
         }
 

diff --git a/unity/Assets/Scripts/UI/Screens/ContentSelectDownloadScreen.cs b/unity/Assets/Scripts/UI/Screens/ContentSelectDownloadScreen.cs
@@ -356,7 +356,7 @@ private void SetOnlineMode(bool go_online)
 
             DrawOnlineModeButton();
 
-           ReloadContentPackList();
+            ReloadContentPackList();
         }
 
         public void ReloadContentPackList()
@@ -371,17 +371,21 @@ public void ReloadContentPackList()
 
         public void CleanContentPackList()
         {
-            // Clean up everything marked as 'questlist'
+            // Clean up everything marked as 'CONTENTPACKLIST'
             foreach (GameObject go in GameObject.FindGameObjectsWithTag(Game.CONTENTPACKLIST))
+            {
                 Destroy(go);
+            }
 
             scrollArea = null;
 
             // quest images
             images_list.Clear();
 
             if (co_display != null)
+            {
                 StopCoroutine(co_display);
+            }
         }
 
         private void RemoteQuestsListDownload_cb(bool is_available)