Swap nwm-client
#268
Merged
Swap nwm-client
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like GH picked up the correctly named tests and they all passed! |
|
Great! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, let's rip this band-aid. This PR upgrades
nwm_client_newv8.0.0, renames it, replaces the oldnwm_clientand removes thenwm_client_newpackage. v8.0.0 of bothnwm_client_newandnwm_clienthave been deployed. The only difference apart from the package name is thatnwm_client_newraises aFutureWarningon import.This PR was always going to be messy due to the number of files edited and moved around.