Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nwm_client_new version inside package source #149

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Move nwm_client_new version inside package source #149

merged 1 commit into from
Nov 3, 2021

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Oct 29, 2021

Move nwm_client_new version inside package source following convention introduced in #142.

closes #144

Changes

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c merged commit 5f6ddaf into NOAA-OWP:main Nov 3, 2021
@jarq6c jarq6c mentioned this pull request Nov 3, 2021
Closed
@aaraney aaraney deleted the resolve_144 branch May 19, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarq6c jarq6c jarq6c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nwm_client_new does not have a __version__ attribute
2 participants
@aaraney @jarq6c